Final pass over the unaddressed AUDIT-2026-05-12 dossiers, taking the
tractable Critical/High items from each:
error-ux-auditor (5 items)
- C2: 17 toast.error(err.message) sites swept to toastError(err, …) so
every user-visible failure carries a copy-paste Reference ID
- C3: apiFetch synthesizes a client-side correlation id when a 5xx
comes back with a non-JSON body (reverse-proxy HTML pages); message
becomes "The server is unreachable. Please try again." with code
UPSTREAM_UNREACHABLE
- C4: checkRateLimit fails OPEN when Redis is unavailable so an outage
no longer 500s login + portal sign-in; logged at warn so monitoring
catches it
- H2: StorageTimeoutError (name='TimeoutError') replaces the plain
Error throw in s3.ts withTimeout — error-classifier hints fire now
- H5: errorResponse() adopted across /api/storage/[token],
/api/public/website-inquiries, and the Documenso webhook body (drops
the "Invalid secret" reconnaissance string)
outbound-webhook-auditor (5 items)
- C1: signature is now HMAC(secret, `${ts}.${body}`) with the
timestamp surfaced as X-Webhook-Timestamp so receivers can reject
replays outside a freshness window
- C3: dead-letter with reason missing_signing_secret when secret is
null (defence-in-depth against DB tampering / future migration
mistakes)
- H2: webhooks queue bumped to maxAttempts=8 with 30 s base
exponential backoff so a 30 s receiver blip during a deploy no
longer dead-letters every in-flight event; per-queue
backoffDelayMs added to QUEUE_CONFIGS
- M1: SSRF denylist gains Oracle Cloud metadata 192.0.0.192
- M2: dispatch-time https:// assertion before fetch, so a bad DB edit
can't slip plaintext through
storage-pathing-auditor (2 items)
- H1: berth-PDF presigned-upload keys now `${portSlug}/berths/…/…`
with portSlug threaded into backend.presignUpload — engages the
filesystem-proxy port-binding `p` token verifier
- H2: presignDownloadUrl auto-derives portSlug from the key's first
segment when callers don't pass it, so all 8 download sites engage
the `p`-token guard without per-site plumbing
search-auditor (1 item)
- H3: removed dead void wantEmail; void wantPhone; pair plus the
unused looksLikeEmail helper — the bucket-reorder it was scaffolded
for was never wired
maintainability-auditor (1 item)
- M2: swept seven abandoned `void <symbol>` markers and their dead
imports across clients/bulk, interests/bulk, admin/email-templates,
admin/website-submissions, alert-rules, and notes.service
Deferred to future work (substantial refactors, schema migrations, or
multi-file UI work):
- error-ux M3-M8 (global-error.tsx, per-route loading.tsx coverage,
ErrorBanner component, /api/ready route, worker DLQ admin surface)
- maintainability C1-C4 (documents/search/notes service splits,
interest-tabs split — multi-hour refactors)
- currency C1-H5 (mixed-currency dashboard aggregation, FX history
table, rounding policy) — wait for second non-USD port
- outbound-webhook C2 (deliveries reaper job), H1 (DNS-rebind TOCTOU
with undici Agent), H3 (circuit-breaker), H5 (presigned-post-policy)
- storage-pathing C2 (orphan reaper), H3-H5 (streaming + content-type
binding)
Tests: 1315/1315 vitest ✅ ; tsc clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
352 lines
12 KiB
TypeScript
352 lines
12 KiB
TypeScript
'use client';
|
|
|
|
import { useState } from 'react';
|
|
import { useParams } from 'next/navigation';
|
|
import { Plus, Archive, Tag as TagIcon, TagsIcon, Trash2 } from 'lucide-react';
|
|
import { useMutation, useQueryClient } from '@tanstack/react-query';
|
|
import { toast } from 'sonner';
|
|
|
|
import { Button } from '@/components/ui/button';
|
|
import { DataTable } from '@/components/shared/data-table';
|
|
import { FilterBar } from '@/components/shared/filter-bar';
|
|
import { SavedViewsDropdown } from '@/components/shared/saved-views-dropdown';
|
|
import { SaveViewDialog } from '@/components/shared/save-view-dialog';
|
|
import { PageHeader } from '@/components/shared/page-header';
|
|
import { EmptyState } from '@/components/shared/empty-state';
|
|
import { TableSkeleton } from '@/components/shared/loading-skeleton';
|
|
import { ArchiveConfirmDialog } from '@/components/shared/archive-confirm-dialog';
|
|
import { PermissionGate } from '@/components/shared/permission-gate';
|
|
import { TagPicker } from '@/components/shared/tag-picker';
|
|
import { BulkHardDeleteDialog } from '@/components/clients/bulk-hard-delete-dialog';
|
|
import { BulkArchiveWizard } from '@/components/clients/bulk-archive-wizard';
|
|
import { usePermissions } from '@/hooks/use-permissions';
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogDescription,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
} from '@/components/ui/dialog';
|
|
import { ClientForm } from '@/components/clients/client-form';
|
|
import { clientFilterDefinitions } from '@/components/clients/client-filters';
|
|
import { ClientCard } from '@/components/clients/client-card';
|
|
import {
|
|
CLIENT_COLUMN_OPTIONS,
|
|
CLIENT_DEFAULT_HIDDEN,
|
|
getClientColumns,
|
|
type ClientRow,
|
|
} from '@/components/clients/client-columns';
|
|
import { ColumnPicker } from '@/components/shared/column-picker';
|
|
import { useCreateFromUrl } from '@/hooks/use-create-from-url';
|
|
import { usePaginatedQuery } from '@/hooks/use-paginated-query';
|
|
import { useRealtimeInvalidation } from '@/hooks/use-realtime-invalidation';
|
|
import { useTablePreferences } from '@/hooks/use-table-preferences';
|
|
import { apiFetch } from '@/lib/api/client';
|
|
import { toastError } from '@/lib/api/toast-error';
|
|
|
|
export function ClientList() {
|
|
const params = useParams<{ portSlug: string }>();
|
|
const portSlug = params?.portSlug ?? '';
|
|
const queryClient = useQueryClient();
|
|
|
|
const [createOpen, setCreateOpen] = useState(false);
|
|
useCreateFromUrl(() => setCreateOpen(true));
|
|
const [editClient, setEditClient] = useState<ClientRow | null>(null);
|
|
const [archiveClient, setArchiveClient] = useState<ClientRow | null>(null);
|
|
const [tagDialog, setTagDialog] = useState<{ ids: string[]; mode: 'add' | 'remove' } | null>(
|
|
null,
|
|
);
|
|
const [tagChoice, setTagChoice] = useState<string[]>([]);
|
|
const [bulkDeleteIds, setBulkDeleteIds] = useState<string[]>([]);
|
|
const [bulkArchiveIds, setBulkArchiveIds] = useState<string[]>([]);
|
|
const [saveViewOpen, setSaveViewOpen] = useState(false);
|
|
|
|
const { can } = usePermissions();
|
|
const canHardDelete = can('admin', 'permanently_delete_clients');
|
|
const canBulkArchive = can('clients', 'delete');
|
|
const canBulkTag = can('clients', 'edit');
|
|
|
|
const {
|
|
data,
|
|
pagination,
|
|
isLoading,
|
|
isFetching,
|
|
sort,
|
|
setSort,
|
|
setPage,
|
|
setPageSize,
|
|
filters,
|
|
setFilter,
|
|
clearFilters,
|
|
} = usePaginatedQuery<ClientRow>({
|
|
queryKey: ['clients'],
|
|
endpoint: '/api/v1/clients',
|
|
filterDefinitions: clientFilterDefinitions,
|
|
});
|
|
|
|
useRealtimeInvalidation({
|
|
'client:created': [['clients']],
|
|
'client:updated': [['clients']],
|
|
'client:archived': [['clients']],
|
|
'client:restored': [['clients']],
|
|
});
|
|
|
|
const archiveMutation = useMutation({
|
|
mutationFn: (id: string) => apiFetch(`/api/v1/clients/${id}`, { method: 'DELETE' }),
|
|
onSuccess: () => {
|
|
queryClient.invalidateQueries({ queryKey: ['clients'] });
|
|
setArchiveClient(null);
|
|
},
|
|
});
|
|
|
|
const bulkMutation = useMutation({
|
|
mutationFn: async (
|
|
payload:
|
|
| { action: 'archive'; ids: string[] }
|
|
| { action: 'add_tag'; ids: string[]; tagId: string }
|
|
| { action: 'remove_tag'; ids: string[]; tagId: string },
|
|
) =>
|
|
apiFetch<{ data: { summary: { total: number; succeeded: number; failed: number } } }>(
|
|
'/api/v1/clients/bulk',
|
|
{ method: 'POST', body: payload },
|
|
),
|
|
onSuccess: (res) => {
|
|
queryClient.invalidateQueries({ queryKey: ['clients'] });
|
|
const s = res.data.summary;
|
|
if (s.failed > 0) {
|
|
toast.warning(`${s.succeeded} of ${s.total} succeeded. ${s.failed} failed.`);
|
|
} else if (s.succeeded > 0) {
|
|
toast.success(`${s.succeeded} client${s.succeeded === 1 ? '' : 's'} updated.`);
|
|
}
|
|
},
|
|
onError: (err: unknown) => {
|
|
toastError(err, 'Bulk action failed');
|
|
},
|
|
});
|
|
|
|
const columns = getClientColumns({
|
|
portSlug,
|
|
onEdit: (client) => setEditClient(client),
|
|
onArchive: (client) => setArchiveClient(client),
|
|
});
|
|
|
|
// Per-user column visibility, persisted into user_profiles.preferences
|
|
// via /api/v1/me. Hidden IDs are the source of truth — `actions` and
|
|
// `select` columns aren't user-toggleable so they're never in the
|
|
// hidden set. New columns surface for existing users by default.
|
|
const { hidden, setHidden } = useTablePreferences('clients', CLIENT_DEFAULT_HIDDEN);
|
|
const columnVisibility = Object.fromEntries(hidden.map((id) => [id, false]));
|
|
|
|
return (
|
|
<div className="space-y-4">
|
|
<PageHeader title="Clients" description="Manage your client records" variant="gradient" />
|
|
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
<FilterBar
|
|
filters={clientFilterDefinitions}
|
|
values={filters}
|
|
onChange={setFilter}
|
|
onClear={clearFilters}
|
|
/>
|
|
<SavedViewsDropdown
|
|
entityType="clients"
|
|
onApplyView={(savedFilters, _savedSort) => {
|
|
clearFilters();
|
|
Object.entries(savedFilters).forEach(([key, val]) => setFilter(key, val));
|
|
}}
|
|
/>
|
|
<ColumnPicker
|
|
columns={CLIENT_COLUMN_OPTIONS}
|
|
hidden={hidden}
|
|
onChange={setHidden}
|
|
onSaveView={() => setSaveViewOpen(true)}
|
|
/>
|
|
{/* New Client moved out of PageHeader actions and into the
|
|
filter row. Saves a row on mobile (no more dedicated
|
|
actions strip). ml-auto keeps the primary action at the
|
|
far-right edge, which is where reps look first. */}
|
|
<PermissionGate resource="clients" action="create">
|
|
<Button size="sm" className="ml-auto" onClick={() => setCreateOpen(true)}>
|
|
<Plus className="mr-1.5 h-4 w-4" aria-hidden />
|
|
New Client
|
|
</Button>
|
|
</PermissionGate>
|
|
</div>
|
|
|
|
<SaveViewDialog
|
|
open={saveViewOpen}
|
|
onOpenChange={setSaveViewOpen}
|
|
entityType="clients"
|
|
currentFilters={filters}
|
|
currentSort={sort}
|
|
/>
|
|
|
|
{isLoading ? (
|
|
<TableSkeleton />
|
|
) : (
|
|
<DataTable
|
|
columns={columns}
|
|
columnVisibility={columnVisibility}
|
|
data={data}
|
|
pagination={pagination}
|
|
onPaginationChange={(p, ps) => {
|
|
setPage(p);
|
|
setPageSize(ps);
|
|
}}
|
|
sort={sort}
|
|
onSortChange={setSort}
|
|
isLoading={isFetching && !isLoading}
|
|
getRowId={(row) => row.id}
|
|
bulkActions={[
|
|
...(canBulkTag
|
|
? [
|
|
{
|
|
label: 'Add tag',
|
|
icon: TagIcon,
|
|
onClick: (ids: string[]) => {
|
|
if (ids.length === 0) return;
|
|
setTagChoice([]);
|
|
setTagDialog({ ids, mode: 'add' });
|
|
},
|
|
},
|
|
{
|
|
label: 'Remove tag',
|
|
icon: TagsIcon,
|
|
onClick: (ids: string[]) => {
|
|
if (ids.length === 0) return;
|
|
setTagChoice([]);
|
|
setTagDialog({ ids, mode: 'remove' });
|
|
},
|
|
},
|
|
]
|
|
: []),
|
|
...(canBulkArchive
|
|
? [
|
|
{
|
|
label: 'Archive',
|
|
icon: Archive,
|
|
variant: 'destructive' as const,
|
|
onClick: (ids: string[]) => {
|
|
if (ids.length === 0) return;
|
|
setBulkArchiveIds(ids);
|
|
},
|
|
},
|
|
]
|
|
: []),
|
|
...(canHardDelete
|
|
? [
|
|
{
|
|
label: 'Permanently delete (archived only)',
|
|
icon: Trash2,
|
|
variant: 'destructive' as const,
|
|
onClick: (ids: string[]) => {
|
|
if (ids.length === 0) return;
|
|
setBulkDeleteIds(ids);
|
|
},
|
|
},
|
|
]
|
|
: []),
|
|
]}
|
|
cardRender={(row) => (
|
|
<ClientCard
|
|
client={row.original}
|
|
portSlug={portSlug}
|
|
onEdit={setEditClient}
|
|
onArchive={setArchiveClient}
|
|
/>
|
|
)}
|
|
emptyState={
|
|
<EmptyState
|
|
title="No clients found"
|
|
description="Get started by adding your first client."
|
|
action={{ label: 'New Client', onClick: () => setCreateOpen(true) }}
|
|
/>
|
|
}
|
|
/>
|
|
)}
|
|
|
|
{/* Bulk tag add/remove */}
|
|
<Dialog open={!!tagDialog} onOpenChange={(o) => !o && setTagDialog(null)}>
|
|
<DialogContent>
|
|
<DialogHeader>
|
|
<DialogTitle>{tagDialog?.mode === 'add' ? 'Add tag' : 'Remove tag'}</DialogTitle>
|
|
<DialogDescription>
|
|
{tagDialog?.mode === 'add'
|
|
? `Add a tag to ${tagDialog?.ids.length ?? 0} selected client${tagDialog?.ids.length === 1 ? '' : 's'}.`
|
|
: `Remove a tag from ${tagDialog?.ids.length ?? 0} selected client${tagDialog?.ids.length === 1 ? '' : 's'}. Clients without the tag are unchanged.`}
|
|
</DialogDescription>
|
|
</DialogHeader>
|
|
<div className="py-2">
|
|
<TagPicker
|
|
selectedIds={tagChoice}
|
|
onChange={(ids) => setTagChoice(ids.slice(-1))}
|
|
placeholder="Pick one tag…"
|
|
/>
|
|
<p className="text-xs text-muted-foreground mt-2">
|
|
Pick a single tag. To apply multiple tags, run the action once per tag.
|
|
</p>
|
|
</div>
|
|
<DialogFooter>
|
|
<Button variant="outline" onClick={() => setTagDialog(null)}>
|
|
Cancel
|
|
</Button>
|
|
<Button
|
|
disabled={bulkMutation.isPending || tagChoice.length === 0}
|
|
onClick={() => {
|
|
if (!tagDialog || tagChoice.length === 0) return;
|
|
const tagId = tagChoice[0];
|
|
if (!tagId) return;
|
|
bulkMutation.mutate(
|
|
{
|
|
action: tagDialog.mode === 'add' ? 'add_tag' : 'remove_tag',
|
|
ids: tagDialog.ids,
|
|
tagId,
|
|
},
|
|
{ onSettled: () => setTagDialog(null) },
|
|
);
|
|
}}
|
|
>
|
|
Apply
|
|
</Button>
|
|
</DialogFooter>
|
|
</DialogContent>
|
|
</Dialog>
|
|
|
|
<ClientForm open={createOpen} onOpenChange={setCreateOpen} />
|
|
|
|
{editClient && (
|
|
<ClientForm
|
|
open={!!editClient}
|
|
onOpenChange={(open) => !open && setEditClient(null)}
|
|
client={editClient as unknown as NonNullable<Parameters<typeof ClientForm>[0]['client']>}
|
|
/>
|
|
)}
|
|
|
|
<ArchiveConfirmDialog
|
|
open={!!archiveClient}
|
|
onOpenChange={(open) => !open && setArchiveClient(null)}
|
|
entityName={archiveClient?.fullName ?? ''}
|
|
entityType="Client"
|
|
isArchived={false}
|
|
onConfirm={() => archiveClient && archiveMutation.mutate(archiveClient.id)}
|
|
isLoading={archiveMutation.isPending}
|
|
/>
|
|
|
|
<BulkHardDeleteDialog
|
|
open={bulkDeleteIds.length > 0}
|
|
onOpenChange={(open) => !open && setBulkDeleteIds([])}
|
|
clientIds={bulkDeleteIds}
|
|
onDeleted={() => setBulkDeleteIds([])}
|
|
/>
|
|
|
|
<BulkArchiveWizard
|
|
open={bulkArchiveIds.length > 0}
|
|
onOpenChange={(open) => !open && setBulkArchiveIds([])}
|
|
clientIds={bulkArchiveIds}
|
|
onSuccess={() => setBulkArchiveIds([])}
|
|
/>
|
|
</div>
|
|
);
|
|
}
|