Files
pn-new-crm/tests/e2e/smoke/19-system-monitoring.spec.ts
Matt Ciaccio 0406778c44 fix(api): kill currentPortId persist race + dedupe admin/ports stampede
The dashboard and residential interest smoke tests were intermittently
failing with the page rendering empty/skeleton state. Root causes:

1. ui-store persisted currentPortId/Slug, but those are URL-derived state.
   After login lands on /<first-port-by-name>/dashboard, localStorage holds
   that port. Hard-navigating to /port-nimara/... rehydrated the store with
   the stale id, and useQuery fired with the wrong port before
   PortProvider's URL-sync useEffect could correct it. Drop both fields
   from partialize — PortProvider re-derives them from the route every
   navigation.

2. apiFetch's slug-to-port fallback fired N parallel /api/v1/admin/ports
   calls when N components mounted simultaneously with an empty store.
   Dedupe in-flight lookups so a stampede collapses into one round-trip.

Also tightened four flaky smoke tests that depended on a fixed 3s wait or
non-waiting isVisible({timeout}) — replaced with expect(...).toBeVisible
or expect.poll so they handle dev-mode JIT cold-start delays cleanly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-28 04:38:57 +02:00

107 lines
4.1 KiB
TypeScript

import { test, expect } from '@playwright/test';
import { login, navigateTo } from './helpers';
test.describe('System Monitoring', () => {
// Test 43: Monitoring dashboard shows health checks
test('system monitoring shows service health', async ({ page }) => {
await login(page, 'super_admin');
await navigateTo(page, '/admin/monitoring');
await page.waitForTimeout(3_000);
// Should see health status indicators for services
const pgStatus = page.getByText(/postgres/i).first();
const redisStatus = page.getByText(/redis/i).first();
const minioStatus = page.getByText(/minio/i).first();
await expect(pgStatus).toBeVisible({ timeout: 10_000 });
await expect(redisStatus).toBeVisible({ timeout: 5_000 });
await expect(minioStatus).toBeVisible({ timeout: 5_000 });
// Should show healthy/degraded/down indicators
const healthIndicators = page.getByText(/healthy|degraded|down/i);
const indicatorCount = await healthIndicators.count();
expect(indicatorCount).toBeGreaterThanOrEqual(1);
});
// Test 44: All 10 BullMQ queues listed
test('all BullMQ queues listed with stats', async ({ page }) => {
await login(page, 'super_admin');
await navigateTo(page, '/admin/monitoring');
// Anchor on a queue-only name (not in sidebar) to confirm the panel
// has finished loading before counting matches.
await expect(page.getByText('webhooks', { exact: false }).first()).toBeVisible({
timeout: 15_000,
});
// Expected queue names from QUEUE_CONFIGS
const queueNames = [
'email',
'documents',
'notifications',
'import',
'export',
'reports',
'webhooks',
'maintenance',
'ai',
'bulk',
];
let foundCount = 0;
for (const name of queueNames) {
const queueCard = page.getByText(name, { exact: false }).first();
if (await queueCard.isVisible().catch(() => false)) {
foundCount++;
}
}
// Should find most/all queues (at least 8 out of 10)
expect(foundCount).toBeGreaterThanOrEqual(8);
// Each queue should show numeric stats. Cards render <span>{value}</span> pills
const numericStats = page.locator('main span').filter({ hasText: /^\d+$/ });
const statsCount = await numericStats.count();
expect(statsCount).toBeGreaterThan(0);
});
// Test 45: Sales agent cannot access monitoring
test('sales agent blocked from monitoring', async ({ page }) => {
await login(page, 'sales_agent');
await page.waitForTimeout(2_000);
// Try to access monitoring via API. 400 (missing port context) is also a valid
// blocking response for non-super_admins — the API requires port context for
// regular users, and super_admins bypass it. So 400/401/403 all mean "blocked".
const healthRes = await page.request.get('/api/v1/admin/health');
expect([400, 401, 403].includes(healthRes.status())).toBeTruthy();
const queuesRes = await page.request.get('/api/v1/admin/queues');
expect([400, 401, 403].includes(queuesRes.status())).toBeTruthy();
// Try accessing the page directly. API-level (above) is the real boundary.
// UI may navigate to the page, but with APIs returning 403 no queue data renders —
// which is the observable effect of being "blocked" from data.
await navigateTo(page, '/admin/monitoring');
await page.waitForTimeout(3_000);
const url = page.url();
const hasPermError = await page
.getByText(/permission|forbidden|access denied|not authorized/i)
.first()
.isVisible({ timeout: 3_000 })
.catch(() => false);
const wasRedirected = !url.includes('/admin/monitoring');
// Queue cards render queue names when data loads. With 403, no cards render.
// Queue names render as CardTitle elements in the main content area.
// Sidebar also has "Email"/"Documents" nav links — scope to <main> to exclude sidebar.
const queueCardCount = await page
.locator('main')
.getByText(/^(webhooks|notifications|reports|maintenance|ai|bulk)$/i)
.count();
const dataLeaked = queueCardCount > 0;
expect(hasPermError || wasRedirected || !dataLeaked).toBeTruthy();
});
});