73-file atomic rename per docs/tenancies-design.md:
- Migration 0085: rename table + indexes + FK constraints; rename
documents.reservation_id → tenancy_id; migrate jsonb permission maps
(reservations resource → tenancies; collapse create+activate → manage);
rewrite historical audit_logs.entity_type='berth_reservation' →
'berth_tenancy'. FK renames wrapped in DO blocks so dev DBs that pre-date
the FK additions don't abort.
- Schema: berthReservations → berthTenancies; BerthReservation type →
BerthTenancy; indexes idx_br_* / idx_brr_* → idx_bt_*.
- RolePermissions: resource { view, create, activate, cancel } collapses to
{ view, manage, cancel }; all 8 default seed bundles + role-form + matrix
updated.
- Service: berth-reservations.service.ts → berth-tenancies.service.ts;
endReservation → endTenancy; listReservations → listTenancies.
- API: /api/v1/berth-reservations → /api/v1/tenancies (+ nested [id]);
/api/v1/berths/[id]/reservations → /api/v1/berths/[id]/tenancies.
- Validators: reservations.ts → tenancies.ts; RESERVATION_STATUSES →
TENANCY_STATUSES; endReservationSchema → endTenancySchema.
- Routes: /{portSlug}/berth-reservations → /{portSlug}/tenancies;
/portal/my-reservations → /portal/my-tenancies.
- Components: src/components/reservations/* → src/components/tenancies/*;
BerthReservationsTab → BerthTenanciesTab; ClientReservationsTab →
ClientTenanciesTab; ReservationList → TenancyList.
- Socket events: berth_reservation:* → berth_tenancy:*; payload
reservationId → tenancyId.
- Webhook events: berth_reservation.* → berth_tenancy.*.
- Portal: getPortalUserReservations → getPortalUserTenancies;
PortalReservation → PortalTenancy; PortalDashboard.counts.activeReservations
→ activeTenancies; PortalNav label "Reservations" → "Tenancies".
- Dossier: DossierReservation → DossierTenancy; reservationDecisions →
tenancyDecisions across smart-archive-dialog + bulk-archive routes.
- Documents schema: documents.reservationId → documents.tenancyId
(TS + DB column + index + FK constraint).
- Activity feed label berth_reservation → berth_tenancy (matched against
migrated historical audit rows).
KEPT (separate concepts):
- Reservation Agreement document type (the contract sent to clients).
- "Reservation" pipeline stage name.
- {{reservation.*}} merge tokens in template authoring.
- interest.reservationStatus / reservationDocStatus / dateReservationSent
fields (track agreement signing on the deal).
- reservation-agreement-context.ts service (builds merge context for the
Reservation Agreement doc; only its DB imports were renamed).
Verified: tsc clean, 1480/1480 vitest passing, migration applied.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
176 lines
5.6 KiB
TypeScript
176 lines
5.6 KiB
TypeScript
/**
|
|
* Schema constraint integration tests.
|
|
*
|
|
* Verifies DB-level enforcement of:
|
|
* - Partial unique index idx_yoh_active (one active ownership row per yacht)
|
|
* - Partial unique index idx_br_active (one active reservation per berth)
|
|
* - Non-active reservations on the same berth are permitted
|
|
* - Case-insensitive company name uniqueness within a port
|
|
* - Same company name allowed across different ports
|
|
*/
|
|
import { describe, it, expect, beforeAll } from 'vitest';
|
|
|
|
import { db } from '@/lib/db';
|
|
import { yachtOwnershipHistory } from '@/lib/db/schema/yachts';
|
|
import { berthTenancies } from '@/lib/db/schema/tenancies';
|
|
import { companies } from '@/lib/db/schema/companies';
|
|
import { makeBerth, makeClient, makeCompany, makePort, makeYacht } from '../helpers/factories';
|
|
|
|
// ─── DB availability ─────────────────────────────────────────────────────────
|
|
|
|
let dbAvailable = false;
|
|
|
|
beforeAll(async () => {
|
|
try {
|
|
await db.execute(`SELECT 1`);
|
|
dbAvailable = true;
|
|
} catch (err) {
|
|
console.warn(
|
|
'[schema-constraints] DATABASE_URL not reachable - skipping integration tests',
|
|
err,
|
|
);
|
|
}
|
|
});
|
|
|
|
function itDb(name: string, fn: () => Promise<void>) {
|
|
it(name, async () => {
|
|
if (!dbAvailable) return;
|
|
await fn();
|
|
});
|
|
}
|
|
|
|
// ─── Tests ───────────────────────────────────────────────────────────────────
|
|
|
|
describe('schema constraints', () => {
|
|
itDb(
|
|
'rejects a second active ownership row per yacht (partial unique idx_yoh_active)',
|
|
async () => {
|
|
const port = await makePort();
|
|
const clientA = await makeClient({ portId: port.id });
|
|
const clientB = await makeClient({ portId: port.id });
|
|
const yacht = await makeYacht({
|
|
portId: port.id,
|
|
ownerType: 'client',
|
|
ownerId: clientA.id,
|
|
});
|
|
// makeYacht already inserted one active (end_date IS NULL) ownership row.
|
|
|
|
await expect(
|
|
db.insert(yachtOwnershipHistory).values({
|
|
yachtId: yacht.id,
|
|
ownerType: 'client',
|
|
ownerId: clientB.id,
|
|
startDate: new Date(),
|
|
endDate: null, // another open row - should violate partial unique
|
|
createdBy: 'test',
|
|
}),
|
|
).rejects.toMatchObject({
|
|
cause: expect.objectContaining({ code: '23505' }),
|
|
});
|
|
},
|
|
);
|
|
|
|
itDb('rejects a second active reservation per berth (partial unique idx_br_active)', async () => {
|
|
const port = await makePort();
|
|
const clientA = await makeClient({ portId: port.id });
|
|
const clientB = await makeClient({ portId: port.id });
|
|
const yachtA = await makeYacht({
|
|
portId: port.id,
|
|
ownerType: 'client',
|
|
ownerId: clientA.id,
|
|
});
|
|
const yachtB = await makeYacht({
|
|
portId: port.id,
|
|
ownerType: 'client',
|
|
ownerId: clientB.id,
|
|
});
|
|
const berth = await makeBerth({ portId: port.id });
|
|
|
|
await db.insert(berthTenancies).values({
|
|
berthId: berth.id,
|
|
portId: port.id,
|
|
clientId: clientA.id,
|
|
yachtId: yachtA.id,
|
|
status: 'active',
|
|
startDate: new Date(),
|
|
createdBy: 'test',
|
|
});
|
|
|
|
await expect(
|
|
db.insert(berthTenancies).values({
|
|
berthId: berth.id,
|
|
portId: port.id,
|
|
clientId: clientB.id,
|
|
yachtId: yachtB.id,
|
|
status: 'active',
|
|
startDate: new Date(),
|
|
createdBy: 'test',
|
|
}),
|
|
).rejects.toMatchObject({
|
|
cause: expect.objectContaining({ code: '23505' }),
|
|
});
|
|
});
|
|
|
|
itDb(
|
|
'allows multiple non-active reservations on the same berth (partial index ignores non-active)',
|
|
async () => {
|
|
const port = await makePort();
|
|
const clientA = await makeClient({ portId: port.id });
|
|
const yachtA = await makeYacht({
|
|
portId: port.id,
|
|
ownerType: 'client',
|
|
ownerId: clientA.id,
|
|
});
|
|
const berth = await makeBerth({ portId: port.id });
|
|
|
|
// Two ended reservations on same berth - both should succeed
|
|
// (partial index only constrains status='active').
|
|
await expect(
|
|
db.insert(berthTenancies).values([
|
|
{
|
|
berthId: berth.id,
|
|
portId: port.id,
|
|
clientId: clientA.id,
|
|
yachtId: yachtA.id,
|
|
status: 'ended',
|
|
startDate: new Date('2024-01-01'),
|
|
endDate: new Date('2024-06-30'),
|
|
createdBy: 'test',
|
|
},
|
|
{
|
|
berthId: berth.id,
|
|
portId: port.id,
|
|
clientId: clientA.id,
|
|
yachtId: yachtA.id,
|
|
status: 'ended',
|
|
startDate: new Date('2024-07-01'),
|
|
endDate: new Date('2024-12-31'),
|
|
createdBy: 'test',
|
|
},
|
|
]),
|
|
).resolves.toBeDefined();
|
|
},
|
|
);
|
|
|
|
itDb('enforces case-insensitive company name uniqueness per port', async () => {
|
|
const port = await makePort();
|
|
await makeCompany({ portId: port.id, overrides: { name: 'Aegean Holdings' } });
|
|
|
|
await expect(
|
|
db.insert(companies).values({ portId: port.id, name: 'AEGEAN HOLDINGS' }),
|
|
).rejects.toMatchObject({
|
|
cause: expect.objectContaining({ code: '23505' }),
|
|
});
|
|
});
|
|
|
|
itDb('allows same-name companies in different ports', async () => {
|
|
const portA = await makePort();
|
|
const portB = await makePort();
|
|
await makeCompany({ portId: portA.id, overrides: { name: 'Aegean Holdings' } });
|
|
|
|
await expect(
|
|
db.insert(companies).values({ portId: portB.id, name: 'Aegean Holdings' }),
|
|
).resolves.toBeDefined();
|
|
});
|
|
});
|