chore(copy): em-dash sweep across user-facing JSX text + bump lint to error

Replaced 174 em-dashes (—) with " - " (space-hyphen-space) across 49
files in src/components + src/app. The em-dash reads as a tell-tale
"AI-generated" marker per the user's design feedback; hyphens with
spaces preserve the connector semantics without the AI tint.

Touched only lines outside pure-comment context (// /* * */). Code
comments, JSDoc, audit-log strings, structured logging strings, and
templates outside the lint scope retain their em-dashes for now —
they're not user-visible.

Also captured two remaining cases that used the `—` HTML entity
instead of the literal character (system-monitoring-dashboard,
interest-stage-picker) — replaced with a plain hyphen.

Bumped the existing `no-restricted-syntax` rule from `warn` → `error`
in eslint.config.mjs scoped to src/components/**/*.tsx +
src/app/**/*.tsx. New code reintroducing em-dashes in JSX text now
fails the lint gate.

Verified: tsc clean, vitest 1448/1448, eslint 0 em-dash warnings.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

src/components/admin/bulk-add-berths-wizard.tsx

@@ -192,7 +192,7 @@ export function BulkAddBerthsWizard() {
     return (
       <Card>
         <CardHeader>
-          <CardTitle>Step 1 — Sequence</CardTitle>
+          <CardTitle>Step 1 - Sequence</CardTitle>
           <CardDescription>
             Pick the dock letter and the mooring-number range. Tenure + status apply to every row;
             everything else (dimensions, pricing, pontoon) is filled per row in Step 2.
@@ -265,7 +265,7 @@ export function BulkAddBerthsWizard() {
   return (
     <Card>
       <CardHeader>
-        <CardTitle>Step 2 — Fill in each row</CardTitle>
+        <CardTitle>Step 2 - Fill in each row</CardTitle>
         <CardDescription>
           Per-row dimensions, pricing, pontoon. Use the &ldquo;Apply to all&rdquo; inputs in the
           header to copy a value down every row at once.
@@ -435,7 +435,7 @@ export function BulkAddBerthsWizard() {
                           <SelectValue />
                         </SelectTrigger>
                         <SelectContent>
-                          <SelectItem value="__none__">—</SelectItem>
+                          <SelectItem value="__none__"> - </SelectItem>
                           {sidePontoonOptions.filter(Boolean).map((p) => (
                             <SelectItem key={p} value={p}>
                               {p}