matt/opnform-host-nginx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add 'exists_in_submissions' and 'does_not_exist_in_submissions' valid… (#725)

Browse Source 
* Add 'exists_in_submissions' and 'does_not_exist_in_submissions' validation conditions

- Implement new validation conditions in FormLogicConditionChecker to check for existing submissions.
- Update open_filters.json and client-side filters to include the new conditions.
- Enhance FormLogicTest with test cases for the new validation conditions.
- Modify UI components to support the new logic conditions in form validation.

* Fix FormLogicConditionChecker

* Improve custom_validation_only

* fix test

---------

Co-authored-by: Julien Nahum <julien@nahum.net>
This commit is contained in:
Chirag Chhatrala
2025-03-25 16:20:59 +05:30
committed by GitHub
parent 2c746437c9
commit fba2207e0f
7 changed files with 329 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

99
api/tests/Feature/Forms/FormLogicTest.php
View File

@@ -607,3 +607,102 @@ it('skips validation for fields hidden by logic conditions', function () {
],
]);
});
it('cannot submit form with failed exists_in_submissions validation condition', function () {
$user = $this->actingAsUser();
$workspace = $this->createUserWorkspace($user);
$form = $this->createForm($user, $workspace);
$targetField = collect($form->properties)->where('name', 'Email')->first();
// First set up the validation condition
$condition = [
'actions' => [],
'conditions' => [
'operatorIdentifier' => 'and',
'children' => [
[
'identifier' => $targetField['id'],
'value' => [
'operator' => 'exists_in_submissions',
'property_meta' => [
'id' => $targetField['id'],
'type' => 'text',
],
],
],
],
],
];
$validationMessage = 'Email already exists in previous submissions';
$form->properties = collect($form->properties)->map(function ($property) use ($condition, $validationMessage, $targetField) {
if (in_array($property['name'], ['Name'])) {
$property['validation'] = ['error_conditions' => $condition, 'error_message' => $validationMessage];
}
return $property;
})->toArray();
$form->update();
$formData = [$targetField['id'] => 'existing@test.com'];
$this->postJson(route('forms.answer', $form->slug), $formData)
->assertStatus(422)
->assertJson([
'message' => $validationMessage,
]);
});
it('cannot submit form with failed does_not_exist_in_submissions validation condition', function () {
$user = $this->actingAsUser();
$workspace = $this->createUserWorkspace($user);
$form = $this->createForm($user, $workspace);
$targetField = collect($form->properties)->where('name', 'Email')->first();
// First set up the validation condition
$condition = [
'actions' => [],
'conditions' => [
'operatorIdentifier' => 'and',
'children' => [
[
'identifier' => $targetField['id'],
'value' => [
'operator' => 'does_not_exist_in_submissions',
'property_meta' => [
'id' => $targetField['id'],
'type' => 'text',
],
],
],
],
],
];
$validationMessage = 'Email already exists in previous submissions';
$form->properties = collect($form->properties)->map(function ($property) use ($condition, $validationMessage, $targetField) {
if (in_array($property['name'], ['Name'])) {
$property['validation'] = ['error_conditions' => $condition, 'error_message' => $validationMessage];
}
return $property;
})->toArray();
$form->update();
$formData = [$targetField['id'] => 'existing@test.com'];
$this->postJson(route('forms.answer', $form->slug), $formData)
->assertSuccessful()
->assertJson([
'type' => 'success',
'message' => 'Form submission saved.',
]);
$this->postJson(route('forms.answer', $form->slug), $formData)
->assertStatus(422)
->assertJson([
'message' => $validationMessage,
]);
});