matt/opnform-host-nginx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor form submission processing with new FormSubmissionProcessor

Browse Source 
- Introduce FormSubmissionProcessor service to handle synchronous/asynchronous form submission logic
- Modify PublicFormController to use new processor for submission and redirect handling
- Update StoreFormSubmissionJob to support processed data retrieval
- Add comprehensive test suite for FormSubmissionProcessor
- Improve handling of generated fields and redirect URL processing
This commit is contained in:
Julien Nahum
2025-02-01 22:52:06 +01:00
parent bb34cd98e5
commit f350ed778c
4 changed files with 254 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

154
api/tests/Feature/Forms/FormSubmissionProcessorTest.php Normal file
View File

@@ -0,0 +1,154 @@
<?php
use App\Service\Forms\FormSubmissionProcessor;
it('processes synchronously with editable submissions', function () {
$user = $this->actingAsUser();
$workspace = $this->createUserWorkspace($user);
$form = $this->createForm($user, $workspace, [
'editable_submissions' => true
]);
$processor = new FormSubmissionProcessor();
expect($processor->shouldProcessSynchronously($form))->toBeTrue();
});
it('processes synchronously with UUID field in redirect URL', function () {
$user = $this->actingAsUser();
$workspace = $this->createUserWorkspace($user);
$form = $this->createForm($user, $workspace, [
'redirect_url' => 'https://example.com/{field_1}',
'properties' => [
[
'id' => 'field_1',
'type' => 'text',
'generates_uuid' => true,
'name' => 'UUID Field'
]
]
]);
$processor = new FormSubmissionProcessor();
expect($processor->shouldProcessSynchronously($form))->toBeTrue();
});
it('processes synchronously with auto increment field in redirect URL', function () {
$user = $this->actingAsUser();
$workspace = $this->createUserWorkspace($user);
$form = $this->createForm($user, $workspace, [
'redirect_url' => 'https://example.com/{field_1}',
'properties' => [
[
'id' => 'field_1',
'type' => 'text',
'generates_auto_increment_id' => true,
'name' => 'Auto Increment Field'
]
]
]);
$processor = new FormSubmissionProcessor();
expect($processor->shouldProcessSynchronously($form))->toBeTrue();
});
it('processes asynchronously with no generated fields in redirect URL', function () {
$user = $this->actingAsUser();
$workspace = $this->createUserWorkspace($user);
$form = $this->createForm($user, $workspace, [
'redirect_url' => 'https://example.com/{field_1}',
'properties' => [
[
'id' => 'field_1',
'type' => 'text',
'name' => 'Regular Field'
]
]
]);
$processor = new FormSubmissionProcessor();
expect($processor->shouldProcessSynchronously($form))->toBeFalse();
});
it('processes asynchronously when generated field is not used in redirect URL', function () {
$user = $this->actingAsUser();
$workspace = $this->createUserWorkspace($user);
$form = $this->createForm($user, $workspace, [
'redirect_url' => 'https://example.com/{field_2}',
'properties' => [
[
'id' => 'field_1',
'type' => 'text',
'generates_uuid' => true,
'name' => 'UUID Field'
],
[
'id' => 'field_2',
'type' => 'text',
'name' => 'Regular Field'
]
]
]);
$processor = new FormSubmissionProcessor();
expect($processor->shouldProcessSynchronously($form))->toBeFalse();
});
it('processes asynchronously with no redirect URL', function () {
$user = $this->actingAsUser();
$workspace = $this->createUserWorkspace($user);
$form = $this->createForm($user, $workspace, [
'redirect_url' => null,
'properties' => [
[
'id' => 'field_1',
'type' => 'text',
'generates_uuid' => true,
'name' => 'UUID Field'
]
]
]);
$processor = new FormSubmissionProcessor();
expect($processor->shouldProcessSynchronously($form))->toBeFalse();
});
it('formats redirect data correctly for pro users', function () {
$user = $this->actingAsProUser();
$workspace = $this->createUserWorkspace($user);
$form = $this->createForm($user, $workspace, [
'redirect_url' => 'https://example.com/<span mention mention-field-id="field_1"></span>'
]);
$processor = new FormSubmissionProcessor();
$redirectData = $processor->getRedirectData($form, [
'field_1' => [
'id' => 'field_1',
'value' => 'test-value'
]
]);
expect($redirectData)->toBe([
'redirect' => true,
'redirect_url' => 'https://example.com/test-value'
]);
});
it('returns no redirect for non-pro users', function () {
$user = $this->actingAsUser();
$workspace = $this->createUserWorkspace($user);
$form = $this->createForm($user, $workspace, [
'redirect_url' => 'https://example.com/<span mention mention-field-id="field_1"></span>'
]);
$processor = new FormSubmissionProcessor();
$redirectData = $processor->getRedirectData($form, [
'field_1' => [
'id' => 'field_1',
'value' => 'test-value'
]
]);
expect($redirectData)->toBe([
'redirect' => false
]);
});