Enhance redirect URL handling and MentionParser functionality (#639)

- Updated the `redirect_url` validation in `UserFormRequest` to accept strings instead of just max length.
- Modified `MentionParser` to include a `urlFriendlyOutput` method, allowing for URL encoding of special characters in parsed values.
- Adjusted the `PublicFormController` to utilize the new `urlFriendlyOutput` method for redirect URLs.
- Created a migration to change the `redirect_url` field type in the database from string to text, accommodating longer URLs.
- Added tests to ensure proper handling of long redirect URLs and the functionality of the new URL-friendly output feature in `MentionParser`.

This update improves the flexibility and robustness of form handling and URL processing.
This commit is contained in:
Chirag Chhatrala
2024-12-10 16:56:01 +05:30
committed by GitHub
parent d09b5c45a5
commit ea4cd85eae
6 changed files with 115 additions and 4 deletions

View File

@@ -9,6 +9,7 @@ class MentionParser
{
private $content;
private $data;
private $urlFriendly = false;
public function __construct($content, $data)
{
@@ -16,6 +17,12 @@ class MentionParser
$this->data = $data;
}
public function urlFriendlyOutput(bool $enable = true): self
{
$this->urlFriendly = $enable;
return $this;
}
public function parse()
{
$doc = new DOMDocument();
@@ -40,7 +47,7 @@ class MentionParser
$value = $this->getData($fieldId);
if ($value !== null) {
$textNode = $doc->createTextNode(is_array($value) ? implode(', ', $value) : $value);
$textNode = $doc->createTextNode(is_array($value) ? implode($this->urlFriendly ? ',+' : ', ', $value) : $value);
$element->parentNode->replaceChild($textNode, $element);
} elseif ($fallback) {
$textNode = $doc->createTextNode($fallback);
@@ -127,7 +134,13 @@ class MentionParser
$value = collect($this->data)->firstWhere('id', $fieldId)['value'] ?? null;
if (is_object($value)) {
return (array) $value;
$value = (array) $value;
}
if ($this->urlFriendly && $value !== null) {
return is_array($value)
? array_map('urlencode', $value)
: urlencode($value);
}
return $value;