matt/opnform-host-nginx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix issue with form analytics for submissions (#362)

Browse Source 
* Password not working when Notion embed - Fixed (#360)

* fix tests

---------

Co-authored-by: formsdev <136701234+formsdev@users.noreply.github.com>
This commit is contained in:
Julien Nahum
2024-03-25 11:30:00 +01:00
committed by GitHub
parent 659dc5086e
commit e517cba88a
4 changed files with 7 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/Feature/Forms/CleanDatabaseTest.php
View File

@@ -42,7 +42,7 @@ it('check form statistic for views & submissions counts', function () {
expect($form->submissions()->count())->toBe(16);
expect(count($statistics))->toBe(2); // 1 per day for 2 different dates
expect($statistics[0]['date'])->toBe(now()->subDays(2)->toDateString());
expect($statistics[0]['data'])->toBe(['views' => 1, 'submissions' => 1]);
expect($statistics[0]['data'])->toBe(['views' => 1, 'submissions' => 0]);
expect($statistics[1]['date'])->toBe(now()->subDay()->toDateString());
expect($statistics[1]['data'])->toBe(['views' => 10, 'submissions' => 10]);
expect($statistics[1]['data'])->toBe(['views' => 10, 'submissions' => 0]);
});

6
tests/Feature/Forms/FormStatTest.php
View File

@@ -46,7 +46,7 @@ it('check formstat chart data', function () {
->whereType('submissions', 'array')
->where('views', function ($values) use ($views) {
foreach ($values as $date => $count) {
if ((isset($views[$date]) && $views[$date] != $count) || (! isset($views[$date]) && $count != 0)) {
if ((isset($views[$date]) && $views[$date] != $count) || (!isset($views[$date]) && $count != 0)) {
return false;
}
}
@@ -54,8 +54,9 @@ it('check formstat chart data', function () {
return true;
})
->where('submissions', function ($values) use ($submissions) {
ray($values, $submissions);
foreach ($values as $date => $count) {
if ((isset($submissions[$date]) && $submissions[$date] != $count) || (! isset($submissions[$date]) && $count != 0)) {
if ((isset($submissions[$date]) && $submissions[$date] != $count) || (!isset($submissions[$date]) && $count != 0)) {
return false;
}
}
@@ -64,5 +65,4 @@ it('check formstat chart data', function () {
})
->etc();
});
});