Decouple title from title block (#696)
* Decouple title from title block * fix lint * remove dry run for FormTitleMigration * Skip form title migration for forms with hidden titles * Refactor AI Form Generation with Dedicated Prompt Services - Extract AI form generation logic from GenerateTemplate command into dedicated prompt service classes - Update GenerateAiForm job to use new prompt generation services - Improve GptCompleter with more robust error handling and token tracking - Add error field to AiFormCompletion model for better error logging - Simplify command signature from 'ai:make-form-template' to 'form:generate' * Consolidate Template Metadata Generation with Unified Prompt Service - Create GenerateTemplateMetadataPrompt to centralize template metadata generation - Update GenerateTemplate command to use new consolidated metadata generation approach - Enhance GptCompleter to support strict JSON schema validation - Increase form prompt max length to support more complex form descriptions - Refactor form generation to simplify metadata extraction and processing * Implement Form Mode Strategy for Flexible Form Rendering - Introduce FormModeStrategy to centralize form rendering logic - Add support for different form modes: LIVE, PREVIEW, TEST, EDIT, PREFILL - Refactor components to use mode-based rendering strategy - Remove legacy boolean props like adminPreview and creating - Enhance form component flexibility and reusability * Refine Form Mode Strategy Display Behavior - Update FormModeStrategy to hide hidden fields in PREVIEW mode - Add FormMode getter in UrlFormPrefill component for mode-specific rendering - Clarify mode-specific validation and display logic in form strategies * Enhance Form Template Generation with Advanced Field Options - Update GenerateTemplate command to use front_url for template URL output - Expand GenerateFormPrompt with comprehensive field configuration options - Add support for advanced field types: date with time, toggle switches, radio/checkbox selections - Introduce field width configuration and HTML formatting for text elements - Re-enable select, multi-select, and matrix field type definitions with enhanced configurations * Remove Deprecated Template Metadata Generation Services - Delete multiple AI prompt services related to template metadata generation - Simplify GenerateTemplate command to use default values instead of complex metadata generation - Remove GenerateTemplateMetadataPrompt and related classes like GenerateTemplateDescriptionPrompt, GenerateTemplateImageKeywordsPrompt, etc. - Update form template generation to use basic fallback metadata generation approach * Restore GenerateTemplateMetadataPrompt for Comprehensive Template Generation - Reintroduce GenerateTemplateMetadataPrompt to replace default metadata generation - Update GenerateTemplate command to use consolidated metadata generation approach - Extract detailed metadata components including title, description, industries, and image search query - Improve template generation with more dynamic and AI-generated metadata * Refactor Template Preview Section Layout - Remove unnecessary nested div in template preview section - Simplify HTML structure for the template preview component - Maintain existing styling and functionality while improving code readability * Refactor Constructor and Code Formatting in AI Form Generation and Prompt Classes - Updated the constructor in GenerateAiForm.php to use a block structure for improved readability and consistency. - Added a blank line in the Prompt.php file to enhance code formatting and maintain consistency with PHP coding standards. - Modified the migration file to use a more concise class declaration syntax, improving clarity. These changes aim to enhance code readability and maintainability across the affected files. --------- Co-authored-by: Julien Nahum <julien@nahum.net>
This commit is contained in:
Chirag Chhatrala
GitHub
92
client/lib/forms/FormModeStrategy.js
vendored
Normal file
92
client/lib/forms/FormModeStrategy.js
vendored
Normal file
@@ -0,0 +1,92 @@
|
||||
/**
|
||||
* Form modes for OpenForm components
|
||||
*/
|
||||
export const FormMode = {
|
||||
LIVE: 'live', // Real form with full validation and submission
|
||||
PREVIEW: 'preview', // Admin preview with no validation
|
||||
PREFILL: 'prefill', // URL prefill preview with no validation
|
||||
EDIT: 'edit', // Editing an existing submission
|
||||
TEST: 'test' // Test mode with validation but no actual submission
|
||||
}
|
||||
|
||||
/**
|
||||
* Creates a comprehensive strategy based on the form mode
|
||||
* This handles all mode-specific behaviors, not just validation
|
||||
*
|
||||
* @param {string} mode - One of the FormMode values
|
||||
* @returns {Object} - Strategy object with all mode-specific behaviors
|
||||
*/
|
||||
export function createFormModeStrategy(mode) {
|
||||
// Default configuration (LIVE mode)
|
||||
const defaultStrategy = {
|
||||
// Validation behaviors
|
||||
validation: {
|
||||
validateOnNextPage: true,
|
||||
validateOnSubmit: true,
|
||||
performActualSubmission: true
|
||||
},
|
||||
|
||||
// Display behaviors
|
||||
display: {
|
||||
showHiddenFields: false,
|
||||
showFormCleanings: true,
|
||||
showFontLink: false
|
||||
},
|
||||
|
||||
// Admin behaviors
|
||||
admin: {
|
||||
allowDragging: false,
|
||||
showAdminControls: false,
|
||||
isEditingMode: false
|
||||
}
|
||||
}
|
||||
|
||||
// Return default strategy for LIVE mode or unknown modes
|
||||
if (mode === FormMode.LIVE || !Object.values(FormMode).includes(mode)) {
|
||||
return defaultStrategy
|
||||
}
|
||||
|
||||
// Create a copy of the default strategy to modify
|
||||
const strategy = JSON.parse(JSON.stringify(defaultStrategy))
|
||||
|
||||
// Apply mode-specific overrides
|
||||
switch (mode) {
|
||||
case FormMode.PREVIEW:
|
||||
// Admin preview - no validation, show admin controls but NOT hidden fields
|
||||
strategy.validation.validateOnNextPage = false
|
||||
strategy.validation.validateOnSubmit = false
|
||||
strategy.validation.performActualSubmission = false
|
||||
|
||||
strategy.display.showHiddenFields = false
|
||||
strategy.display.showFormCleanings = false
|
||||
strategy.display.showFontLink = true
|
||||
|
||||
strategy.admin.allowDragging = true
|
||||
strategy.admin.showAdminControls = true
|
||||
break
|
||||
|
||||
case FormMode.PREFILL:
|
||||
// URL prefill - no validation, show hidden fields
|
||||
strategy.validation.validateOnNextPage = false
|
||||
strategy.validation.validateOnSubmit = false
|
||||
strategy.validation.performActualSubmission = false
|
||||
|
||||
strategy.display.showHiddenFields = true
|
||||
break
|
||||
|
||||
case FormMode.EDIT:
|
||||
// Editing submission - same validation as LIVE mode, but show hidden fields
|
||||
// This ensures edit mode behaves like live mode for validation
|
||||
strategy.display.showHiddenFields = true
|
||||
strategy.admin.isEditingMode = true
|
||||
break
|
||||
|
||||
case FormMode.TEST:
|
||||
// Test mode - validate on submit but don't submit, and don't validate on next page
|
||||
strategy.validation.performActualSubmission = false
|
||||
strategy.validation.validateOnNextPage = false
|
||||
break
|
||||
}
|
||||
|
||||
return strategy
|
||||
}
|
||||
Reference in New Issue
Block a user