Conditioned field validation (#418)

* wip: validation condition input

* form custom validation condition

* Default message on form condition validation

* field validation condition test

* fix linting

* update tests,  add pass test

* Polish UI

---------

Co-authored-by: Julien Nahum <julien@nahum.net>
This commit is contained in:
Favour Olayinka
2024-05-29 10:40:14 +01:00
committed by GitHub
parent f9dacd0a74
commit 6673dff504
5 changed files with 236 additions and 5 deletions

View File

@@ -3,6 +3,7 @@
namespace App\Http\Requests;
use App\Models\Forms\Form;
use App\Rules\CustomFieldValidationRule;
use App\Rules\StorageFile;
use App\Rules\ValidHCaptcha;
use App\Rules\ValidPhoneInputRule;
@@ -50,18 +51,17 @@ class AnswerFormRequest extends FormRequest
*/
public function rules()
{
$selectionFields = collect($this->form->properties)->filter(function ($pro) {
return in_array($pro['type'], ['select', 'multi_select']);
});
foreach ($this->form->properties as $property) {
$rules = [];
/*if (!$this->form->is_pro) { // If not pro then not check logic
$property['logic'] = false;
}*/
// For get values instead of Id for select/multi select options
$data = $this->toArray();
$selectionFields = collect($this->form->properties)->filter(function ($pro) {
return in_array($pro['type'], ['select', 'multi_select']);
});
foreach ($selectionFields as $field) {
if (isset($data[$field['id']]) && is_array($data[$field['id']])) {
$data[$field['id']] = array_map(function ($val) use ($field) {
@@ -87,6 +87,11 @@ class AnswerFormRequest extends FormRequest
$rules[] = 'nullable';
}
// User custom validation
if(!(Str::of($property['type'])->startsWith('nf-')) && isset($property['validation'])) {
$rules[] = (new CustomFieldValidationRule($property['validation'], $data));
}
// Clean id to escape "."
$propertyId = $property['id'];
if (in_array($property['type'], ['multi_select'])) {

View File

@@ -0,0 +1,40 @@
<?php
namespace App\Rules;
use App\Service\Forms\FormLogicConditionChecker;
use Illuminate\Contracts\Validation\Rule;
class CustomFieldValidationRule implements Rule
{
/**
* Create a new rule instance.
*
* @return void
*/
public function __construct(public array $validation, public array $formData)
{
}
/**
* Determine if the validation rule passes.
*
* @param string $attribute
* @param mixed $value
* @return bool
*/
public function passes($attribute, $value)
{
return FormLogicConditionChecker::conditionsMet($this->validation['error_conditions']['conditions'], $this->formData);
}
/**
* Get the validation error message.
*
* @return string
*/
public function message()
{
return isset($this->validation['error_message']) ? $this->validation['error_message'] : 'Invalid input';
}
}