matt
/
opnform-host-nginx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix redirect URL mentions (#707)

This commit is contained in:
Chirag Chhatrala 2025-02-24 13:41:30 +05:30 committed by GitHub
parent d1902112dd
commit 65eebb7277
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api/app/Service/Forms/FormSubmissionProcessor.php
View File

@ -57,8 +57,12 @@ class FormSubmissionProcessor
*/ */
public function getRedirectData(Form $form, array $submissionData): array public function getRedirectData(Form $form, array $submissionData): array
{ {
$formattedData = collect($submissionData)->map(function ($value, $key) {
return ['id' => $key, 'value' => $value];
})->values()->all();
$redirectUrl = ($form->redirect_url) $redirectUrl = ($form->redirect_url)
? (new MentionParser($form->redirect_url, array_values($submissionData)))->urlFriendlyOutput()->parseAsText() ? (new MentionParser($form->redirect_url, $formattedData))->urlFriendlyOutput()->parseAsText()
: null; : null;
if ($redirectUrl && !filter_var($redirectUrl, FILTER_VALIDATE_URL)) { if ($redirectUrl && !filter_var($redirectUrl, FILTER_VALIDATE_URL)) {

10
api/tests/Feature/Forms/FormSubmissionProcessorTest.php
View File

@ -121,10 +121,7 @@ it('formats redirect data correctly for pro users', function () {
$processor = new FormSubmissionProcessor(); $processor = new FormSubmissionProcessor();
$redirectData = $processor->getRedirectData($form, [ $redirectData = $processor->getRedirectData($form, [
'field_1' => [ 'field_1' => 'test-value'
'id' => 'field_1',
'value' => 'test-value'
]
]); ]);
expect($redirectData)->toBe([ expect($redirectData)->toBe([
@ -142,10 +139,7 @@ it('returns no redirect for non-pro users', function () {
$processor = new FormSubmissionProcessor(); $processor = new FormSubmissionProcessor();
$redirectData = $processor->getRedirectData($form, [ $redirectData = $processor->getRedirectData($form, [
'field_1' => [ 'field_1' => 'test-value'
'id' => 'field_1',
'value' => 'test-value'
]
]); ]);
expect($redirectData)->toBe([ expect($redirectData)->toBe([