on fetch submission data display error if there (#608)

Co-authored-by: Julien Nahum <julien@nahum.net>
2024-11-13 14:18:28 +05:30
parent ef12c82fe5
commit 2c8f7d5d54
2 changed files with 11 additions and 1 deletions
--- a/api/app/Http/Controllers/Forms/PublicFormController.php
+++ b/api/app/Http/Controllers/Forms/PublicFormController.php
@@ -141,7 +141,14 @@ class PublicFormController extends Controller
            ]);
        }

-        $submission = new FormSubmissionResource(FormSubmission::findOrFail($submissionId));
+        $submission = FormSubmission::find($submissionId);
+        if (!$submission) {
+            return $this->error([
+                'message' => 'Submission not found.',
+            ]);
+        }
+
+        $submission = new FormSubmissionResource($submission);
        $submission->publiclyAccessed();

        if ($submission->form_id != $form->id) {