Update github action go version

Bump golang from 1.16.6-buster to 1.16.7-buster

.github/dependabot.yml

@@ -0,0 +1,18 @@
+version: 2
+updates:
+- package-ecosystem: github-actions
+  directory: /
+  schedule:
+    interval: weekly
+- package-ecosystem: gomod
+  directory: /
+  schedule:
+    interval: weekly
+- package-ecosystem: docker
+  directory: /
+  schedule:
+    interval: weekly
+- package-ecosystem: npm
+  directory: /mermaidcli
+  schedule:
+    interval: weekly

.github/workflows/build.yaml

@@ -7,14 +7,14 @@ jobs:
   build:
     strategy:
       matrix:
-        go-version: [1.15.x]
+        go-version: [1.16.x]
         platform: [ubuntu-latest]
     runs-on: ${{ matrix.platform }}
     steps:
       - name: Checkout code
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2.3.4
       - name: Set env
-        run: echo ::set-env name=RELEASE_VERSION::${GITHUB_REF:10}
+        run: echo RELEASE_VERSION=${GITHUB_REF:10} >> $GITHUB_ENV
       - name: Build
         run: docker build -t tomwright/mermaid-server:latest -t tomwright/mermaid-server:${{ env.RELEASE_VERSION }} -f Dockerfile .
       - name: Login

.github/workflows/test.yaml

@@ -4,17 +4,17 @@ jobs:
   test:
     strategy:
       matrix:
-        go-version: [1.15.x]
+        go-version: [1.16.x]
         platform: [ubuntu-latest]
     runs-on: ${{ matrix.platform }}
     steps:
       - name: Install Go
-        uses: actions/setup-go@v1
+        uses: actions/setup-go@v2.1.3
         with:
           go-version: ${{ matrix.go-version }}
       - name: Checkout code
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2.3.4
-      - uses: actions/cache@v1
+      - uses: actions/cache@v2.1.6
         with:
           path: ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}

Dockerfile

@@ -1,5 +1,5 @@
 # This stage builds the go executable.
-FROM golang:1.15-buster as go
+FROM golang:1.16.7-buster as go
 
 WORKDIR /root
 COPY ./ ./
@@ -10,7 +10,7 @@ RUN go build -o bin/app cmd/app/main.go
 # Final stage that will be pushed.
 FROM debian:buster-slim
 
-FROM node:12.12.0-buster-slim as node
+FROM node:16.6.2-buster-slim as node
 
 WORKDIR /root
 
@@ -64,6 +64,7 @@ RUN apt-get update 2>/dev/null && \
         lsb-release \
         xdg-utils \
         wget \
+        libxshmfence1 \
 		2>/dev/null
 
 COPY --from=go /root/bin/app ./app

cmd/app/main.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"flag"
 	"fmt"
-	"github.com/tomwright/lifetime"
+	"github.com/tomwright/grace"
 	"github.com/tomwright/mermaid-server/internal"
 	"os"
 )
@@ -31,19 +31,16 @@ func main() {
 		os.Exit(1)
 	}
 
+	g := grace.Init(context.Background())
+
 	cache := internal.NewDiagramCache()
 	generator := internal.NewGenerator(cache, *mermaid, *in, *out, *puppeteer)
 
-	httpService := internal.NewHTTPService(generator)
+	httpRunner := internal.NewHTTPRunner(generator)
-	cleanupService := internal.NewCleanupService(generator)
+	cleanupRunner := internal.NewCleanupRunner(generator)
 
-	lt := lifetime.New(context.Background()).Init()
+	g.Run(httpRunner)
+	g.Run(cleanupRunner)
 
-	// Start the http service.
+	g.Wait()
-	lt.Start(httpService)
-	// Start the cleanup service.
-	lt.Start(cleanupService)
-
-	// Wait for all routines to stop running.
-	lt.Wait()
 }

go.mod

@@ -2,4 +2,7 @@ module github.com/tomwright/mermaid-server
 
 go 1.15
 
-require github.com/tomwright/lifetime v1.0.0
+require (
+	github.com/tomwright/grace v0.1.2
+	github.com/tomwright/gracehttpserverrunner v0.1.0
+)

go.sum

@@ -1,2 +1,4 @@
-github.com/tomwright/lifetime v1.0.0 h1:Yzj+Td38eUUdZ1ewvOegywFBmKyaCh+8HjKBmeXw6OM=
+github.com/tomwright/grace v0.1.2 h1:8kH+S2GLqnwgWqUzi9CcjNoWJANZQnw9Xw65NPUr6WA=
-github.com/tomwright/lifetime v1.0.0/go.mod h1:GUCHgRaR/zStvtJiOd3B4gIZayeiz3TgApC9kNYAOQI=
+github.com/tomwright/grace v0.1.2/go.mod h1:RKqz4gB3sQJpyas/CuiiriQQfUxSXhtWRfYtE7MG+Ok=
+github.com/tomwright/gracehttpserverrunner v0.1.0 h1:n4iafOnJQEmRn05i1QzU+FPS0CU4ybxilyEdBEH/Ulk=
+github.com/tomwright/gracehttpserverrunner v0.1.0/go.mod h1:FFHjVUgXu7KygMn+QlaoCesVlPOhaCnCvw35nvgzt5I=

internal/cleanup.go

@@ -0,0 +1,46 @@
+package internal
+
+import (
+	"context"
+	"github.com/tomwright/grace"
+	"log"
+	"time"
+)
+
+// NewCleanupRunner returns a runner that can be used cleanup old diagrams.
+func NewCleanupRunner(generator Generator) grace.Runner {
+	return &cleanupService{
+		generator:   generator,
+		runEvery:    time.Minute * 5,
+		cleanupLast: time.Hour,
+	}
+}
+
+// cleanupService is a runner that is used cleanup old diagrams.
+type cleanupService struct {
+	generator   Generator
+	runEvery    time.Duration
+	cleanupLast time.Duration
+}
+
+// Run starts the cleanup process.
+func (s *cleanupService) Run(ctx context.Context) error {
+	for {
+		select {
+		case <-ctx.Done():
+			return nil
+		default:
+		}
+
+		if err := s.generator.CleanUp(s.cleanupLast); err != nil {
+			log.Printf("error when cleaning up: %s", err.Error())
+		}
+
+		select {
+		case <-time.After(s.runEvery):
+			continue
+		case <-ctx.Done():
+			return nil
+		}
+	}
+}

internal/cleanup_service.go

@@ -1,41 +0,0 @@
-package internal
-
-import (
-	"log"
-	"time"
-)
-
-// NewCleanupService returns a service that can be used cleanup old diagrams.
-func NewCleanupService(generator Generator) *cleanupService {
-	return &cleanupService{
-		generator: generator,
-		stopCh:    make(chan struct{}),
-	}
-}
-
-// cleanupService is a service that can be used cleanup old diagrams.
-type cleanupService struct {
-	generator Generator
-	stopCh    chan struct{}
-}
-
-// Start starts the cleanup service.
-func (s *cleanupService) Start() error {
-	for {
-		if err := s.generator.CleanUp(time.Hour); err != nil {
-			log.Printf("error when cleaning up: %s", err.Error())
-		}
-
-		select {
-		case <-time.After(time.Minute * 5):
-			continue
-		case <-s.stopCh:
-			return nil
-		}
-	}
-}
-
-// Stop stops the cleanup service.
-func (s *cleanupService) Stop() {
-	close(s.stopCh)
-}

internal/http.go

@@ -3,13 +3,32 @@ package internal
 import (
 	"encoding/json"
 	"fmt"
+	"github.com/tomwright/grace"
+	"github.com/tomwright/gracehttpserverrunner"
 	"io/ioutil"
 	"log"
 	"net/http"
 	"net/url"
 	"strings"
+	"time"
 )
 
+// NewHTTPRunner returns a grace runner that runs a HTTP server.
+func NewHTTPRunner(generator Generator) grace.Runner {
+	httpHandler := generateHTTPHandler(generator)
+
+	r := http.NewServeMux()
+	r.Handle("/generate", http.HandlerFunc(httpHandler))
+
+	return &gracehttpserverrunner.HTTPServerRunner{
+		Server: &http.Server{
+			Addr:    ":80",
+			Handler: r,
+		},
+		ShutdownTimeout: time.Second * 5,
+	}
+}
+
 func writeJSON(rw http.ResponseWriter, value interface{}, status int) {
 	bytes, err := json.Marshal(value)
 	if err != nil {

internal/http_service.go

@@ -1,47 +0,0 @@
-package internal
-
-import (
-	"net/http"
-)
-
-// NewHTTPService returns a service that can be used to start a http server
-// that will generate diagrams.
-func NewHTTPService(generator Generator) *httpService {
-	return &httpService{
-		generator: generator,
-	}
-}
-
-// httpService is a service that can be used to start a http server
-// that will generate diagrams.
-type httpService struct {
-	httpServer *http.Server
-	generator  Generator
-}
-
-// Start starts the HTTP server.
-func (s *httpService) Start() error {
-	httpHandler := generateHTTPHandler(s.generator)
-
-	r := http.NewServeMux()
-	r.Handle("/generate", http.HandlerFunc(httpHandler))
-
-	s.httpServer = &http.Server{
-		Addr:    ":80",
-		Handler: r,
-	}
-
-	if err := s.httpServer.ListenAndServe(); err != nil && err != http.ErrServerClosed {
-		if err != http.ErrServerClosed {
-			return err
-		}
-	}
-
-	return nil
-}
-
-func (s *httpService) Stop() {
-	if s != nil {
-		_ = s.httpServer.Close()
-	}
-}

mermaidcli/package.json

@@ -9,6 +9,6 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
-    "@mermaid-js/mermaid-cli": "^8.6.4"
+    "@mermaid-js/mermaid-cli": "^8.11.4"
   }
 }