Two mechanical sweeps closing the audit's HIGH §16 + MED §11 findings: * 38 client components / 56 toast.error sites converted to toastError(err) so the new admin error inspector becomes usable from user-reported issues — every failed inline-edit, save, send, archive, upload, etc. now carries the request-id + error-code (Copy ID action). * 26 service files / 62 bare-Error throws converted to CodedError or the existing AppError subclasses. Adds new error codes: DOCUMENSO_UPSTREAM_ERROR (502), DOCUMENSO_AUTH_FAILURE (502), DOCUMENSO_TIMEOUT (504), OCR_UPSTREAM_ERROR (502), IMAP_UPSTREAM_ERROR (502), UMAMI_UPSTREAM_ERROR (502), UMAMI_NOT_CONFIGURED (409), and INSERT_RETURNING_EMPTY (500) for post-insert returning-empty guards. * Five vitest assertions updated to match the new user-facing wording (client-merge "already been merged", expense/interest "couldn't find that …", documenso "signing service didn't respond"). Test status: 1168/1168 vitest, tsc clean. Refs: docs/audit-comprehensive-2026-05-05.md HIGH §16 (auditor-H Issue 1) + MED §11 (auditor-G Issue 1). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
75 lines
2.5 KiB
TypeScript
75 lines
2.5 KiB
TypeScript
import { db } from '@/lib/db';
|
|
import { currencyRates } from '@/lib/db/schema/system';
|
|
import { eq, and } from 'drizzle-orm';
|
|
import { CodedError } from '@/lib/errors';
|
|
import { logger } from '@/lib/logger';
|
|
import { fetchWithTimeout } from '@/lib/fetch-with-timeout';
|
|
|
|
export async function getRate(from: string, to: string): Promise<number | null> {
|
|
if (from === to) return 1;
|
|
const rate = await db.query.currencyRates.findFirst({
|
|
where: and(eq(currencyRates.baseCurrency, from), eq(currencyRates.targetCurrency, to)),
|
|
});
|
|
return rate ? Number(rate.rate) : null;
|
|
}
|
|
|
|
export async function convert(
|
|
amount: number,
|
|
from: string,
|
|
to: string,
|
|
): Promise<{ result: number; rate: number } | null> {
|
|
const rate = await getRate(from, to);
|
|
if (!rate) return null;
|
|
return { result: Number((amount * rate).toFixed(2)), rate };
|
|
}
|
|
|
|
export async function refreshRates(): Promise<void> {
|
|
try {
|
|
const res = await fetchWithTimeout('https://api.frankfurter.dev/v1/latest?base=USD');
|
|
if (!res.ok)
|
|
throw new CodedError('INTERNAL', {
|
|
internalMessage: `Frankfurter API error: ${res.status}`,
|
|
});
|
|
const data = await res.json();
|
|
const rates = data.rates as Record<string, number>;
|
|
|
|
for (const [currency, rate] of Object.entries(rates)) {
|
|
await db
|
|
.insert(currencyRates)
|
|
.values({
|
|
baseCurrency: 'USD',
|
|
targetCurrency: currency,
|
|
rate: String(rate),
|
|
source: 'frankfurter',
|
|
fetchedAt: new Date(),
|
|
})
|
|
.onConflictDoUpdate({
|
|
target: [currencyRates.baseCurrency, currencyRates.targetCurrency],
|
|
set: { rate: String(rate), fetchedAt: new Date(), source: 'frankfurter' },
|
|
});
|
|
}
|
|
|
|
// Store inverse rates for common conversions
|
|
for (const [currency, rate] of Object.entries(rates)) {
|
|
const inverse = 1 / rate;
|
|
await db
|
|
.insert(currencyRates)
|
|
.values({
|
|
baseCurrency: currency,
|
|
targetCurrency: 'USD',
|
|
rate: String(inverse.toFixed(6)),
|
|
source: 'frankfurter',
|
|
fetchedAt: new Date(),
|
|
})
|
|
.onConflictDoUpdate({
|
|
target: [currencyRates.baseCurrency, currencyRates.targetCurrency],
|
|
set: { rate: String(inverse.toFixed(6)), fetchedAt: new Date(), source: 'frankfurter' },
|
|
});
|
|
}
|
|
|
|
logger.info({ rateCount: Object.keys(rates).length }, 'Currency rates refreshed');
|
|
} catch (err) {
|
|
logger.error({ err }, 'Failed to refresh currency rates');
|
|
}
|
|
}
|