Files
pn-new-crm/tests/integration/api/yachts.test.ts
Matt Ciaccio e8d61c91c4
All checks were successful
Build & Push Docker Images / lint (pull_request) Successful in 1m2s
Build & Push Docker Images / build-and-push (pull_request) Has been skipped
feat(platform): residential module + admin UI + reliability fixes
Residential platform
- New schema: residentialClients, residentialInterests (separate from
  marina/yacht clients) with migration 0010
- Service layer with CRUD + audit + sockets + per-port portal toggle
- v1 + public API routes (/api/v1/residential/*, /api/public/residential-inquiries)
- List + detail pages with inline editing for clients and interests
- Per-user residentialAccess toggle on userPortRoles (migration 0011)
- Permission keys: residential_clients, residential_interests
- Sidebar nav + role form integration
- Smoke spec covering page loads, UI create flow, public endpoint

Admin & shared UI
- Admin → Forms (form templates CRUD) with validators + service
- Notification preferences page (in-app + email per type)
- Email composition + accounts list + threads view
- Branded auth shell shared across CRM + portal auth surfaces
- Inline editing extended to yacht/company/interest detail pages
- InlineTagEditor + per-entity tags endpoints (yachts, companies)
- Notes service polymorphic across clients/interests/yachts/companies
- Client list columns: yachtCount + companyCount badges
- Reservation file-download via presigned URL (replaces stale <a href>)

Route handler refactor
- Extracted yachts/companies/berths reservation handlers to sibling
  handlers.ts files (Next.js 15 route.ts only allows specific exports)

Reliability fixes
- apiFetch double-stringify bug fixed across 13 components
  (apiFetch already JSON.stringifies its body; passing a stringified
  body produced double-encoded JSON which failed zod validation)
- SocketProvider gated behind useSyncExternalStore-based mount check
  to avoid useSession() SSR crashes under React 19 + Next 15
- apiFetch falls back to URL-pathname → port-id resolution when the
  Zustand store hasn't hydrated yet (fresh contexts, e2e tests)
- CRM invite flow (schema, service, route, email, dev script)
- Dashboard route → [portSlug]/dashboard/page.tsx + redirect
- Document the dev-server restart-after-migration gotcha in CLAUDE.md

Tests
- 5-case residential smoke spec
- Integration test updates for new service signatures

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-27 21:54:32 +02:00

100 lines
4.0 KiB
TypeScript

import { describe, it, expect } from 'vitest';
import { listHandler, createHandler } from '@/app/api/v1/yachts/handlers';
import { POST } from '@/app/api/v1/yachts/route';
import { withPermission } from '@/lib/api/helpers';
import { makeMockCtx, makeMockRequest } from '../../helpers/route-tester';
import {
makePort,
makeClient,
makeYacht,
makeFullPermissions,
makeViewerPermissions,
} from '../../helpers/factories';
describe('POST /api/v1/yachts (createHandler)', () => {
it('creates a yacht and returns 201', async () => {
const port = await makePort();
const client = await makeClient({ portId: port.id });
const ctx = makeMockCtx({ portId: port.id, permissions: makeFullPermissions() });
const req = makeMockRequest('POST', 'http://localhost/api/v1/yachts', {
body: { name: 'Sea Breeze', owner: { type: 'client', id: client.id } },
});
const res = await createHandler(req, ctx, {});
expect(res.status).toBe(201);
const body = await res.json();
expect(body.data.name).toBe('Sea Breeze');
expect(body.data.currentOwnerId).toBe(client.id);
});
it('returns 400 on invalid body (empty name)', async () => {
const port = await makePort();
const client = await makeClient({ portId: port.id });
const ctx = makeMockCtx({ portId: port.id, permissions: makeFullPermissions() });
const req = makeMockRequest('POST', 'http://localhost/api/v1/yachts', {
body: { name: '', owner: { type: 'client', id: client.id } },
});
const res = await createHandler(req, ctx, {});
expect(res.status).toBe(400);
});
it('returns 400 when owner.id does not exist', async () => {
const port = await makePort();
const ctx = makeMockCtx({ portId: port.id, permissions: makeFullPermissions() });
const req = makeMockRequest('POST', 'http://localhost/api/v1/yachts', {
body: { name: 'Phantom', owner: { type: 'client', id: 'nonexistent' } },
});
const res = await createHandler(req, ctx, {});
expect(res.status).toBe(400);
});
});
describe('GET /api/v1/yachts (listHandler)', () => {
it('returns tenant-scoped yachts with pagination metadata', async () => {
const port = await makePort();
const client = await makeClient({ portId: port.id });
await makeYacht({
portId: port.id,
ownerType: 'client',
ownerId: client.id,
name: 'Listed',
});
const ctx = makeMockCtx({ portId: port.id, permissions: makeFullPermissions() });
const req = makeMockRequest('GET', 'http://localhost/api/v1/yachts?page=1&limit=20&order=desc');
const res = await listHandler(req, ctx, {});
expect(res.status).toBe(200);
const body = await res.json();
expect(body.data.some((y: { name: string }) => y.name === 'Listed')).toBe(true);
expect(body.pagination.page).toBe(1);
expect(body.pagination.pageSize).toBe(20);
expect(typeof body.pagination.total).toBe('number');
});
it('returns 400 for invalid query params (non-numeric page)', async () => {
const port = await makePort();
const ctx = makeMockCtx({ portId: port.id, permissions: makeFullPermissions() });
const req = makeMockRequest(
'GET',
'http://localhost/api/v1/yachts?page=abc&limit=20&order=desc',
);
const res = await listHandler(req, ctx, {});
expect(res.status).toBe(400);
});
});
describe('POST /api/v1/yachts — permission gate', () => {
it('viewer (no yachts.create) receives 403 through full pipeline', async () => {
const port = await makePort();
const client = await makeClient({ portId: port.id });
const gated = withPermission('yachts', 'create', createHandler);
const ctx = makeMockCtx({ portId: port.id, permissions: makeViewerPermissions() });
const req = makeMockRequest('POST', 'http://localhost/api/v1/yachts', {
body: { name: 'X', owner: { type: 'client', id: client.id } },
});
const res = await gated(req, ctx, {});
expect(res.status).toBe(403);
// Sanity check that the withAuth-wrapped HTTP export exists.
expect(POST).toBeDefined();
});
});