Batch of small fixes from the post-audit plan:
F11 — "Mark as won" dialog copy
Was: "This will move the interest to Completed and stamp the outcome."
Completed was retired in the 7-stage refactor; copy now reads
"marks Won; stage stays where it is" with a parallel Lost variant.
F13 — Bulk-add berths wizard had no UI entry point
Page existed at /[portSlug]/admin/berths/bulk-add but nothing linked
to it. Added a "Bulk add" button on the Berths list toolbar, gated
on `berths.import`. Also fixed the API route's permission key
(was `berths.create`, a phantom — switched to `berths.import` to
match seed-permissions).
F14 — Audit Log nav entry
Sidebar Admin section now lists "Audit Log" → /admin/audit, gated
by the adminRequired group rule.
F18 — Recommender `limit` param ignored
POST /interests/[id]/recommend-berths now accepts `limit` as an
alias for `topN`. Audit sent `{limit:3}` and silently got 8 rows
back; both names now resolve.
Tests still green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
168 lines
6.4 KiB
TypeScript
168 lines
6.4 KiB
TypeScript
'use client';
|
|
|
|
import Link from 'next/link';
|
|
import { useRouter, useParams } from 'next/navigation';
|
|
import { Anchor, Plus } from 'lucide-react';
|
|
|
|
import { DataTable } from '@/components/shared/data-table';
|
|
import { FilterBar } from '@/components/shared/filter-bar';
|
|
import { PageHeader } from '@/components/shared/page-header';
|
|
import { SavedViewsDropdown } from '@/components/shared/saved-views-dropdown';
|
|
import { ColumnPicker } from '@/components/shared/column-picker';
|
|
import { Button } from '@/components/ui/button';
|
|
import { Input } from '@/components/ui/input';
|
|
import { EmptyState } from '@/components/shared/empty-state';
|
|
import { usePaginatedQuery } from '@/hooks/use-paginated-query';
|
|
import { usePermissions } from '@/hooks/use-permissions';
|
|
import { useRealtimeInvalidation } from '@/hooks/use-realtime-invalidation';
|
|
import { useTablePreferences } from '@/hooks/use-table-preferences';
|
|
import { BerthCard } from './berth-card';
|
|
import {
|
|
berthColumns,
|
|
BERTH_COLUMN_OPTIONS,
|
|
BERTH_DEFAULT_HIDDEN,
|
|
type BerthRow,
|
|
} from './berth-columns';
|
|
import { berthFilterDefinitions } from './berth-filters';
|
|
import { mooringLetterTone } from './mooring-letter-tone';
|
|
|
|
export function BerthList() {
|
|
const router = useRouter();
|
|
const params = useParams<{ portSlug: string }>();
|
|
// F13: bulk-add wizard had no UI entry point. Gate the CTA on
|
|
// `berths.import` (the existing permission used for adding berths)
|
|
// so non-admins don't see a button that 403s on click.
|
|
const { can } = usePermissions();
|
|
const canBulkAdd = can('berths', 'import');
|
|
|
|
const {
|
|
data,
|
|
pagination,
|
|
isLoading,
|
|
sort,
|
|
setSort,
|
|
filters,
|
|
setFilter,
|
|
setAllFilters,
|
|
clearFilters,
|
|
setPage,
|
|
setPageSize,
|
|
} = usePaginatedQuery<BerthRow>({
|
|
queryKey: ['berths'],
|
|
endpoint: '/api/v1/berths',
|
|
filterDefinitions: berthFilterDefinitions,
|
|
});
|
|
|
|
useRealtimeInvalidation({
|
|
'berth:updated': [['berths']],
|
|
'berth:statusChanged': [['berths']],
|
|
});
|
|
|
|
// Persisted column visibility — same pattern as ClientList / InterestList.
|
|
const { hidden, setHidden } = useTablePreferences('berths', BERTH_DEFAULT_HIDDEN);
|
|
const columnVisibility = Object.fromEntries(hidden.map((id) => [id, false]));
|
|
|
|
return (
|
|
<div className="space-y-6">
|
|
<PageHeader
|
|
title="Berths"
|
|
description="View and manage berth allocations"
|
|
variant="gradient"
|
|
// No "New" button - berths are import-only
|
|
/>
|
|
|
|
{/* Toolbar — two halves separated by `justify-between` so the
|
|
Columns + Saved-views actions stay pinned to the right edge of
|
|
the row at every width. The previous `ml-auto` trick didn't
|
|
survive flex-wrap on intermediate widths — the actions ended
|
|
up centered. */}
|
|
<div className="flex items-center gap-2 flex-wrap justify-between">
|
|
<div className="flex items-center gap-2 flex-wrap min-w-0 flex-1">
|
|
<FilterBar
|
|
// Search is hoisted out of the popover into the inline input
|
|
// below — keeps the daily "find by mooring/area" lookup one
|
|
// tap away instead of buried behind the Filters dropdown.
|
|
filters={berthFilterDefinitions.filter((d) => d.key !== 'search')}
|
|
values={filters}
|
|
onChange={setFilter}
|
|
onClear={clearFilters}
|
|
/>
|
|
<Input
|
|
type="search"
|
|
inputMode="search"
|
|
placeholder="Search mooring or area…"
|
|
aria-label="Search berths"
|
|
value={(filters.search as string | undefined) ?? ''}
|
|
onChange={(e) => setFilter('search', e.target.value || undefined)}
|
|
className="h-8 min-w-0 flex-1 sm:max-w-xs"
|
|
/>
|
|
</div>
|
|
<div className="flex items-center gap-2 ml-auto">
|
|
<SavedViewsDropdown
|
|
entityType="berths"
|
|
onApplyView={(savedFilters, _savedSort) => {
|
|
setAllFilters(savedFilters);
|
|
}}
|
|
/>
|
|
<ColumnPicker columns={BERTH_COLUMN_OPTIONS} hidden={hidden} onChange={setHidden} />
|
|
{canBulkAdd && (
|
|
<Button asChild size="sm" variant="default">
|
|
<Link href={`/${params.portSlug}/admin/berths/bulk-add`}>
|
|
<Plus className="h-4 w-4" />
|
|
<span className="hidden sm:inline">Bulk add</span>
|
|
</Link>
|
|
</Button>
|
|
)}
|
|
</div>
|
|
</div>
|
|
|
|
<DataTable<BerthRow>
|
|
columns={berthColumns}
|
|
columnVisibility={columnVisibility}
|
|
data={data}
|
|
isLoading={isLoading}
|
|
pagination={{
|
|
page: pagination.page,
|
|
pageSize: pagination.pageSize,
|
|
total: pagination.total,
|
|
totalPages: pagination.totalPages,
|
|
}}
|
|
onPaginationChange={(page, pageSize) => {
|
|
setPage(page);
|
|
setPageSize(pageSize);
|
|
}}
|
|
sort={sort}
|
|
onSortChange={setSort}
|
|
getRowId={(row) => row.id}
|
|
onRowClick={(row) => router.push(`/${params.portSlug}/berths/${row.id}`)}
|
|
getRowClassName={(row) => mooringLetterTone(row.mooringNumber)}
|
|
cardRender={(row) => <BerthCard berth={row.original} />}
|
|
// Group adjacent cards by dock letter (area) on mobile — adds a
|
|
// dim divider + uppercased label above the first card of each
|
|
// group. Data is already sorted by mooringNumber (A1, A2, …, B1,
|
|
// B2, …) so consecutive rows naturally share dock letters.
|
|
mobileGroupBy={(row) => row.area ?? 'Unassigned'}
|
|
emptyState={
|
|
// Distinguish "no data at all" (fresh port, run the importer)
|
|
// from "no rows after filtering" (adjust filters). The original
|
|
// copy implied data existed but was hidden, which misled fresh-
|
|
// port admins for whom there is literally nothing yet.
|
|
Object.values(filters).every((v) => v === undefined || v === '') ? (
|
|
<EmptyState
|
|
icon={Anchor}
|
|
title="No berths yet"
|
|
description="Berths are imported from external sources. Run the importer once the source data is ready: pnpm tsx scripts/import-berths-from-nocodb.ts --apply --port-slug <slug>."
|
|
/>
|
|
) : (
|
|
<EmptyState
|
|
icon={Anchor}
|
|
title="No berths match these filters"
|
|
description="Adjust your filters or clear them to see every berth."
|
|
/>
|
|
)
|
|
}
|
|
/>
|
|
</div>
|
|
);
|
|
}
|