Matt
b3f87563c6
Audit cleanup completion plan, all tiers shipped: Tier 1 (security + data integrity) - A.7 RTBF true wipe: redact email_messages body/subject/addresses for threads owned by deleted client; redact document_sends.recipient_email; collect file storage keys + delete blobs post-commit. - A.8 user_permission_overrides FK: documented inline why cascade is correct (not set-null as audit suggested) — overrides have no value without their user. - W2.14 PII redaction: camelCase normalization in audit.ts + error-events.service.ts isSensitiveKey; added city/postal/country/ birth fragments. firstName/lastName/dateOfBirth/postalCode etc. now caught in BOTH masker paths. 12 new test cases lock the coverage. Tier 2 (Documenso completion + refactor) - C.2: documentEvents.recipient_email column + partial unique index for per-recipient webhook dedup (migration 0075). handleDocumentSigned now sets recipient_email on insert. - Phase 2: completion_cc_emails distribution. handleDocumentCompleted reads documents.completionCcEmails, filters out signer-duplicates case-insensitively, fans signed PDF out to non-signer recipients. - C.4: extracted createPublicInterest() service from the 346-line api/public/interests route. Route becomes a thin shell (rate-limit, port resolution, audit log, email fan-out). The trio creation logic is now unit-testable without an HTTP fixture. - Phase 4: POST /api/v1/document-templates/[id]/detect-fields wired to document-field-detector.detectFields(). Sparkles "Auto-detect" button added to template-editor.tsx — maps DetectedField → marker with best-guess merge token (DATE / NAME / EMAIL); user retags. Tier 3 (reporting + recommender snapshot lockfiles) - W7.reports: extracted rollupStageRevenue / rollupStageCounts / computeTotalForecast / computeOccupancyRate / rollupBerthStatusCounts into src/lib/services/report-math.ts (pure functions). 16 new tests including an inline-snapshot lockfile on a representative 7-stage forecast. report-generators.ts now delegates. - W7.recommender: 18 new toMatchSnapshot tripwires on classifyTier boundaries + computeHeat at canonical input points. Tier 4 (rolling) - W6.attach: fixed outdated CLAUDE.md claim — threshold banner is informational and never depended on IMAP; bounce monitoring (the IMAP poller) is separate. - D.1 + D.2: documented deferral inline with full why-not-build-it reasoning so a future engineer sees the rationale. - G.1: representative formatDate sweep (audit-log-list, user-list, document-templates merge tokens, document-signing email). Rest of the ~100 sites stay rolling. Quality gates: 1420/1420 vitest (46 new tests above baseline of 1374), tsc clean, 0 lint errors. Plan: docs/superpowers/plans/2026-05-18-audit-cleanup-completion.md Migration: 0075_c2_document_events_recipient_email.sql (applied to dev DB). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
52 lines
2.1 KiB
TypeScript
52 lines
2.1 KiB
TypeScript
import { Worker, type Job } from 'bullmq';
|
|
import { env } from '@/lib/env';
|
|
|
|
import type { ConnectionOptions } from 'bullmq';
|
|
import { logger } from '@/lib/logger';
|
|
import { attachWorkerAudit } from '@/lib/queue/audit-helpers';
|
|
import { QUEUE_CONFIGS } from '@/lib/queue';
|
|
|
|
/**
|
|
* Bulk-import worker — DEFERRED FEATURE (placeholder).
|
|
*
|
|
* Status: registered with BullMQ so any future enqueue site lands on a
|
|
* real worker instance instead of disappearing into an unbound queue.
|
|
* No callers currently dispatch to this worker — the body is intentionally
|
|
* a no-op that logs the dispatch for forensics.
|
|
*
|
|
* Why deferred (vs implemented inline):
|
|
* - CSV/Excel import is a real product feature, not a refactor. Done
|
|
* properly it needs: per-entity schema mapping (clients / berths /
|
|
* interests / companies / yachts), zod-level row validation, per-row
|
|
* error rollup with line-numbered diagnostics, dry-run preview,
|
|
* progress reporting, dedupe-on-conflict policy, admin upload UI
|
|
* with column-mapping UX. Building it speculatively without a
|
|
* customer in the room would lock in a UX that may not match what
|
|
* real importers want.
|
|
* - When the trigger comes (a customer needs to bulk-load a season
|
|
* roster or migrate from another CRM), build it from product spec
|
|
* not from this placeholder.
|
|
*
|
|
* What's required to ship: papaparse (CSV) + a thin schema-per-entity
|
|
* mapping layer, plus an admin /admin/import page with a per-entity
|
|
* picker + file dropzone. The queue registration here stays as-is.
|
|
*/
|
|
export const importWorker = new Worker(
|
|
'import',
|
|
async (job: Job) => {
|
|
logger.info({ jobId: job.id, jobName: job.name }, 'Processing import job');
|
|
// Deferred — no callers enqueue this. If a job lands, we log + swallow
|
|
// so a future test enqueue doesn't trip the failed-job alert.
|
|
},
|
|
{
|
|
connection: { url: env.REDIS_URL } as ConnectionOptions,
|
|
concurrency: QUEUE_CONFIGS.import.concurrency,
|
|
},
|
|
);
|
|
|
|
importWorker.on('failed', (job, err) => {
|
|
logger.error({ jobId: job?.id, jobName: job?.name, err }, 'Import job failed');
|
|
});
|
|
|
|
attachWorkerAudit(importWorker, 'import');
|