16d98d630e
Cross-cutting i18n polish for forms across the marina + residential + company
domains. Introduces a single source of truth for country/phone/timezone/
subdivision data and replaces every nationality-as-free-text and timezone-
as-string Input with a dedicated combobox.
PR1 Countries — ALL_COUNTRY_CODES (~250 ISO-3166-1 alpha-2), Intl.DisplayNames
for localized labels, detectDefaultCountry() with navigator-region
fallback to US, CountryCombobox with regional-indicator flag glyphs +
compact mode for inline use.
PR2 Phone — libphonenumber-js wrapper (parsePhone / formatAsYouType /
callingCodeFor), PhoneInput with flag dropdown + national-format
AsYouType + paste-detect that flips the country dropdown for pasted
international strings.
PR3 Timezones — country->IANA map (250 entries, multi-zone for AU/BR/CA/CD/
ID/KZ/MN/MX/RU/US), formatTimezoneLabel ("Europe/London (UTC+1)"),
TimezoneCombobox with Suggested/All grouping driven by countryHint.
PR4 Subdivisions — wraps the iso-3166-2 npm package (~5000 ISO 3166-2
codes for every country), per-country cache, SubdivisionCombobox with
"Pick a country first" / "No regions available" empty states.
PR5 Schema deltas (migration 0015) — clients.nationality_iso, clientContacts
{value_e164, value_country}, clientAddresses {country_iso, subdivision_iso},
residentialClients {phone_e164, phone_country, nationality_iso, timezone,
place_of_residence_country_iso, subdivision_iso}, companies {incorporation_
country_iso, incorporation_subdivision_iso}, companyAddresses {country_iso,
subdivision_iso}. Plus shared zod validators (validators/i18n.ts) used
by every entity validator + route handler.
PR6 ClientForm + ClientDetail — CountryCombobox replaces nationality Input,
TimezoneCombobox replaces timezone Input (driven by nationalityIso hint),
PhoneInput conditionally rendered for phone/whatsapp contacts. Inline
editors (InlineCountryField / InlineTimezoneField / InlinePhoneField)
for the detail-page overview rows + ContactsEditor.
PR7 Residential client form + detail — phone -> PhoneInput, nationality/
timezone/place-of-residence-country/subdivision rows in both create
sheet and inline-editable detail view. Subdivision wipes when country
flips since codes are country-scoped.
PR8 Company form + detail — incorporation country -> CountryCombobox,
incorporation region -> SubdivisionCombobox in both modes.
PR9 Public inquiry endpoint — accepts pre-normalized phoneE164/phoneCountry
and i18n fields from newer website builds, server-side parsePhone()
fallback for legacy raw-international submissions. Old Nuxt builds
keep working unchanged.
Tests: 4 unit suites for the primitives (25 tests), 1 integration spec for
the public phone-normalization path (3 tests), 1 smoke spec asserting the
combobox triggers render in all three create sheets.
Test totals: vitest 713 -> 741 (+28).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
88 lines
3.0 KiB
TypeScript
88 lines
3.0 KiB
TypeScript
/**
|
|
* i18n PR1 — country dataset.
|
|
*
|
|
* Validates:
|
|
* 1. The dataset includes every common ISO-3166-1 alpha-2 code we'd
|
|
* reasonably want (sanity sample, not exhaustive)
|
|
* 2. `isValidCountryCode` rejects bogus inputs
|
|
* 3. `getCountryName` returns localized names; falls back to the code
|
|
* 4. `detectDefaultCountry` returns the fallback in non-browser envs
|
|
*/
|
|
|
|
import { describe, it, expect } from 'vitest';
|
|
import {
|
|
ALL_COUNTRY_CODES,
|
|
ISO_COUNTRIES,
|
|
isValidCountryCode,
|
|
getCountryName,
|
|
detectDefaultCountry,
|
|
} from '@/lib/i18n/countries';
|
|
|
|
describe('i18n countries', () => {
|
|
it('includes core anglophone, EU, MENA, APAC, and Americas codes', () => {
|
|
const sample = ['US', 'GB', 'PL', 'DE', 'FR', 'AU', 'JP', 'BR', 'AE', 'NG', 'AI'];
|
|
for (const code of sample) {
|
|
expect(ISO_COUNTRIES.has(code)).toBe(true);
|
|
}
|
|
});
|
|
|
|
it('has at least 240 codes and is unique', () => {
|
|
expect(ALL_COUNTRY_CODES.length).toBeGreaterThanOrEqual(240);
|
|
expect(new Set(ALL_COUNTRY_CODES).size).toBe(ALL_COUNTRY_CODES.length);
|
|
});
|
|
|
|
it('isValidCountryCode rejects unknown / lowercased / 3-letter codes', () => {
|
|
expect(isValidCountryCode('US')).toBe(true);
|
|
expect(isValidCountryCode('us')).toBe(false);
|
|
expect(isValidCountryCode('USA')).toBe(false);
|
|
expect(isValidCountryCode('XX')).toBe(false);
|
|
expect(isValidCountryCode('')).toBe(false);
|
|
});
|
|
|
|
it('getCountryName returns localized names and falls back to the code on error', () => {
|
|
expect(getCountryName('US', 'en')).toMatch(/United States/);
|
|
expect(getCountryName('GB', 'en')).toMatch(/United Kingdom/);
|
|
expect(getCountryName('PL', 'pl')).toMatch(/Polska/i);
|
|
// Unknown code -> code itself.
|
|
expect(getCountryName('ZZ', 'en')).toBe('ZZ');
|
|
});
|
|
|
|
it('detectDefaultCountry returns the navigator region when valid', () => {
|
|
const original = globalThis.navigator;
|
|
Object.defineProperty(globalThis, 'navigator', {
|
|
value: { language: 'en-GB' },
|
|
configurable: true,
|
|
});
|
|
expect(detectDefaultCountry()).toBe('GB');
|
|
Object.defineProperty(globalThis, 'navigator', {
|
|
value: original,
|
|
configurable: true,
|
|
});
|
|
});
|
|
|
|
it('detectDefaultCountry uses the fallback when navigator is unset', () => {
|
|
const original = globalThis.navigator;
|
|
// @ts-expect-error force navigator to undefined for the duration of this test
|
|
delete globalThis.navigator;
|
|
expect(detectDefaultCountry()).toBe('US');
|
|
expect(detectDefaultCountry('GB')).toBe('GB');
|
|
Object.defineProperty(globalThis, 'navigator', {
|
|
value: original,
|
|
configurable: true,
|
|
});
|
|
});
|
|
|
|
it('detectDefaultCountry falls back when the navigator region is unknown', () => {
|
|
const original = globalThis.navigator;
|
|
Object.defineProperty(globalThis, 'navigator', {
|
|
value: { language: 'xx-ZZ' },
|
|
configurable: true,
|
|
});
|
|
expect(detectDefaultCountry()).toBe('US');
|
|
Object.defineProperty(globalThis, 'navigator', {
|
|
value: original,
|
|
configurable: true,
|
|
});
|
|
});
|
|
});
|