73-file atomic rename per docs/tenancies-design.md:
- Migration 0085: rename table + indexes + FK constraints; rename
documents.reservation_id → tenancy_id; migrate jsonb permission maps
(reservations resource → tenancies; collapse create+activate → manage);
rewrite historical audit_logs.entity_type='berth_reservation' →
'berth_tenancy'. FK renames wrapped in DO blocks so dev DBs that pre-date
the FK additions don't abort.
- Schema: berthReservations → berthTenancies; BerthReservation type →
BerthTenancy; indexes idx_br_* / idx_brr_* → idx_bt_*.
- RolePermissions: resource { view, create, activate, cancel } collapses to
{ view, manage, cancel }; all 8 default seed bundles + role-form + matrix
updated.
- Service: berth-reservations.service.ts → berth-tenancies.service.ts;
endReservation → endTenancy; listReservations → listTenancies.
- API: /api/v1/berth-reservations → /api/v1/tenancies (+ nested [id]);
/api/v1/berths/[id]/reservations → /api/v1/berths/[id]/tenancies.
- Validators: reservations.ts → tenancies.ts; RESERVATION_STATUSES →
TENANCY_STATUSES; endReservationSchema → endTenancySchema.
- Routes: /{portSlug}/berth-reservations → /{portSlug}/tenancies;
/portal/my-reservations → /portal/my-tenancies.
- Components: src/components/reservations/* → src/components/tenancies/*;
BerthReservationsTab → BerthTenanciesTab; ClientReservationsTab →
ClientTenanciesTab; ReservationList → TenancyList.
- Socket events: berth_reservation:* → berth_tenancy:*; payload
reservationId → tenancyId.
- Webhook events: berth_reservation.* → berth_tenancy.*.
- Portal: getPortalUserReservations → getPortalUserTenancies;
PortalReservation → PortalTenancy; PortalDashboard.counts.activeReservations
→ activeTenancies; PortalNav label "Reservations" → "Tenancies".
- Dossier: DossierReservation → DossierTenancy; reservationDecisions →
tenancyDecisions across smart-archive-dialog + bulk-archive routes.
- Documents schema: documents.reservationId → documents.tenancyId
(TS + DB column + index + FK constraint).
- Activity feed label berth_reservation → berth_tenancy (matched against
migrated historical audit rows).
KEPT (separate concepts):
- Reservation Agreement document type (the contract sent to clients).
- "Reservation" pipeline stage name.
- {{reservation.*}} merge tokens in template authoring.
- interest.reservationStatus / reservationDocStatus / dateReservationSent
fields (track agreement signing on the deal).
- reservation-agreement-context.ts service (builds merge context for the
Reservation Agreement doc; only its DB imports were renamed).
Verified: tsc clean, 1480/1480 vitest passing, migration applied.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
207 lines
6.6 KiB
TypeScript
207 lines
6.6 KiB
TypeScript
/**
|
|
* Engine integration test - drives `runAlertEngineForPorts` against
|
|
* seeded conditions and asserts: (1) correct alerts upsert, (2) running
|
|
* twice doesn't duplicate, (3) mutating state auto-resolves stale alerts.
|
|
*
|
|
* Socket emissions are stubbed via vi.mock so the test stays offline.
|
|
*/
|
|
|
|
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
import { and, eq, isNull } from 'drizzle-orm';
|
|
|
|
vi.mock('@/lib/socket/server', () => ({
|
|
emitToRoom: vi.fn(),
|
|
}));
|
|
|
|
import { db } from '@/lib/db';
|
|
import { alerts } from '@/lib/db/schema/insights';
|
|
import { interests } from '@/lib/db/schema/interests';
|
|
import { berthTenancies } from '@/lib/db/schema/tenancies';
|
|
import { documents } from '@/lib/db/schema/documents';
|
|
import { runAlertEngineForPorts } from '@/lib/services/alert-engine';
|
|
import { makePort, makeClient, makeBerth, makeYacht } from '../helpers/factories';
|
|
|
|
async function clearAlerts(portId: string) {
|
|
await db.delete(alerts).where(eq(alerts.portId, portId));
|
|
}
|
|
|
|
async function listOpenAlerts(portId: string, ruleId: string) {
|
|
return db
|
|
.select()
|
|
.from(alerts)
|
|
.where(and(eq(alerts.portId, portId), eq(alerts.ruleId, ruleId), isNull(alerts.resolvedAt)));
|
|
}
|
|
|
|
describe('alert engine', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it('reservation.no_agreement fires for active reservation older than 3 days without agreement', async () => {
|
|
const port = await makePort();
|
|
const client = await makeClient({ portId: port.id });
|
|
const berth = await makeBerth({ portId: port.id });
|
|
const yacht = await makeYacht({
|
|
portId: port.id,
|
|
ownerType: 'client',
|
|
ownerId: client.id,
|
|
overrides: { name: 'M/Y Test' },
|
|
});
|
|
const fourDaysAgo = new Date(Date.now() - 4 * 86_400_000);
|
|
const [resv] = await db
|
|
.insert(berthTenancies)
|
|
.values({
|
|
portId: port.id,
|
|
berthId: berth.id,
|
|
clientId: client.id,
|
|
yachtId: yacht.id,
|
|
status: 'active',
|
|
startDate: new Date(),
|
|
createdBy: 'seed',
|
|
createdAt: fourDaysAgo,
|
|
})
|
|
.returning();
|
|
expect(resv).toBeDefined();
|
|
|
|
await clearAlerts(port.id);
|
|
await runAlertEngineForPorts([port.id]);
|
|
|
|
const open = await listOpenAlerts(port.id, 'reservation.no_agreement');
|
|
expect(open).toHaveLength(1);
|
|
expect(open[0]!.entityId).toBe(resv!.id);
|
|
expect(open[0]!.severity).toBe('warning');
|
|
});
|
|
|
|
it('does not duplicate on a second sweep', async () => {
|
|
const port = await makePort();
|
|
const client = await makeClient({ portId: port.id });
|
|
const berth = await makeBerth({ portId: port.id });
|
|
const yacht = await makeYacht({
|
|
portId: port.id,
|
|
ownerType: 'client',
|
|
ownerId: client.id,
|
|
});
|
|
const stale = new Date(Date.now() - 10 * 86_400_000);
|
|
await db.insert(berthTenancies).values({
|
|
portId: port.id,
|
|
berthId: berth.id,
|
|
clientId: client.id,
|
|
yachtId: yacht.id,
|
|
status: 'active',
|
|
startDate: new Date(),
|
|
createdBy: 'seed',
|
|
createdAt: stale,
|
|
});
|
|
|
|
await clearAlerts(port.id);
|
|
await runAlertEngineForPorts([port.id]);
|
|
await runAlertEngineForPorts([port.id]);
|
|
|
|
const open = await listOpenAlerts(port.id, 'reservation.no_agreement');
|
|
expect(open).toHaveLength(1);
|
|
});
|
|
|
|
it('auto-resolves an open alert when the underlying condition clears', async () => {
|
|
const port = await makePort();
|
|
const client = await makeClient({ portId: port.id });
|
|
const berth = await makeBerth({ portId: port.id });
|
|
const yacht = await makeYacht({
|
|
portId: port.id,
|
|
ownerType: 'client',
|
|
ownerId: client.id,
|
|
});
|
|
const tenDaysAgo = new Date(Date.now() - 10 * 86_400_000);
|
|
const [resv] = await db
|
|
.insert(berthTenancies)
|
|
.values({
|
|
portId: port.id,
|
|
berthId: berth.id,
|
|
clientId: client.id,
|
|
yachtId: yacht.id,
|
|
status: 'active',
|
|
startDate: new Date(),
|
|
createdBy: 'seed',
|
|
createdAt: tenDaysAgo,
|
|
})
|
|
.returning();
|
|
|
|
await clearAlerts(port.id);
|
|
await runAlertEngineForPorts([port.id]);
|
|
expect(await listOpenAlerts(port.id, 'reservation.no_agreement')).toHaveLength(1);
|
|
|
|
// Add an agreement document - condition no longer fires.
|
|
await db.insert(documents).values({
|
|
portId: port.id,
|
|
tenancyId: resv!.id,
|
|
documentType: 'reservation_agreement',
|
|
title: 'Reservation Agreement',
|
|
status: 'sent',
|
|
createdBy: 'seed',
|
|
});
|
|
await runAlertEngineForPorts([port.id]);
|
|
|
|
expect(await listOpenAlerts(port.id, 'reservation.no_agreement')).toHaveLength(0);
|
|
const allRows = await db
|
|
.select()
|
|
.from(alerts)
|
|
.where(and(eq(alerts.portId, port.id), eq(alerts.ruleId, 'reservation.no_agreement')));
|
|
expect(allRows).toHaveLength(1);
|
|
expect(allRows[0]!.resolvedAt).not.toBeNull();
|
|
});
|
|
|
|
it('interest.stale fires for old leads in mid-funnel stages', async () => {
|
|
const port = await makePort();
|
|
const client = await makeClient({ portId: port.id });
|
|
const stale = new Date(Date.now() - 30 * 86_400_000);
|
|
const [interest] = await db
|
|
.insert(interests)
|
|
.values({
|
|
portId: port.id,
|
|
clientId: client.id,
|
|
pipelineStage: 'qualified',
|
|
dateLastContact: stale,
|
|
createdAt: stale,
|
|
updatedAt: stale,
|
|
})
|
|
.returning();
|
|
|
|
await clearAlerts(port.id);
|
|
await runAlertEngineForPorts([port.id]);
|
|
|
|
const open = await listOpenAlerts(port.id, 'interest.stale');
|
|
expect(open).toHaveLength(1);
|
|
expect(open[0]!.entityId).toBe(interest!.id);
|
|
expect(open[0]!.severity).toBe('info');
|
|
});
|
|
|
|
it('interest.high_value_silent fires for hot leads silent >7d', async () => {
|
|
const port = await makePort();
|
|
const client = await makeClient({ portId: port.id });
|
|
const stale = new Date(Date.now() - 10 * 86_400_000);
|
|
await db.insert(interests).values({
|
|
portId: port.id,
|
|
clientId: client.id,
|
|
pipelineStage: 'qualified',
|
|
leadCategory: 'hot_lead',
|
|
dateLastContact: stale,
|
|
updatedAt: stale,
|
|
});
|
|
|
|
await clearAlerts(port.id);
|
|
await runAlertEngineForPorts([port.id]);
|
|
|
|
const open = await listOpenAlerts(port.id, 'interest.high_value_silent');
|
|
expect(open).toHaveLength(1);
|
|
expect(open[0]!.severity).toBe('critical');
|
|
});
|
|
|
|
it('engine reports rule errors without crashing the sweep', async () => {
|
|
const port = await makePort();
|
|
const summary = await runAlertEngineForPorts([port.id]);
|
|
expect(summary.portsScanned).toBe(1);
|
|
expect(summary.rulesEvaluated).toBeGreaterThan(0);
|
|
// No conditions seeded - no rules should fail.
|
|
expect(summary.errors).toHaveLength(0);
|
|
});
|
|
});
|