Matt
cb8292464c
Bundles the rest of the in-flight work from this UAT round into one
checkpoint. Each sub-area is independent; see the headings below.
UAT polish (drained 11 findings from active-uat.md):
- Dialog primitive default bumped sm:max-w-xl/lg:max-w-3xl →
sm:max-w-2xl/lg:max-w-4xl so multi-field forms + PDF previews
aren't cramped at 1440-1920px.
- Notes tab badge aggregation: new countFor{Client,Yacht,Company}
Aggregated helpers in notes.service mirror the listFor*Aggregated
symmetric-reach joins. yacht-tabs + company-tabs render the
badge; client-tabs already had badge support.
- Supplemental-info form polish bundle: BrandedAuthShell gains a
`width: 'sm' | 'md'` prop (md uses min-h-dvh scroll instead of
fixed inset-0 pin so long forms scroll naturally). Form picks up
port branding (logoUrl + backgroundUrl + appName) via
loadByToken. Address fields completed (street + city + region +
postal + country). Port name eyebrow + success-state copy added.
- new-document-menu Upload-file landing toast: per-file completion
emits toast.success with action link to the destination entity
or folder.
- interest-tabs OverviewTab "from client" pill on Email + Phone
rows via new EditableRow `inheritedFrom` prop.
- create-document-wizard subject picker → segmented button strip
(5 types visible at once).
Launch infra:
- UTM column wiring (Init 1b step 4): migration
0089_website_submissions_utm.sql adds utm_source/medium/campaign/
term/content + composite index (port_id, utm_source, received_at)
for per-campaign rollups. website-inquiries intake accepts the
five fields. Residential intake intentionally untouched per audit
scope.
- Invoicing module gate (Init 1c spike): new
invoices-module.service + invoices layout guard + registry entry
invoices_module_enabled (default false). Audit conclusion in
launch-readiness.md: payments table is canonical money path;
/invoices flow is parallel infrastructure now hidden by default.
Smart-back navigation refactor:
- Replaced breadcrumb component with history-aware Back button.
New route-labels.ts + use-smart-back hook +
navigation-history-tracker so back falls through to the parent
route when there's no prior page in history.
- Sidebar / topbar / mobile-topbar adopt the new pattern; old
breadcrumb-store kept for back-compat consumers but the
breadcrumbs component is gone.
- 6 detail pages (admin/errors per-id + codes, invoices/
upload-receipts, reports kind, tenancies detail, analytics
metric, client detail) migrated.
Trackers + docs:
- docs/launch-readiness.md — master pre-launch tracker. Includes
the reports gap audit (cross-cutting filter set, Marketing +
Financial blockers, custom builder remaining entities, scheduled
CSV/XLSX, template scope picker).
- docs/superpowers/audits/active-uat.md — 15 findings flipped
OPEN → SHIPPED locally with fix-applied notes; 4 OPEN remaining
(each blocked on user input or cross-repo).
- CLAUDE.md — minor session notes carried forward.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
60 lines
2.5 KiB
TypeScript
60 lines
2.5 KiB
TypeScript
'use client';
|
|
|
|
import { useEffect } from 'react';
|
|
import { usePathname } from 'next/navigation';
|
|
|
|
import { type BreadcrumbHint, useBreadcrumbStore } from '@/stores/breadcrumb-store';
|
|
|
|
/**
|
|
* Detail pages call this on mount to register their entity hierarchy.
|
|
* The hint is consumed by `useSmartBack` to label the topbar back
|
|
* button - the closest parent in `parents` becomes the back target,
|
|
* so a rep on an interest page sees "Back to Mary Smith" (the client
|
|
* they drilled in from) instead of the URL-derived "Back to Clients".
|
|
*
|
|
* Pass a stable hint object (or memoise the inputs) so the effect
|
|
* doesn't re-fire every render.
|
|
*
|
|
* Example (interest detail page):
|
|
* useBreadcrumbHint({
|
|
* parents: [{ label: 'Mary Smith', href: '/port/clients/abc' }],
|
|
* current: 'B17',
|
|
* });
|
|
*
|
|
* The hint clears when the page unmounts so a stale hierarchy doesn't
|
|
* leak into the next route.
|
|
*
|
|
* Naming note: the hook + store kept their `breadcrumb` prefix when
|
|
* the topbar breadcrumb trail was retired in favor of the contextual
|
|
* back button. They are now back-context hints, not breadcrumb chain
|
|
* entries - the names stayed to avoid touching every detail page.
|
|
*/
|
|
export function useBreadcrumbHint(hint: BreadcrumbHint | null | undefined): void {
|
|
const pathname = usePathname();
|
|
const setHint = useBreadcrumbStore((s) => s.setHint);
|
|
const clearHint = useBreadcrumbStore((s) => s.clearHint);
|
|
const cacheLabel = useBreadcrumbStore((s) => s.cacheLabel);
|
|
|
|
// Stringify for stable equality - caller can pass an object literal
|
|
// each render without wrecking effect deps. The serialized form is
|
|
// tiny (handful of strings) so this is cheap.
|
|
const serialized = hint ? JSON.stringify(hint) : null;
|
|
|
|
useEffect(() => {
|
|
if (!serialized || !hint) return;
|
|
setHint(pathname, hint);
|
|
// Snapshot the display label into the persistent labelCache so the
|
|
// back button can render "Back to Sarah Doe" after the rep has
|
|
// drilled away from her detail page (at which point the hint above
|
|
// has unmounted, but the label is still load-bearing).
|
|
cacheLabel(pathname, hint.current);
|
|
return () => {
|
|
clearHint(pathname);
|
|
};
|
|
// serialized stands in for `hint` value-equality; pathname triggers
|
|
// re-register if the page navigates without unmounting (rare but
|
|
// possible on client-side route swaps within the same layout).
|
|
// eslint-disable-next-line react-hooks/exhaustive-deps
|
|
}, [serialized, pathname, setHint, clearHint, cacheLabel]);
|
|
}
|