Files
pn-new-crm/src/components/shared/owner-picker.tsx
Matt c8ea9ec0a0 fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 12:37:22 +02:00

190 lines
6.2 KiB
TypeScript

'use client';
import { useState } from 'react';
import { Check, ChevronsUpDown } from 'lucide-react';
import { useQuery } from '@tanstack/react-query';
import { Button } from '@/components/ui/button';
import {
Command,
CommandEmpty,
CommandGroup,
CommandInput,
CommandItem,
CommandList,
} from '@/components/ui/command';
import { Popover, PopoverContent, PopoverTrigger } from '@/components/ui/popover';
import { useDebounce } from '@/hooks/use-debounce';
import { apiFetch } from '@/lib/api/client';
import { cn } from '@/lib/utils';
export type OwnerRef = { type: 'client' | 'company'; id: string };
interface OwnerOption {
id: string;
name?: string | null;
fullName?: string | null;
}
interface OwnerPickerProps {
value: OwnerRef | null;
onChange: (value: OwnerRef | null) => void;
/** Optional placeholder when empty */
placeholder?: string;
/** Disable the component */
disabled?: boolean;
}
export function OwnerPicker({
value,
onChange,
placeholder = 'Select owner...',
disabled,
}: OwnerPickerProps) {
const [open, setOpen] = useState(false);
// `type` is derived: when an owner is selected the prop wins; with no
// selection the user's local tab pick is the source of truth. Render-
// phase derivation replaces the prior useEffect(setType, [value?.type])
// that the Compiler flagged as set-state-in-effect.
const [localType, setLocalType] = useState<'client' | 'company'>(value?.type ?? 'client');
const type: 'client' | 'company' = value?.type ?? localType;
const setType = setLocalType;
const [search, setSearch] = useState('');
const debounced = useDebounce(search, 300);
const endpoint =
type === 'client'
? `/api/v1/clients/options?search=${encodeURIComponent(debounced)}`
: `/api/v1/companies/autocomplete?q=${encodeURIComponent(debounced)}`;
const { data } = useQuery<{ data: OwnerOption[] }>({
queryKey: ['owner-picker', type, debounced],
queryFn: () => apiFetch(endpoint),
enabled: open,
});
const options = data?.data ?? [];
// Resolve the current value's display name even before the picker is opened.
// Without this primer query the trigger button rendered "Client <8-char-id>"
// on first paint and only filled in the real name after the user opened the
// dropdown (which kicked the list query). The lookup hits a per-id endpoint
// when possible and falls back to scanning the cached options array.
const valueLookupEndpoint = value
? value.type === 'client'
? `/api/v1/clients/${value.id}`
: `/api/v1/companies/${value.id}`
: null;
const { data: valueDetail } = useQuery<{
data: { id: string; name?: string | null; fullName?: string | null };
}>({
queryKey: ['owner-picker-resolve', value?.type, value?.id],
queryFn: () => apiFetch(valueLookupEndpoint!),
enabled: !!value && !!valueLookupEndpoint,
staleTime: 60_000,
});
// Selected display label - prefer the resolved entity name; fall back to a
// truncated id only when both the primer query and the options list miss.
const selectedLabel = (() => {
if (!value) return placeholder;
if (valueDetail?.data) {
const name = value.type === 'client' ? valueDetail.data.fullName : valueDetail.data.name;
if (name) return name;
}
const match = options.find((o) => o.id === value.id);
if (match) {
return type === 'client'
? (match.fullName ?? '(unnamed client)')
: (match.name ?? '(unnamed company)');
}
return value.type === 'client'
? `Client ${value.id.slice(0, 8)}`
: `Company ${value.id.slice(0, 8)}`;
})();
return (
<Popover open={open} onOpenChange={setOpen} modal>
<PopoverTrigger asChild>
<Button
variant="outline"
role="combobox"
disabled={disabled}
className={cn('w-full justify-between', !value && 'text-muted-foreground')}
>
<span className="truncate">
{value && (
<span className="mr-2 text-xs opacity-60">
{value.type === 'client' ? 'Client:' : 'Company:'}
</span>
)}
{selectedLabel}
</span>
<ChevronsUpDown className="ml-2 h-4 w-4 shrink-0 opacity-50" aria-hidden />
</Button>
</PopoverTrigger>
<PopoverContent className="w-[320px] p-0" align="start">
{/* Type toggle */}
<div className="flex border-b">
<button
type="button"
onClick={() => {
setType('client');
setSearch('');
}}
className={cn(
'flex-1 px-3 py-2 text-xs',
type === 'client' ? 'bg-accent font-medium' : 'hover:bg-accent/50',
)}
>
Client
</button>
<button
type="button"
onClick={() => {
setType('company');
setSearch('');
}}
className={cn(
'flex-1 px-3 py-2 text-xs',
type === 'company' ? 'bg-accent font-medium' : 'hover:bg-accent/50',
)}
>
Company
</button>
</div>
<Command shouldFilter={false}>
<CommandInput placeholder={`Search ${type}s…`} value={search} onValueChange={setSearch} />
<CommandList>
<CommandEmpty>No results.</CommandEmpty>
<CommandGroup>
{options.map((opt) => {
const label =
type === 'client' ? (opt.fullName ?? '(unnamed)') : (opt.name ?? '(unnamed)');
const isSelected = value?.id === opt.id && value?.type === type;
return (
<CommandItem
key={opt.id}
value={opt.id}
onSelect={() => {
onChange({ type, id: opt.id });
setOpen(false);
}}
>
<Check
className={cn('mr-2 h-4 w-4', isSelected ? 'opacity-100' : 'opacity-0')}
/>
{label}
</CommandItem>
);
})}
</CommandGroup>
</CommandList>
</Command>
</PopoverContent>
</Popover>
);
}