Knocks out 10 of the 13 known issues from yesterday's Playwright audit. A4 — Client form silently rejected submit when a contact row had an empty value. The F19 filter ran in mutationFn after zod's handleSubmit had already short-circuited on min(1). Now wraps the onSubmit to prune empty rows BEFORE handleSubmit/zod sees them. A16 — File upload to documents hub root 400'd because FormData.get returns null for absent fields and zod's .optional() rejects null. Route handler now coerces null/empty → undefined before parse. A17 — Added /api/v1/me/ports endpoint that any authenticated user can hit; client.ts now uses it as the bootstrap port-slug→port-id resolver. Eliminates the wasteful 400s sales-reps and viewers were firing on every page load against the super-admin-gated /admin/ports. A1 — Filter permission_denied actions from the dashboard activity feed. Still in the audit log; just not noise on the dashboard. A2 — New LEGACY_STAGE_REMAP table + canonicalizeStage / stageLabelFor helpers in lib/constants. Activity-feed maps legacy 9-stage enum values (deposit_10pct, contract_sent, etc.) to their 7-stage labels on the way out, so historical audit rows read as "Deposit Paid" not "Deposit 10Pct". A19 — Same-stage write now returns 204 No Content. Service returns a STAGE_NOOP sentinel; the route handler translates it. A9 — Catch-up wizard now derives stage from berth status (under_offer → EOI, sold → contract) with a stageOverride state for explicit user picks. Avoids the set-state-in-effect rule violation. A20 — OwnerPicker shows a "Client / Company" hint chip on the trigger when no value is set, so users know the trigger opens a two-tab picker instead of just a client list. A8 — Migration 0066 normalizes legacy `statusOverrideMode = 'auto'` to NULL so the column lives at strictly 3 states. A6 — file-preview-dialog gets a screen-reader DialogDescription so the Radix "Missing aria-describedby" warning stops firing on every preview. A18 closed as not-a-bug: /api/v1/users genuinely doesn't exist (Next returns 404); /api/v1/admin/audit exists and 403s. A5 (Socket.IO dev noise) + A3 (react-grab CSP) left for a separate pass — both are dev-only cosmetic. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
176 lines
6.2 KiB
TypeScript
176 lines
6.2 KiB
TypeScript
'use client';
|
|
|
|
import { useUIStore } from '@/stores/ui-store';
|
|
|
|
export interface ApiFetchOptions extends Omit<RequestInit, 'body'> {
|
|
body?: unknown;
|
|
}
|
|
|
|
/** In-memory cache: slug -> id, populated lazily by `resolvePortIdFromSlug`.
|
|
* Avoids re-fetching `/api/v1/admin/ports` on every request when the Zustand
|
|
* store hasn't hydrated yet (fresh browser context, e2e tests, hard reload). */
|
|
const slugToIdCache = new Map<string, string>();
|
|
/** Dedupe in-flight admin/ports lookups so a stampede of parallel apiFetch
|
|
* calls (typical on dashboard mount) collapses into a single network round-
|
|
* trip instead of N. */
|
|
let inFlightPortsLookup: Promise<Array<{ id: string; slug: string }> | null> | null = null;
|
|
|
|
async function resolvePortIdFromSlug(slug: string): Promise<string | null> {
|
|
const cached = slugToIdCache.get(slug);
|
|
if (cached) return cached;
|
|
if (!inFlightPortsLookup) {
|
|
inFlightPortsLookup = (async () => {
|
|
try {
|
|
// A17: use /me/ports — works for every authenticated user.
|
|
// The prior code hit /admin/ports which is super-admin-gated, so
|
|
// sales-reps/viewers fired a wasteful 400 on every page load.
|
|
const res = await fetch('/api/v1/me/ports', { credentials: 'include' });
|
|
if (!res.ok) return null;
|
|
const body = (await res.json()) as { data?: Array<{ id: string; slug: string }> };
|
|
return body.data ?? null;
|
|
} catch {
|
|
return null;
|
|
}
|
|
})().finally(() => {
|
|
inFlightPortsLookup = null;
|
|
});
|
|
}
|
|
const ports = await inFlightPortsLookup;
|
|
const port = ports?.find((p) => p.slug === slug);
|
|
if (!port) return null;
|
|
slugToIdCache.set(slug, port.id);
|
|
return port.id;
|
|
}
|
|
|
|
/**
|
|
* Client-side fetch wrapper that attaches the `X-Port-Id` header to
|
|
* every request.
|
|
*
|
|
* multi-port-auditor C1: the URL slug is authoritative — Zustand
|
|
* is a cache that lags by one render after `PortProvider`'s reconcile
|
|
* effect commits. The previous Zustand-first lookup caused first-load
|
|
* queries on a freshly-navigated port to fire with the PRIOR port's
|
|
* id and render cross-port data inside the new shell. Now we resolve
|
|
* the slug from `window.location.pathname` first and fall back to
|
|
* Zustand only when the URL doesn't carry a port slug (e.g. /dashboard
|
|
* / non-portSlug routes).
|
|
*/
|
|
export async function apiFetch<T = unknown>(url: string, opts: ApiFetchOptions = {}): Promise<T> {
|
|
let portId: string | null = null;
|
|
|
|
if (typeof window !== 'undefined') {
|
|
const slug = window.location.pathname.split('/').filter(Boolean)[0];
|
|
if (slug && slug !== 'login' && slug !== 'portal' && slug !== 'api' && slug !== 'dashboard') {
|
|
portId = await resolvePortIdFromSlug(slug);
|
|
}
|
|
}
|
|
|
|
// Fall back to the Zustand cache when the URL didn't yield a port —
|
|
// e.g. global routes (/dashboard) where the rep hasn't picked a port
|
|
// yet but a previous session set one.
|
|
if (!portId) {
|
|
portId = useUIStore.getState().currentPortId;
|
|
}
|
|
|
|
const headers = new Headers(opts.headers);
|
|
if (portId) {
|
|
headers.set('X-Port-Id', portId);
|
|
}
|
|
if (opts.body !== undefined && !headers.has('Content-Type')) {
|
|
headers.set('Content-Type', 'application/json');
|
|
}
|
|
|
|
const res = await fetch(url, {
|
|
...opts,
|
|
headers,
|
|
credentials: 'include',
|
|
body: opts.body !== undefined ? JSON.stringify(opts.body) : undefined,
|
|
});
|
|
|
|
if (!res.ok) {
|
|
// error-ux-auditor C3: reverse-proxy 502/504 pages deliver HTML, not
|
|
// JSON. The previous code silently degraded to
|
|
// `{error: res.statusText}` which surfaced "Bad Gateway" with no
|
|
// requestId and no copy-pasteable correlation handle. Detect the
|
|
// proxy-error shape (5xx + JSON parse fail) and synthesize a
|
|
// client-side correlation id so the toast still has *something* the
|
|
// user can quote to support.
|
|
const error = (await res.json().catch(() => null)) as {
|
|
error?: string;
|
|
message?: string;
|
|
code?: string;
|
|
details?: unknown;
|
|
requestId?: string;
|
|
retryAfter?: number;
|
|
} | null;
|
|
const upstreamRequestId = res.headers.get('x-request-id');
|
|
if (error === null) {
|
|
const isProxyFailure = res.status >= 500;
|
|
// Short, copy-pasteable client-side handle so support can grep
|
|
// the front-end logs even when the proxy never reached our app.
|
|
const synthId =
|
|
upstreamRequestId ??
|
|
`client-${Date.now().toString(36)}-${Math.random().toString(36).slice(2, 8)}`;
|
|
throw new ApiError({
|
|
message: isProxyFailure
|
|
? 'The server is unreachable. Please try again.'
|
|
: res.statusText || 'Request failed',
|
|
status: res.status,
|
|
code: isProxyFailure ? 'UPSTREAM_UNREACHABLE' : null,
|
|
details: null,
|
|
requestId: synthId,
|
|
retryAfter: null,
|
|
});
|
|
}
|
|
const requestId = error.requestId ?? upstreamRequestId ?? null;
|
|
throw new ApiError({
|
|
message: error.error ?? error.message ?? 'Request failed',
|
|
status: res.status,
|
|
code: error.code ?? null,
|
|
details: error.details ?? null,
|
|
requestId,
|
|
retryAfter: typeof error.retryAfter === 'number' ? error.retryAfter : null,
|
|
});
|
|
}
|
|
|
|
if (res.status === 204) return undefined as T;
|
|
return res.json() as Promise<T>;
|
|
}
|
|
|
|
/**
|
|
* Structured client-side error thrown by `apiFetch`. Carries the stable
|
|
* fields a toast / error boundary needs to render a useful message:
|
|
*
|
|
* - `message`: plain-text, ready to show to the user
|
|
* - `code`: stable error code from `src/lib/error-codes.ts`
|
|
* - `requestId`: paste this to support to find the row in
|
|
* `/admin/errors/<requestId>`
|
|
*
|
|
* Mutations should use the `toastError(err)` helper rather than reading
|
|
* these fields directly — that keeps the toast format consistent.
|
|
*/
|
|
export class ApiError extends Error {
|
|
status: number;
|
|
code: string | null;
|
|
details: unknown;
|
|
requestId: string | null;
|
|
retryAfter: number | null;
|
|
|
|
constructor(args: {
|
|
message: string;
|
|
status: number;
|
|
code: string | null;
|
|
details: unknown;
|
|
requestId: string | null;
|
|
retryAfter: number | null;
|
|
}) {
|
|
super(args.message);
|
|
this.name = 'ApiError';
|
|
this.status = args.status;
|
|
this.code = args.code;
|
|
this.details = args.details;
|
|
this.requestId = args.requestId;
|
|
this.retryAfter = args.retryAfter;
|
|
}
|
|
}
|