Files
pn-new-crm/src/components/shared/phone-input.tsx
Matt 4b5f85cb7d fix(audit): comprehensive 2026-05-15 audit fix wave + Documenso v2 polish
Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).

CRITICAL (3):
 - C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
   no longer silently drop interest links
 - C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
 - C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
   callers must go through /stage with the override-guard chain

HIGH (14/15):
 - H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
   interests/documents/reservations/reminders/invoices (migration 0070)
 - H-02 login page reads ?redirect= param with same-origin guard
 - H-03 CRM invite token moves to URL fragment so it never lands in
   nginx access logs / Referer headers
 - H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
 - H-05 toggleAccount writes an audit row
 - H-06 upsertSetting masks any value whose key ends with _encrypted
 - H-07 archiveClient cascade fires per-interest audit rows
 - H-08 createSalesTransporter applies SMTP_TIMEOUTS
 - H-09 AppShell stable children — viewport flip across breakpoint no
   longer destroys in-progress form drafts
 - H-10 portal documents page swaps Unicode glyph status icons for
   Lucide CheckCircle2/XCircle/Circle + aria-labels
 - H-12 list components swap alert(...) for toast.warning(...)
 - H-13 5 icon-only buttons gain aria-label
 - H-14 parseBody treats empty bodies as {}
 - H-15 admin layout renders a 403 panel instead of silent bounce
 - H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet

MEDIUM (28+):
 - M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
   WHEREs across custom-fields, notes (all 6 entity types x update +
   delete), client-contacts, yacht ownerClient lookup, webhook reads
 - M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
 - M-EM01 portal-auth emails thread through portId
 - M-EM02 sendEmail accepts cc/bcc params
 - M-EM04 notification_digest catalog key
 - M-IN01 portal presigned download URLs use 4h TTL
 - M-IN02 OpenAI client lazy-instantiated
 - M-IN04 stale pdfme refs updated to pdf-lib AcroForm
 - M-IN05 umami.testConnection returns tagged union
 - M-L01 reservations tenure_type unified with berths
 - M-L02 report-generators canonicalize stage values
 - M-AU01 audit log placeholder copy fixed
 - M-AU04 outcome_set / outcome_cleared distinct audit verbs
 - M-NEW-2 activity feed entity name+type separator
 - M-R01 portal allowlist narrowed + portal_session backstop in proxy
 - M-SC02 companies archived partial index
 - M-SC04 audit_logs.searchText documented as DB-managed
 - M-S01 storage_s3_access_key_encrypted admin field
 - M-U01 audit log empty state uses <EmptyState>
 - M-U09 invoice delete dialog -> <AlertDialog>
 - M-U10 toast.success on ClientForm + InterestForm create/edit
 - M-U11 settings-form-card logo preview alt text
 - M-U14 mobile topbar title on clients/yachts/interests/berths
 - M-U15 Invoices in mobile More-sheet

LOW (6/8):
 - L-AU01 severity defaults for security-relevant verbs
 - L-AU02 +13 missing actions in admin audit filter
 - L-AU03 +7 missing entity types in admin audit filter
 - L-AU04 dead listAuditLogs stubbed
 - L-D02 CLAUDE.md Owner-wins chain tightened

Bonus — Document detail polish (#67 partial, 3/6 deliverables):
 - state-aware action button per signer
 - watcher Add UI with display-name resolution
 - cleanSignerName cleanup

Prior session work bundled in:
 - Documenso v2 webhook + envelope-ID normalization + sequential signing
 - SigningProgress UI redesign (avatars, per-signer state, timestamps)
 - env->admin settings registry + RegistryDrivenForm + encrypted creds
 - Embedded-signing card + Test connection + setup help
 - Dev-mode EMAIL_REDIRECT_TO banner
 - Pipeline rules admin page
 - Sales email config card
 - Audit log details Sheet
 - EOI tab: Finalising badge, absolute timestamps, sequential indicator
 - Notes pipeline_stage_at_creation (migration 0069)
 - Documenso numeric ID dual-key webhook (migration 0068)
 - Dimensions criterion copy (migration 0067)

Tests: 1374/1374 vitest pass. tsc clean. lint clean.

See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 13:28:50 +02:00

148 lines
5.0 KiB
TypeScript

'use client';
import { useEffect, useRef, useState } from 'react';
import { Input } from '@/components/ui/input';
import { CountryCombobox } from '@/components/shared/country-combobox';
import { cn } from '@/lib/utils';
import { callingCodeFor, formatAsYouType, parsePhone } from '@/lib/i18n/phone';
import { detectDefaultCountry, type CountryCode } from '@/lib/i18n/countries';
export interface PhoneInputValue {
/** E.164 form ('+442079460958'). Null when empty or unparseable. */
e164: string | null;
/** Country selected in the dropdown - drives the AsYouType formatter. */
country: CountryCode;
}
interface PhoneInputProps {
value: PhoneInputValue | null | undefined;
onChange: (next: PhoneInputValue) => void;
/** Pre-selects the dropdown when `value.country` isn't supplied. */
defaultCountry?: CountryCode;
placeholder?: string;
disabled?: boolean;
required?: boolean;
invalid?: boolean;
id?: string;
'data-testid'?: string;
}
/**
* Phone input with a country flag dropdown + format-as-you-type.
*
* Wire shape: emits `{ e164, country }` on every change. E.164 is null
* while the input is too short to parse - that's a form-validation
* concern, not an input concern. Pasting an international number
* (`+1 415…`) auto-switches the country dropdown to match.
*
* Implementation notes:
* - The visible string is always the AsYouType national-format,
* so users see e.g. "020 7946 0958" while typing GB digits.
* - The `country` prop drives the AsYouType context; flipping
* countries reformats the same digits against the new country
* (matches what users expect when they fix a wrong country pick).
*/
export function PhoneInput({
value,
onChange,
defaultCountry,
placeholder = 'Phone number',
disabled,
required,
invalid,
id,
'data-testid': testId,
}: PhoneInputProps) {
const [country, setCountry] = useState<CountryCode>(
() => value?.country ?? defaultCountry ?? detectDefaultCountry('US'),
);
const [display, setDisplay] = useState(() => {
if (!value?.e164) return '';
const parsed = parsePhone(value.e164, value.country);
return parsed.national ?? '';
});
// Track whether the user has typed since mount - keeps a controlled-from-props
// value sync on first render only.
const initialized = useRef(false);
useEffect(() => {
if (initialized.current) return;
initialized.current = true;
}, []);
function emit(rawDigits: string, currentCountry: CountryCode) {
const parsed = parsePhone(rawDigits, currentCountry);
onChange({ e164: parsed.e164, country: currentCountry });
}
function handleInput(raw: string) {
// Paste-detect: if user pasted an international format, parse it
// and flip the country dropdown to match - better UX than asking
// them to also click the dropdown.
if (raw.startsWith('+')) {
const parsed = parsePhone(raw);
if (parsed.country) {
setCountry(parsed.country);
const reformatted = formatAsYouType(raw, parsed.country);
setDisplay(reformatted);
emit(raw, parsed.country);
return;
}
}
const formatted = formatAsYouType(raw, country);
setDisplay(formatted);
emit(formatted, country);
}
function handleCountryChange(next: CountryCode | null) {
if (!next) return;
setCountry(next);
// Re-run the formatter against the new country so the visible
// string stays consistent with the dropdown.
const reformatted = formatAsYouType(display, next);
setDisplay(reformatted);
emit(reformatted, next);
}
return (
<div
className={cn(
// `w-full` keeps the row matching the field width below it instead
// of collapsing to its content's intrinsic width when nested inside
// a flex/grid cell.
'flex w-full items-stretch gap-1.5',
invalid && '[&_input]:border-destructive [&_button[role=combobox]]:border-destructive',
)}
>
<CountryCombobox
value={country}
onChange={handleCountryChange}
compact
clearable={false}
disabled={disabled}
data-testid={testId ? `${testId}-country` : undefined}
/>
<div className="flex flex-1 items-stretch overflow-hidden rounded-md border border-input focus-within:ring-2 focus-within:ring-ring focus-within:ring-offset-2 focus-within:ring-offset-background">
<span className="flex select-none items-center bg-muted/40 px-2 text-sm tabular-nums text-muted-foreground">
{callingCodeFor(country)}
</span>
<Input
id={id}
type="tel"
inputMode="tel"
autoComplete="tel"
placeholder={placeholder}
value={display}
disabled={disabled}
required={required}
onChange={(e) => handleInput(e.target.value)}
// Strip the inner Input's own border so it sits flush with the country prefix.
className="flex-1 border-0 shadow-none focus-visible:ring-0 focus-visible:ring-offset-0"
data-testid={testId}
/>
</div>
</div>
);
}