Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).
CRITICAL (3):
- C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
no longer silently drop interest links
- C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
- C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
callers must go through /stage with the override-guard chain
HIGH (14/15):
- H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
interests/documents/reservations/reminders/invoices (migration 0070)
- H-02 login page reads ?redirect= param with same-origin guard
- H-03 CRM invite token moves to URL fragment so it never lands in
nginx access logs / Referer headers
- H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
- H-05 toggleAccount writes an audit row
- H-06 upsertSetting masks any value whose key ends with _encrypted
- H-07 archiveClient cascade fires per-interest audit rows
- H-08 createSalesTransporter applies SMTP_TIMEOUTS
- H-09 AppShell stable children — viewport flip across breakpoint no
longer destroys in-progress form drafts
- H-10 portal documents page swaps Unicode glyph status icons for
Lucide CheckCircle2/XCircle/Circle + aria-labels
- H-12 list components swap alert(...) for toast.warning(...)
- H-13 5 icon-only buttons gain aria-label
- H-14 parseBody treats empty bodies as {}
- H-15 admin layout renders a 403 panel instead of silent bounce
- H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet
MEDIUM (28+):
- M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
WHEREs across custom-fields, notes (all 6 entity types x update +
delete), client-contacts, yacht ownerClient lookup, webhook reads
- M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
- M-EM01 portal-auth emails thread through portId
- M-EM02 sendEmail accepts cc/bcc params
- M-EM04 notification_digest catalog key
- M-IN01 portal presigned download URLs use 4h TTL
- M-IN02 OpenAI client lazy-instantiated
- M-IN04 stale pdfme refs updated to pdf-lib AcroForm
- M-IN05 umami.testConnection returns tagged union
- M-L01 reservations tenure_type unified with berths
- M-L02 report-generators canonicalize stage values
- M-AU01 audit log placeholder copy fixed
- M-AU04 outcome_set / outcome_cleared distinct audit verbs
- M-NEW-2 activity feed entity name+type separator
- M-R01 portal allowlist narrowed + portal_session backstop in proxy
- M-SC02 companies archived partial index
- M-SC04 audit_logs.searchText documented as DB-managed
- M-S01 storage_s3_access_key_encrypted admin field
- M-U01 audit log empty state uses <EmptyState>
- M-U09 invoice delete dialog -> <AlertDialog>
- M-U10 toast.success on ClientForm + InterestForm create/edit
- M-U11 settings-form-card logo preview alt text
- M-U14 mobile topbar title on clients/yachts/interests/berths
- M-U15 Invoices in mobile More-sheet
LOW (6/8):
- L-AU01 severity defaults for security-relevant verbs
- L-AU02 +13 missing actions in admin audit filter
- L-AU03 +7 missing entity types in admin audit filter
- L-AU04 dead listAuditLogs stubbed
- L-D02 CLAUDE.md Owner-wins chain tightened
Bonus — Document detail polish (#67 partial, 3/6 deliverables):
- state-aware action button per signer
- watcher Add UI with display-name resolution
- cleanSignerName cleanup
Prior session work bundled in:
- Documenso v2 webhook + envelope-ID normalization + sequential signing
- SigningProgress UI redesign (avatars, per-signer state, timestamps)
- env->admin settings registry + RegistryDrivenForm + encrypted creds
- Embedded-signing card + Test connection + setup help
- Dev-mode EMAIL_REDIRECT_TO banner
- Pipeline rules admin page
- Sales email config card
- Audit log details Sheet
- EOI tab: Finalising badge, absolute timestamps, sequential indicator
- Notes pipeline_stage_at_creation (migration 0069)
- Documenso numeric ID dual-key webhook (migration 0068)
- Dimensions criterion copy (migration 0067)
Tests: 1374/1374 vitest pass. tsc clean. lint clean.
See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
332 lines
12 KiB
TypeScript
332 lines
12 KiB
TypeScript
/**
|
|
* Sends Documenso-related signing emails:
|
|
*
|
|
* - `sendSigningInvitation` — initial "your turn to sign" email
|
|
* (one signer at a time). Used both for the first client
|
|
* invitation after generation AND for the cascading "your turn"
|
|
* emails when an upstream signer completes.
|
|
*
|
|
* - `sendSigningReminder` — follow-up nudge for an unsigned signer.
|
|
* Rate-limited at the call site (existing
|
|
* `sendReminderIfAllowed`); this just dispatches the email.
|
|
*
|
|
* - `sendSigningCompleted` — sent to all signers (with the signed
|
|
* PDF attached) when the document reaches fully-signed.
|
|
*
|
|
* The service handles two transformations the templates can't:
|
|
* 1. **Embedded URL wrapping** — raw Documenso signing URLs get
|
|
* rewrapped to `{embeddedSigningHost}/sign/<type>/<token>` so
|
|
* clients sign on a branded page rather than Documenso's domain.
|
|
* 2. **Per-port branding lookup** — fetches the port's branding
|
|
* config (logo, primary color, header/footer HTML) and threads
|
|
* it into the email shell.
|
|
*
|
|
* URL transformation matches the legacy client portal's
|
|
* `createEmbeddedSigningUrl` (extract token from path, prepend
|
|
* configured host + signer-role segment). Falls back to the raw
|
|
* Documenso URL when no `embeddedSigningHost` is configured for the
|
|
* port (single-tenant deploys can keep using Documenso's hosted UI).
|
|
*/
|
|
|
|
import pLimit from 'p-limit';
|
|
|
|
import { sendEmail } from '@/lib/email';
|
|
import { getBrandingShell } from '@/lib/email/branding-resolver';
|
|
import {
|
|
signingCancelledEmail,
|
|
signingCompletedEmail,
|
|
signingInvitationEmail,
|
|
signingReminderEmail,
|
|
} from '@/lib/email/templates/document-signing';
|
|
import { getPortDocumensoConfig } from '@/lib/services/port-config';
|
|
import { extractSigningToken } from '@/lib/services/documenso-signers';
|
|
import { logger } from '@/lib/logger';
|
|
|
|
// ─── Types ───────────────────────────────────────────────────────────────────
|
|
|
|
export type DocumentLabel = 'Expression of Interest' | 'Sales Contract' | 'Reservation Agreement';
|
|
export type SignerRole = 'client' | 'developer' | 'approver' | 'witness' | 'other';
|
|
|
|
export interface SigningInvitationArgs {
|
|
portId: string;
|
|
portName: string;
|
|
/** Recipient who's being asked to sign right now. */
|
|
recipient: { name: string; email: string };
|
|
/** Documenso's raw signing URL (e.g. https://signatures.portnimara.dev/sign/<token>). */
|
|
documensoSigningUrl: string;
|
|
/** Document type — drives subject line and body copy. */
|
|
documentLabel: DocumentLabel;
|
|
/** Signer role — drives copy variant + the embedded URL's role segment. */
|
|
signerRole: SignerRole;
|
|
/** Optional rep-authored note inserted above the CTA. */
|
|
customMessage?: string | null;
|
|
/** Display name for the closing salutation (defaults to "The {portName} team"). */
|
|
senderName?: string | null;
|
|
/** Subject override with template tokens. */
|
|
subjectOverride?: string | null;
|
|
}
|
|
|
|
export interface SigningReminderArgs extends Omit<SigningInvitationArgs, 'signerRole'> {
|
|
signerRole: SignerRole;
|
|
/** Human-readable invitation age, e.g. "3 days ago". */
|
|
invitedAgo: string;
|
|
}
|
|
|
|
export interface SigningCancelledArgs {
|
|
portId: string;
|
|
portName: string;
|
|
/** Recipients to notify of the cancellation. Caller decides who —
|
|
* the rep typically picks a subset of the original signers via the
|
|
* cancel-with-notify modal. Empty list = no emails fire (the
|
|
* Regenerate flow path). */
|
|
recipients: Array<{ name: string; email: string }>;
|
|
documentLabel: DocumentLabel;
|
|
/** Optional rep-authored explanation rendered as a callout. */
|
|
reason?: string | null;
|
|
}
|
|
|
|
export interface SigningCompletedArgs {
|
|
portId: string;
|
|
portName: string;
|
|
/** All signers — each gets the same email + attached signed PDF. */
|
|
recipients: Array<{ name: string; email: string }>;
|
|
/** Display name of the linked client (the deal's primary subject). */
|
|
clientName: string;
|
|
documentLabel: DocumentLabel;
|
|
/** Date all parties had signed. */
|
|
completedAt: Date;
|
|
/**
|
|
* MinIO file ref for the fully-signed PDF (already stored by the
|
|
* webhook handler before this service is called). The send pipeline
|
|
* resolves the ref and attaches the bytes via the existing
|
|
* `resolveAttachments` flow, which also enforces port-isolation.
|
|
*/
|
|
signedPdfFileId: string;
|
|
signedPdfFilename: string;
|
|
}
|
|
|
|
// ─── URL transformation ──────────────────────────────────────────────────────
|
|
|
|
/**
|
|
* Wrap a raw Documenso signing URL into our branded embedded format
|
|
* `{host}/sign/<role>/<token>`. Returns the raw URL unchanged when
|
|
* the port has no `embeddedSigningHost` configured (single-tenant /
|
|
* staging deploys skip the wrap).
|
|
*
|
|
* Example:
|
|
* transformSigningUrl(
|
|
* 'https://signatures.portnimara.dev/sign/abc123',
|
|
* 'https://portnimara.com',
|
|
* 'client',
|
|
* ) → 'https://portnimara.com/sign/client/abc123'
|
|
*/
|
|
/**
|
|
* Map our internal SignerRole to the URL segment expected by the
|
|
* marketing-website signing page (`/sign/<segment>/<token>`). The
|
|
* legacy website only routes `client | cc | developer`; approver +
|
|
* witness + other all funnel through the `cc` page (which renders the
|
|
* same Documenso embed but with passive-recipient copy). See plan
|
|
* Risk #5 — fixing this mapping prevents an `approver` invite from
|
|
* landing on `/sign/error`.
|
|
*/
|
|
const ROLE_TO_URL_SEGMENT: Record<SignerRole, 'client' | 'cc' | 'developer' | 'witness'> = {
|
|
client: 'client',
|
|
developer: 'developer',
|
|
approver: 'cc',
|
|
witness: 'witness',
|
|
other: 'cc',
|
|
};
|
|
|
|
export function transformSigningUrl(
|
|
documensoUrl: string,
|
|
embeddedSigningHost: string | null,
|
|
signerRole: SignerRole,
|
|
): string {
|
|
if (!embeddedSigningHost || !documensoUrl) return documensoUrl;
|
|
// Phase 5: route the URL through the canonical token validator so a
|
|
// bare URL like `https://sig.example.com` doesn't silently produce
|
|
// `<host>/sign/<role>/sig.example.com`. extractSigningToken returns
|
|
// null when the tail isn't token-shaped (≥8 URL-safe chars), at
|
|
// which point we hand back the raw URL untouched.
|
|
const token = extractSigningToken(documensoUrl);
|
|
if (!token) return documensoUrl;
|
|
// Trim trailing slashes off the host so we always produce a clean
|
|
// single `/` between segments.
|
|
const host = embeddedSigningHost.replace(/\/+$/, '');
|
|
const urlRole = ROLE_TO_URL_SEGMENT[signerRole];
|
|
return `${host}/sign/${urlRole}/${token}`;
|
|
}
|
|
|
|
// ─── Senders ─────────────────────────────────────────────────────────────────
|
|
|
|
export async function sendSigningInvitation(args: SigningInvitationArgs): Promise<void> {
|
|
const [docCfg, branding] = await Promise.all([
|
|
getPortDocumensoConfig(args.portId),
|
|
getBrandingShell(args.portId),
|
|
]);
|
|
|
|
const signingUrl = transformSigningUrl(
|
|
args.documensoSigningUrl,
|
|
docCfg.embeddedSigningHost,
|
|
args.signerRole,
|
|
);
|
|
|
|
const { subject, html, text } = await signingInvitationEmail(
|
|
{
|
|
recipientName: args.recipient.name,
|
|
documentLabel: args.documentLabel,
|
|
signerRole: args.signerRole,
|
|
signingUrl,
|
|
portName: args.portName,
|
|
senderName: args.senderName ?? null,
|
|
customMessage: args.customMessage ?? null,
|
|
},
|
|
{
|
|
subject: args.subjectOverride ?? null,
|
|
branding,
|
|
},
|
|
);
|
|
|
|
try {
|
|
await sendEmail(args.recipient.email, subject, html, undefined, text, args.portId);
|
|
logger.info(
|
|
{ portId: args.portId, recipient: args.recipient.email, documentLabel: args.documentLabel },
|
|
'Signing invitation sent',
|
|
);
|
|
} catch (err) {
|
|
logger.error(
|
|
{ err, portId: args.portId, recipient: args.recipient.email },
|
|
'Signing invitation send failed',
|
|
);
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
export async function sendSigningReminder(args: SigningReminderArgs): Promise<void> {
|
|
const [docCfg, branding] = await Promise.all([
|
|
getPortDocumensoConfig(args.portId),
|
|
getBrandingShell(args.portId),
|
|
]);
|
|
|
|
const signingUrl = transformSigningUrl(
|
|
args.documensoSigningUrl,
|
|
docCfg.embeddedSigningHost,
|
|
args.signerRole,
|
|
);
|
|
|
|
const { subject, html, text } = await signingReminderEmail(
|
|
{
|
|
recipientName: args.recipient.name,
|
|
documentLabel: args.documentLabel,
|
|
signingUrl,
|
|
portName: args.portName,
|
|
invitedAgo: args.invitedAgo,
|
|
customMessage: args.customMessage ?? null,
|
|
},
|
|
{
|
|
subject: args.subjectOverride ?? null,
|
|
branding,
|
|
},
|
|
);
|
|
|
|
try {
|
|
await sendEmail(args.recipient.email, subject, html, undefined, text, args.portId);
|
|
logger.info(
|
|
{ portId: args.portId, recipient: args.recipient.email, documentLabel: args.documentLabel },
|
|
'Signing reminder sent',
|
|
);
|
|
} catch (err) {
|
|
logger.error(
|
|
{ err, portId: args.portId, recipient: args.recipient.email },
|
|
'Signing reminder send failed',
|
|
);
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Send the "all signed" completion email with the finalized PDF
|
|
* attached. Sends one email per recipient (rather than a single
|
|
* to-list) so the EMAIL_REDIRECT_TO redirect stays cleanly per-message
|
|
* and so per-recipient personalization in the body works.
|
|
*/
|
|
export async function sendSigningCompleted(args: SigningCompletedArgs): Promise<void> {
|
|
const branding = await getBrandingShell(args.portId);
|
|
|
|
// Cap concurrency at 3: a Sales Contract with 10 recipients (client +
|
|
// 5 sellers + 4 witnesses) shouldn't fan out 10 simultaneous SMTP
|
|
// sends. Most SMTP providers (Mailgun, SES, Postmark) cap concurrent
|
|
// connections in the single digits and silently drop the overflow.
|
|
const sendLimit = pLimit(3);
|
|
|
|
await Promise.all(
|
|
args.recipients.map((recipient) =>
|
|
sendLimit(async () => {
|
|
const { subject, html, text } = await signingCompletedEmail(
|
|
{
|
|
recipientName: recipient.name,
|
|
documentLabel: args.documentLabel,
|
|
clientName: args.clientName,
|
|
portName: args.portName,
|
|
completedAt: args.completedAt,
|
|
},
|
|
{ branding },
|
|
);
|
|
try {
|
|
await sendEmail(recipient.email, subject, html, undefined, text, args.portId, [
|
|
{ fileId: args.signedPdfFileId, filename: args.signedPdfFilename },
|
|
]);
|
|
logger.info(
|
|
{ portId: args.portId, recipient: recipient.email, documentLabel: args.documentLabel },
|
|
'Signing-completed email sent',
|
|
);
|
|
} catch (err) {
|
|
logger.error(
|
|
{ err, portId: args.portId, recipient: recipient.email },
|
|
'Signing-completed email send failed',
|
|
);
|
|
// Don't throw — sending to one recipient shouldn't block the others.
|
|
}
|
|
}),
|
|
),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Notify a subset of signers that an EOI / contract has been cancelled.
|
|
* Called by the cancel-with-notify modal — empty `recipients` is a
|
|
* no-op (the Regenerate path, where the rep wants to silently void).
|
|
*/
|
|
export async function sendSigningCancelled(args: SigningCancelledArgs): Promise<void> {
|
|
if (args.recipients.length === 0) return;
|
|
const branding = await getBrandingShell(args.portId);
|
|
const sendLimit = pLimit(3);
|
|
await Promise.all(
|
|
args.recipients.map((recipient) =>
|
|
sendLimit(async () => {
|
|
const { subject, html, text } = await signingCancelledEmail(
|
|
{
|
|
recipientName: recipient.name,
|
|
documentLabel: args.documentLabel,
|
|
portName: args.portName,
|
|
reason: args.reason ?? null,
|
|
},
|
|
{ branding },
|
|
);
|
|
try {
|
|
await sendEmail(recipient.email, subject, html, undefined, text, args.portId);
|
|
logger.info(
|
|
{ portId: args.portId, recipient: recipient.email, documentLabel: args.documentLabel },
|
|
'Signing-cancelled email sent',
|
|
);
|
|
} catch (err) {
|
|
logger.error(
|
|
{ err, portId: args.portId, recipient: recipient.email },
|
|
'Signing-cancelled email send failed',
|
|
);
|
|
}
|
|
}),
|
|
),
|
|
);
|
|
}
|