Matt
64a488dc15
Two bugs in the marketing-site embed-URL rewrite, both surfaced by testing through the actual invitation emails: 1. Developer invite linked to `…/sign/undefined/<token>`. document_signers persists Documenso's normalized role, so the order-2 EOI developer arrives as 'signer', which ROLE_TO_URL_SEGMENT didn't have — the lookup returned undefined. Add a 'signer' → 'developer' alias and a 'cc' fallback so an unknown role can never emit `/sign/undefined/`. 2. "Copy link" copied the bare Documenso URL, not the branded embed URL. listDocumentSigners (feeds the EOI tab signers + Copy link) now runs each signing_url through transformSigningUrl, so the copied link matches what the invitation email sends. Send-invitation/automation read the raw rows directly, so they're unaffected. Regression tests pin 'signer' → /sign/developer and the unknown-role fallback. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
95 lines
3.6 KiB
TypeScript
95 lines
3.6 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
|
|
import { transformSigningUrl } from '@/lib/services/document-signing-emails.service';
|
|
|
|
/**
|
|
* Phase 5 - pin the URL-wrapping contract.
|
|
*
|
|
* The marketing website at portnimara.com/sign/[type]/[token] expects
|
|
* specific path segments (`client | cc | developer | witness`) and the
|
|
* Documenso webhook returns raw URLs of the form
|
|
* `https://signatures.portnimara.com/sign/<token>`. transformSigningUrl
|
|
* is the seam between the two - these tests guard the role-to-URL-
|
|
* segment mapping so a future refactor can't silently break the
|
|
* embedded signing pages.
|
|
*/
|
|
|
|
const RAW = 'https://signatures.portnimara.com/sign/vbT8hi3jKQmrFP_LN1WcS';
|
|
const HOST = 'https://portnimara.com';
|
|
|
|
describe('transformSigningUrl', () => {
|
|
it('returns raw URL when embeddedSigningHost is null (single-tenant / staging)', () => {
|
|
expect(transformSigningUrl(RAW, null, 'client')).toBe(RAW);
|
|
});
|
|
|
|
it('returns raw URL on empty input', () => {
|
|
expect(transformSigningUrl('', HOST, 'client')).toBe('');
|
|
});
|
|
|
|
it('maps client → /sign/client/<token>', () => {
|
|
expect(transformSigningUrl(RAW, HOST, 'client')).toBe(
|
|
'https://portnimara.com/sign/client/vbT8hi3jKQmrFP_LN1WcS',
|
|
);
|
|
});
|
|
|
|
it('maps developer → /sign/developer/<token>', () => {
|
|
expect(transformSigningUrl(RAW, HOST, 'developer')).toBe(
|
|
'https://portnimara.com/sign/developer/vbT8hi3jKQmrFP_LN1WcS',
|
|
);
|
|
});
|
|
|
|
it('maps approver → /sign/cc/<token> - website only handles {client, cc, developer, witness}', () => {
|
|
expect(transformSigningUrl(RAW, HOST, 'approver')).toBe(
|
|
'https://portnimara.com/sign/cc/vbT8hi3jKQmrFP_LN1WcS',
|
|
);
|
|
});
|
|
|
|
it("maps 'signer' (Documenso's persisted order-2 role) → /sign/developer/<token>", () => {
|
|
// document_signers.signer_role stores Documenso's normalized role, so the
|
|
// EOI developer arrives as 'signer'. Regression: this used to fall through
|
|
// to `undefined` → dead `…/sign/undefined/<token>` invitation links.
|
|
expect(transformSigningUrl(RAW, HOST, 'signer' as never)).toBe(
|
|
'https://portnimara.com/sign/developer/vbT8hi3jKQmrFP_LN1WcS',
|
|
);
|
|
});
|
|
|
|
it('falls back to /sign/cc/<token> for any unrecognised role (never undefined)', () => {
|
|
expect(transformSigningUrl(RAW, HOST, 'mystery-role' as never)).toBe(
|
|
'https://portnimara.com/sign/cc/vbT8hi3jKQmrFP_LN1WcS',
|
|
);
|
|
});
|
|
|
|
it('maps witness → /sign/witness/<token>', () => {
|
|
expect(transformSigningUrl(RAW, HOST, 'witness')).toBe(
|
|
'https://portnimara.com/sign/witness/vbT8hi3jKQmrFP_LN1WcS',
|
|
);
|
|
});
|
|
|
|
it('maps other → /sign/cc/<token> - funnels through CC page with passive copy', () => {
|
|
expect(transformSigningUrl(RAW, HOST, 'other')).toBe(
|
|
'https://portnimara.com/sign/cc/vbT8hi3jKQmrFP_LN1WcS',
|
|
);
|
|
});
|
|
|
|
it('strips trailing slashes from the host so we get a clean single / between segments', () => {
|
|
expect(transformSigningUrl(RAW, 'https://portnimara.com/', 'client')).toBe(
|
|
'https://portnimara.com/sign/client/vbT8hi3jKQmrFP_LN1WcS',
|
|
);
|
|
expect(transformSigningUrl(RAW, 'https://portnimara.com///', 'client')).toBe(
|
|
'https://portnimara.com/sign/client/vbT8hi3jKQmrFP_LN1WcS',
|
|
);
|
|
});
|
|
|
|
it('preserves the token verbatim - no URL encoding / re-shaping', () => {
|
|
const odd = 'https://sig.example.com/sign/Aa_-Zz09_-XYZ';
|
|
expect(transformSigningUrl(odd, HOST, 'developer')).toBe(
|
|
'https://portnimara.com/sign/developer/Aa_-Zz09_-XYZ',
|
|
);
|
|
});
|
|
|
|
it('returns raw URL when the input has no extractable token', () => {
|
|
const bare = 'https://sig.example.com';
|
|
expect(transformSigningUrl(bare, HOST, 'client')).toBe(bare);
|
|
});
|
|
});
|