Massive multi-area push driven by docs/admin-ux-backlog.md. Every byte
path now goes through getStorageBackend() so signed EOIs, contracts,
brochures, berth PDFs, files, avatars, branding logos, and DB backups
all work identically on S3 and filesystem backends.
USER SETTINGS (rebuild)
- Country + Timezone selectors with cross-defaulting
- Browser-detected timezone banner ("Looks like you're in Europe/Paris…")
- Email change with verification flow (user_email_changes table,
OLD-address cancel link + NEW-address confirm link)
+ EMAIL_CHANGE_INSTANT=true dev shortcut
- Password reset triggered via better-auth requestPasswordReset
- Profile photo upload + crop (square 256×256) via shared
<ImageCropperDialog> + /api/v1/me/avatar
BRANDING
- Shared <ImageCropperDialog> using react-easy-crop
- Logo upload + crop in /admin/branding (writes via
/api/v1/admin/settings/image -> storage backend)
- Email header/footer HTML defaults injectable via "Insert default"
- SettingsFormCard new field types: timezone (combobox), image-upload
STORAGE ADMIN OVERHAUL
- S3 config form FIRST, swap action SECOND
- Test connection before any switch
- Two-button switch: "Switch + migrate" vs "Switch only" with
warning modals
- runMigration() honours skipMigration flag
- /api/ready + system-monitoring health check use the active
storage backend instead of always probing MinIO
- Filesystem backend already had full feature parity — verified
BACKUP MANAGEMENT (real)
- New backup_jobs table (id / status / trigger / size / storage_path)
- runBackup() service spawns pg_dump --format=custom, streams to
active storage backend via getStorageBackend().put()
- /admin/backup page: trigger, history, download .dump for restore
- Super-admin gated
AI ADMIN PANEL
- /admin/ai consolidates master switch + monthly token cap +
provider credentials
- Per-feature settings (OCR, berth-PDF parser, recommender)
linked from the same page
ONBOARDING WIZARD
- /admin/onboarding now real with auto-checked steps
- Reads each setting key + lists endpoint (roles/users/tags) to
decide completion
- Manual checkboxes for steps without an auto-detect signal
- Progress bar + Mark done/Mark incomplete buttons
- State persisted in system_settings.onboarding_manual_status
RESIDENTIAL PARITY (full)
- New residential_client_notes + residential_interest_notes tables
(mirror marina-side shape)
- Polymorphic notes.service.ts extended (verifyParent, listForEntity,
create, update, delete) for residential_clients/_interests
- <NotesList> component accepts the new entity types
- 4 new note endpoints (GET/POST/PATCH/DELETE for clients + interests)
- 2 new activity endpoints (residential clients + interests)
- residential-client-tabs.tsx + residential-interest-tabs.tsx use
DetailLayout (Overview / Interests / Notes / Activity)
- residential-client-detail-header.tsx mirrors marina-side strip
- useBreadcrumbHint wired into both detail components
- Configurable Assigned-to dropdown (residential_interests.view perm)
CONFIGURABLE RESIDENTIAL STAGES
- residential-stages.service.ts with list / save / orphan-check
- /api/v1/residential/stages GET/PUT
- /admin/residential-stages admin UI with reassign-on-remove modal
- Validators relaxed from z.enum to z.string
DOCUMENSO PHASE 1
- Schema: document_signers.invited_at / opened_at /
last_reminder_sent_at / signing_token (+ idx_ds_signing_token)
- Schema: documents.completion_cc_emails (text[]) +
auto_reminder_interval_days (int)
- transformSigningUrl() now maps SignerRole -> URL segment via
ROLE_TO_URL_SEGMENT (approver->cc, witness->witness) — fixes
Risk #5 where approver invites landed on /sign/error
- POST /api/v1/documents/[id]/send-invitation with auto-pick of
next pending signer
- Per-port settings: documenso_developer_label / _approver_label
+ documenso_developer_user_id / _approver_user_id (Phase 7
Project Director RBAC binding fields)
ADMIN UX RAPID-FIRE
- Sidebar collapse removed (always-expanded design)
- Audit log: input sizes (h-9), date pickers w-44, action cell
sub-label so single-row entries aren't blank
- Sales email config: token list <details> + tooltips on
threshold + body fields
- Custom Settings card: long-form description
- Reminder digest timezone uses TimezoneCombobox
- Port form: currency dropdown (10 common currencies) + timezone
combobox + brand color picker
- Permissions count badge opens modal with granted/denied per
resource
- Role names display-normalized via prettifyRoleName
- Tag form: native input type=color
- Custom Fields page: amber heads-up about non-integration
- Settings manager: select field type + fallthrough_policy as dropdown
- Storage admin S3 fields ship as proper password + boolean
LIST PAGES
- Residential client list: clickable email/phone (mailto/tel/wa.me)
- Residential interests + Documents Hub search inputs sized h-9
CURRENCY API
- scripts/test-currency-api.ts verifies live Frankfurter fetch
-> DB upsert -> getRate -> convert. Inverse-rate drift <=0.001
TESTS
- 1185/1185 vitest passing
- tsc clean
- eslint 0 errors (16 pre-existing warnings)
Note: WEBSITE_INTAKE_SECRET added to .env.example but committed
separately due to pre-commit hook policy on .env* files.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
283 lines
9.0 KiB
TypeScript
283 lines
9.0 KiB
TypeScript
'use client';
|
|
|
|
import { useState, useEffect, useCallback } from 'react';
|
|
import { type ColumnDef } from '@tanstack/react-table';
|
|
import { Pencil, Trash2, Plus, Lock } from 'lucide-react';
|
|
|
|
import { DataTable } from '@/components/shared/data-table';
|
|
import { PageHeader } from '@/components/shared/page-header';
|
|
import { ConfirmationDialog } from '@/components/shared/confirmation-dialog';
|
|
import { Button } from '@/components/ui/button';
|
|
import { Badge } from '@/components/ui/badge';
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogDescription,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
} from '@/components/ui/dialog';
|
|
import { apiFetch } from '@/lib/api/client';
|
|
import { RoleForm } from './role-form';
|
|
|
|
/**
|
|
* Display-normalize a stored role name. Roles are stored with whatever
|
|
* key the admin entered (snake_case, kebab-case, free text). For UI
|
|
* display we titlecase + space-separate so "super_admin" reads as
|
|
* "Super Admin" and "Some role!" reads as "Some Role!" Display-only —
|
|
* code paths that compare role names use the stored verbatim value.
|
|
*/
|
|
function prettifyRoleName(name: string): string {
|
|
return name
|
|
.replace(/[_-]+/g, ' ')
|
|
.replace(/\s+/g, ' ')
|
|
.trim()
|
|
.replace(/\b\w/g, (c) => c.toUpperCase());
|
|
}
|
|
|
|
interface Role {
|
|
id: string;
|
|
name: string;
|
|
description: string | null;
|
|
isSystem: boolean;
|
|
isGlobal: boolean;
|
|
permissions: Record<string, Record<string, boolean>>;
|
|
createdAt: string;
|
|
}
|
|
|
|
export function RoleList() {
|
|
const [roles, setRoles] = useState<Role[]>([]);
|
|
const [loading, setLoading] = useState(true);
|
|
const [formOpen, setFormOpen] = useState(false);
|
|
const [editingRole, setEditingRole] = useState<Role | null>(null);
|
|
const [deletingId, setDeletingId] = useState<string | null>(null);
|
|
const [viewingPermissions, setViewingPermissions] = useState<Role | null>(null);
|
|
|
|
const fetchRoles = useCallback(async () => {
|
|
setLoading(true);
|
|
try {
|
|
const res = await apiFetch<{ data: Role[] }>('/api/v1/admin/roles');
|
|
setRoles(res.data);
|
|
} finally {
|
|
setLoading(false);
|
|
}
|
|
}, []);
|
|
|
|
useEffect(() => {
|
|
void fetchRoles();
|
|
}, [fetchRoles]);
|
|
|
|
function handleNewRole() {
|
|
setEditingRole(null);
|
|
setFormOpen(true);
|
|
}
|
|
|
|
function handleEditRole(role: Role) {
|
|
setEditingRole(role);
|
|
setFormOpen(true);
|
|
}
|
|
|
|
async function handleDeleteRole(id: string) {
|
|
setDeletingId(id);
|
|
try {
|
|
await apiFetch(`/api/v1/admin/roles/${id}`, { method: 'DELETE' });
|
|
await fetchRoles();
|
|
} finally {
|
|
setDeletingId(null);
|
|
}
|
|
}
|
|
|
|
function countPermissions(perms: Record<string, Record<string, boolean>>): string {
|
|
let granted = 0;
|
|
let total = 0;
|
|
for (const group of Object.values(perms)) {
|
|
for (const val of Object.values(group)) {
|
|
total++;
|
|
if (val) granted++;
|
|
}
|
|
}
|
|
return `${granted}/${total}`;
|
|
}
|
|
|
|
const columns: ColumnDef<Role, unknown>[] = [
|
|
{
|
|
accessorKey: 'name',
|
|
header: 'Name',
|
|
cell: ({ row }) => (
|
|
<div className="flex items-center gap-2">
|
|
{/* Display-normalize: snake_case → "Snake Case" so admin-
|
|
created roles with arbitrary keys still read cleanly.
|
|
The underlying name is stored verbatim and is what code
|
|
checks against — display is purely cosmetic. */}
|
|
<span className="font-medium">{prettifyRoleName(row.original.name)}</span>
|
|
{row.original.isSystem && (
|
|
<Badge variant="outline" className="text-xs">
|
|
<Lock className="mr-1 h-3 w-3" />
|
|
System
|
|
</Badge>
|
|
)}
|
|
</div>
|
|
),
|
|
},
|
|
{
|
|
accessorKey: 'description',
|
|
header: 'Description',
|
|
cell: ({ row }) => (
|
|
<span className="text-muted-foreground text-sm">{row.original.description ?? '-'}</span>
|
|
),
|
|
},
|
|
{
|
|
id: 'permissions',
|
|
header: 'Permissions',
|
|
cell: ({ row }) => (
|
|
<button
|
|
type="button"
|
|
onClick={() => setViewingPermissions(row.original)}
|
|
className="inline-flex"
|
|
title="View permission breakdown"
|
|
>
|
|
<Badge
|
|
variant="secondary"
|
|
className="cursor-pointer hover:bg-secondary/80 transition-colors"
|
|
>
|
|
{countPermissions(row.original.permissions)}
|
|
</Badge>
|
|
</button>
|
|
),
|
|
},
|
|
{
|
|
id: 'actions',
|
|
header: '',
|
|
cell: ({ row }) => (
|
|
<div className="flex items-center justify-end gap-1">
|
|
<Button variant="ghost" size="sm" onClick={() => handleEditRole(row.original)}>
|
|
<Pencil className="h-4 w-4" />
|
|
<span className="sr-only">Edit</span>
|
|
</Button>
|
|
{!row.original.isSystem && (
|
|
<ConfirmationDialog
|
|
trigger={
|
|
<Button
|
|
variant="ghost"
|
|
size="sm"
|
|
className="text-destructive hover:text-destructive"
|
|
>
|
|
<Trash2 className="h-4 w-4" />
|
|
<span className="sr-only">Delete</span>
|
|
</Button>
|
|
}
|
|
title="Delete Role"
|
|
description={`Delete "${row.original.name}"? Users assigned to this role must be reassigned first.`}
|
|
confirmLabel="Delete"
|
|
onConfirm={() => handleDeleteRole(row.original.id)}
|
|
loading={deletingId === row.original.id}
|
|
/>
|
|
)}
|
|
</div>
|
|
),
|
|
enableSorting: false,
|
|
size: 80,
|
|
},
|
|
];
|
|
|
|
return (
|
|
<div>
|
|
<PageHeader
|
|
title="Role Management"
|
|
description="Manage roles and their permissions"
|
|
actions={
|
|
<Button onClick={handleNewRole}>
|
|
<Plus className="mr-1.5 h-4 w-4" />
|
|
New Role
|
|
</Button>
|
|
}
|
|
/>
|
|
|
|
<DataTable
|
|
columns={columns}
|
|
data={roles}
|
|
isLoading={loading}
|
|
getRowId={(row) => row.id}
|
|
emptyState={
|
|
<div className="text-center py-8">
|
|
<p className="text-muted-foreground">No roles defined.</p>
|
|
</div>
|
|
}
|
|
/>
|
|
|
|
<RoleForm
|
|
open={formOpen}
|
|
onOpenChange={setFormOpen}
|
|
role={editingRole}
|
|
onSuccess={fetchRoles}
|
|
/>
|
|
|
|
{/* Permissions inspector — opens when admin clicks the count
|
|
badge in the table. Lists granted vs denied per resource so
|
|
they can spot gaps before opening the editor. */}
|
|
<Dialog open={!!viewingPermissions} onOpenChange={(o) => !o && setViewingPermissions(null)}>
|
|
<DialogContent className="max-w-2xl max-h-[80vh] overflow-y-auto">
|
|
<DialogHeader>
|
|
<DialogTitle>
|
|
Permissions — {viewingPermissions ? prettifyRoleName(viewingPermissions.name) : ''}
|
|
</DialogTitle>
|
|
<DialogDescription>
|
|
Granted vs total per resource. Click Edit to change.
|
|
</DialogDescription>
|
|
</DialogHeader>
|
|
{viewingPermissions && (
|
|
<div className="space-y-3">
|
|
{Object.entries(viewingPermissions.permissions).map(([resource, actions]) => {
|
|
const granted = Object.values(actions).filter(Boolean).length;
|
|
const total = Object.keys(actions).length;
|
|
return (
|
|
<div key={resource} className="rounded-md border px-3 py-2">
|
|
<div className="flex items-center justify-between mb-1.5">
|
|
<span className="text-sm font-medium capitalize">
|
|
{resource.replace(/_/g, ' ')}
|
|
</span>
|
|
<Badge variant="secondary" className="text-xs">
|
|
{granted}/{total}
|
|
</Badge>
|
|
</div>
|
|
<div className="flex flex-wrap gap-1.5">
|
|
{Object.entries(actions).map(([action, allowed]) => (
|
|
<span
|
|
key={action}
|
|
className={
|
|
allowed
|
|
? 'inline-flex items-center rounded-full bg-emerald-50 text-emerald-900 px-2 py-0.5 text-[11px] font-medium'
|
|
: 'inline-flex items-center rounded-full bg-muted text-muted-foreground px-2 py-0.5 text-[11px] font-medium line-through opacity-60'
|
|
}
|
|
>
|
|
{action.replace(/_/g, ' ')}
|
|
</span>
|
|
))}
|
|
</div>
|
|
</div>
|
|
);
|
|
})}
|
|
</div>
|
|
)}
|
|
<DialogFooter>
|
|
<Button variant="outline" onClick={() => setViewingPermissions(null)}>
|
|
Close
|
|
</Button>
|
|
{viewingPermissions && (
|
|
<Button
|
|
onClick={() => {
|
|
const role = viewingPermissions;
|
|
setViewingPermissions(null);
|
|
handleEditRole(role);
|
|
}}
|
|
>
|
|
Edit
|
|
</Button>
|
|
)}
|
|
</DialogFooter>
|
|
</DialogContent>
|
|
</Dialog>
|
|
</div>
|
|
);
|
|
}
|