Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).
CRITICAL (3):
- C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
no longer silently drop interest links
- C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
- C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
callers must go through /stage with the override-guard chain
HIGH (14/15):
- H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
interests/documents/reservations/reminders/invoices (migration 0070)
- H-02 login page reads ?redirect= param with same-origin guard
- H-03 CRM invite token moves to URL fragment so it never lands in
nginx access logs / Referer headers
- H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
- H-05 toggleAccount writes an audit row
- H-06 upsertSetting masks any value whose key ends with _encrypted
- H-07 archiveClient cascade fires per-interest audit rows
- H-08 createSalesTransporter applies SMTP_TIMEOUTS
- H-09 AppShell stable children — viewport flip across breakpoint no
longer destroys in-progress form drafts
- H-10 portal documents page swaps Unicode glyph status icons for
Lucide CheckCircle2/XCircle/Circle + aria-labels
- H-12 list components swap alert(...) for toast.warning(...)
- H-13 5 icon-only buttons gain aria-label
- H-14 parseBody treats empty bodies as {}
- H-15 admin layout renders a 403 panel instead of silent bounce
- H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet
MEDIUM (28+):
- M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
WHEREs across custom-fields, notes (all 6 entity types x update +
delete), client-contacts, yacht ownerClient lookup, webhook reads
- M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
- M-EM01 portal-auth emails thread through portId
- M-EM02 sendEmail accepts cc/bcc params
- M-EM04 notification_digest catalog key
- M-IN01 portal presigned download URLs use 4h TTL
- M-IN02 OpenAI client lazy-instantiated
- M-IN04 stale pdfme refs updated to pdf-lib AcroForm
- M-IN05 umami.testConnection returns tagged union
- M-L01 reservations tenure_type unified with berths
- M-L02 report-generators canonicalize stage values
- M-AU01 audit log placeholder copy fixed
- M-AU04 outcome_set / outcome_cleared distinct audit verbs
- M-NEW-2 activity feed entity name+type separator
- M-R01 portal allowlist narrowed + portal_session backstop in proxy
- M-SC02 companies archived partial index
- M-SC04 audit_logs.searchText documented as DB-managed
- M-S01 storage_s3_access_key_encrypted admin field
- M-U01 audit log empty state uses <EmptyState>
- M-U09 invoice delete dialog -> <AlertDialog>
- M-U10 toast.success on ClientForm + InterestForm create/edit
- M-U11 settings-form-card logo preview alt text
- M-U14 mobile topbar title on clients/yachts/interests/berths
- M-U15 Invoices in mobile More-sheet
LOW (6/8):
- L-AU01 severity defaults for security-relevant verbs
- L-AU02 +13 missing actions in admin audit filter
- L-AU03 +7 missing entity types in admin audit filter
- L-AU04 dead listAuditLogs stubbed
- L-D02 CLAUDE.md Owner-wins chain tightened
Bonus — Document detail polish (#67 partial, 3/6 deliverables):
- state-aware action button per signer
- watcher Add UI with display-name resolution
- cleanSignerName cleanup
Prior session work bundled in:
- Documenso v2 webhook + envelope-ID normalization + sequential signing
- SigningProgress UI redesign (avatars, per-signer state, timestamps)
- env->admin settings registry + RegistryDrivenForm + encrypted creds
- Embedded-signing card + Test connection + setup help
- Dev-mode EMAIL_REDIRECT_TO banner
- Pipeline rules admin page
- Sales email config card
- Audit log details Sheet
- EOI tab: Finalising badge, absolute timestamps, sequential indicator
- Notes pipeline_stage_at_creation (migration 0069)
- Documenso numeric ID dual-key webhook (migration 0068)
- Dimensions criterion copy (migration 0067)
Tests: 1374/1374 vitest pass. tsc clean. lint clean.
See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
176 lines
6.7 KiB
TypeScript
176 lines
6.7 KiB
TypeScript
'use client';
|
|
|
|
import { useEffect } from 'react';
|
|
import Link from 'next/link';
|
|
import { useRouter, useParams } from 'next/navigation';
|
|
import { Anchor, Plus } from 'lucide-react';
|
|
|
|
import { useMobileChrome } from '@/components/layout/mobile/mobile-layout-provider';
|
|
import { DataTable } from '@/components/shared/data-table';
|
|
import { FilterBar } from '@/components/shared/filter-bar';
|
|
import { PageHeader } from '@/components/shared/page-header';
|
|
import { SavedViewsDropdown } from '@/components/shared/saved-views-dropdown';
|
|
import { ColumnPicker } from '@/components/shared/column-picker';
|
|
import { Button } from '@/components/ui/button';
|
|
import { Input } from '@/components/ui/input';
|
|
import { EmptyState } from '@/components/shared/empty-state';
|
|
import { usePaginatedQuery } from '@/hooks/use-paginated-query';
|
|
import { usePermissions } from '@/hooks/use-permissions';
|
|
import { useRealtimeInvalidation } from '@/hooks/use-realtime-invalidation';
|
|
import { useTablePreferences } from '@/hooks/use-table-preferences';
|
|
import { BerthCard } from './berth-card';
|
|
import {
|
|
berthColumns,
|
|
BERTH_COLUMN_OPTIONS,
|
|
BERTH_DEFAULT_HIDDEN,
|
|
type BerthRow,
|
|
} from './berth-columns';
|
|
import { berthFilterDefinitions } from './berth-filters';
|
|
import { mooringLetterTone } from './mooring-letter-tone';
|
|
|
|
export function BerthList() {
|
|
const router = useRouter();
|
|
const params = useParams<{ portSlug: string }>();
|
|
// M-U14: surface the page title in the mobile topbar.
|
|
const { setChrome } = useMobileChrome();
|
|
useEffect(() => {
|
|
setChrome({ title: 'Berths', showBackButton: false });
|
|
return () => setChrome({ title: null, showBackButton: false });
|
|
}, [setChrome]);
|
|
// F13: bulk-add wizard had no UI entry point. Gate the CTA on
|
|
// `berths.import` (the existing permission used for adding berths)
|
|
// so non-admins don't see a button that 403s on click.
|
|
const { can } = usePermissions();
|
|
const canBulkAdd = can('berths', 'import');
|
|
|
|
const {
|
|
data,
|
|
pagination,
|
|
isLoading,
|
|
sort,
|
|
setSort,
|
|
filters,
|
|
setFilter,
|
|
setAllFilters,
|
|
clearFilters,
|
|
setPage,
|
|
setPageSize,
|
|
} = usePaginatedQuery<BerthRow>({
|
|
queryKey: ['berths'],
|
|
endpoint: '/api/v1/berths',
|
|
filterDefinitions: berthFilterDefinitions,
|
|
});
|
|
|
|
useRealtimeInvalidation({
|
|
'berth:updated': [['berths']],
|
|
'berth:statusChanged': [['berths']],
|
|
});
|
|
|
|
// Persisted column visibility — same pattern as ClientList / InterestList.
|
|
const { hidden, setHidden } = useTablePreferences('berths', BERTH_DEFAULT_HIDDEN);
|
|
const columnVisibility = Object.fromEntries(hidden.map((id) => [id, false]));
|
|
|
|
return (
|
|
<div className="space-y-6">
|
|
<PageHeader
|
|
title="Berths"
|
|
description="View and manage berth allocations"
|
|
variant="gradient"
|
|
// No "New" button - berths are import-only
|
|
/>
|
|
|
|
{/* Toolbar — two halves separated by `justify-between` so the
|
|
Columns + Saved-views actions stay pinned to the right edge of
|
|
the row at every width. The previous `ml-auto` trick didn't
|
|
survive flex-wrap on intermediate widths — the actions ended
|
|
up centered. */}
|
|
<div className="flex items-center gap-2 flex-wrap justify-between">
|
|
<div className="flex items-center gap-2 flex-wrap min-w-0 flex-1">
|
|
<FilterBar
|
|
// Search is hoisted out of the popover into the inline input
|
|
// below — keeps the daily "find by mooring/area" lookup one
|
|
// tap away instead of buried behind the Filters dropdown.
|
|
filters={berthFilterDefinitions.filter((d) => d.key !== 'search')}
|
|
values={filters}
|
|
onChange={setFilter}
|
|
onClear={clearFilters}
|
|
/>
|
|
<Input
|
|
type="search"
|
|
inputMode="search"
|
|
placeholder="Search mooring or area…"
|
|
aria-label="Search berths"
|
|
value={(filters.search as string | undefined) ?? ''}
|
|
onChange={(e) => setFilter('search', e.target.value || undefined)}
|
|
className="h-8 min-w-0 flex-1 sm:max-w-xs"
|
|
/>
|
|
</div>
|
|
<div className="flex items-center gap-2 ml-auto">
|
|
<SavedViewsDropdown
|
|
entityType="berths"
|
|
onApplyView={(savedFilters, _savedSort) => {
|
|
setAllFilters(savedFilters);
|
|
}}
|
|
/>
|
|
<ColumnPicker columns={BERTH_COLUMN_OPTIONS} hidden={hidden} onChange={setHidden} />
|
|
{canBulkAdd && (
|
|
<Button asChild size="sm" variant="default">
|
|
<Link href={`/${params.portSlug}/admin/berths/bulk-add`}>
|
|
<Plus className="h-4 w-4" />
|
|
<span className="hidden sm:inline">Bulk add</span>
|
|
</Link>
|
|
</Button>
|
|
)}
|
|
</div>
|
|
</div>
|
|
|
|
<DataTable<BerthRow>
|
|
columns={berthColumns}
|
|
columnVisibility={columnVisibility}
|
|
data={data}
|
|
isLoading={isLoading}
|
|
pagination={{
|
|
page: pagination.page,
|
|
pageSize: pagination.pageSize,
|
|
total: pagination.total,
|
|
totalPages: pagination.totalPages,
|
|
}}
|
|
onPaginationChange={(page, pageSize) => {
|
|
setPage(page);
|
|
setPageSize(pageSize);
|
|
}}
|
|
sort={sort}
|
|
onSortChange={setSort}
|
|
getRowId={(row) => row.id}
|
|
onRowClick={(row) => router.push(`/${params.portSlug}/berths/${row.id}`)}
|
|
getRowClassName={(row) => mooringLetterTone(row.mooringNumber)}
|
|
cardRender={(row) => <BerthCard berth={row.original} />}
|
|
// Group adjacent cards by dock letter (area) on mobile — adds a
|
|
// dim divider + uppercased label above the first card of each
|
|
// group. Data is already sorted by mooringNumber (A1, A2, …, B1,
|
|
// B2, …) so consecutive rows naturally share dock letters.
|
|
mobileGroupBy={(row) => row.area ?? 'Unassigned'}
|
|
emptyState={
|
|
// Distinguish "no data at all" (fresh port, run the importer)
|
|
// from "no rows after filtering" (adjust filters). The original
|
|
// copy implied data existed but was hidden, which misled fresh-
|
|
// port admins for whom there is literally nothing yet.
|
|
Object.values(filters).every((v) => v === undefined || v === '') ? (
|
|
<EmptyState
|
|
icon={Anchor}
|
|
title="No berths yet"
|
|
description="Berths are imported from external sources. Run the importer once the source data is ready: pnpm tsx scripts/import-berths-from-nocodb.ts --apply --port-slug <slug>."
|
|
/>
|
|
) : (
|
|
<EmptyState
|
|
icon={Anchor}
|
|
title="No berths match these filters"
|
|
description="Adjust your filters or clear them to see every berth."
|
|
/>
|
|
)
|
|
}
|
|
/>
|
|
</div>
|
|
);
|
|
}
|