Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).
CRITICAL (3):
- C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
no longer silently drop interest links
- C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
- C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
callers must go through /stage with the override-guard chain
HIGH (14/15):
- H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
interests/documents/reservations/reminders/invoices (migration 0070)
- H-02 login page reads ?redirect= param with same-origin guard
- H-03 CRM invite token moves to URL fragment so it never lands in
nginx access logs / Referer headers
- H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
- H-05 toggleAccount writes an audit row
- H-06 upsertSetting masks any value whose key ends with _encrypted
- H-07 archiveClient cascade fires per-interest audit rows
- H-08 createSalesTransporter applies SMTP_TIMEOUTS
- H-09 AppShell stable children — viewport flip across breakpoint no
longer destroys in-progress form drafts
- H-10 portal documents page swaps Unicode glyph status icons for
Lucide CheckCircle2/XCircle/Circle + aria-labels
- H-12 list components swap alert(...) for toast.warning(...)
- H-13 5 icon-only buttons gain aria-label
- H-14 parseBody treats empty bodies as {}
- H-15 admin layout renders a 403 panel instead of silent bounce
- H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet
MEDIUM (28+):
- M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
WHEREs across custom-fields, notes (all 6 entity types x update +
delete), client-contacts, yacht ownerClient lookup, webhook reads
- M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
- M-EM01 portal-auth emails thread through portId
- M-EM02 sendEmail accepts cc/bcc params
- M-EM04 notification_digest catalog key
- M-IN01 portal presigned download URLs use 4h TTL
- M-IN02 OpenAI client lazy-instantiated
- M-IN04 stale pdfme refs updated to pdf-lib AcroForm
- M-IN05 umami.testConnection returns tagged union
- M-L01 reservations tenure_type unified with berths
- M-L02 report-generators canonicalize stage values
- M-AU01 audit log placeholder copy fixed
- M-AU04 outcome_set / outcome_cleared distinct audit verbs
- M-NEW-2 activity feed entity name+type separator
- M-R01 portal allowlist narrowed + portal_session backstop in proxy
- M-SC02 companies archived partial index
- M-SC04 audit_logs.searchText documented as DB-managed
- M-S01 storage_s3_access_key_encrypted admin field
- M-U01 audit log empty state uses <EmptyState>
- M-U09 invoice delete dialog -> <AlertDialog>
- M-U10 toast.success on ClientForm + InterestForm create/edit
- M-U11 settings-form-card logo preview alt text
- M-U14 mobile topbar title on clients/yachts/interests/berths
- M-U15 Invoices in mobile More-sheet
LOW (6/8):
- L-AU01 severity defaults for security-relevant verbs
- L-AU02 +13 missing actions in admin audit filter
- L-AU03 +7 missing entity types in admin audit filter
- L-AU04 dead listAuditLogs stubbed
- L-D02 CLAUDE.md Owner-wins chain tightened
Bonus — Document detail polish (#67 partial, 3/6 deliverables):
- state-aware action button per signer
- watcher Add UI with display-name resolution
- cleanSignerName cleanup
Prior session work bundled in:
- Documenso v2 webhook + envelope-ID normalization + sequential signing
- SigningProgress UI redesign (avatars, per-signer state, timestamps)
- env->admin settings registry + RegistryDrivenForm + encrypted creds
- Embedded-signing card + Test connection + setup help
- Dev-mode EMAIL_REDIRECT_TO banner
- Pipeline rules admin page
- Sales email config card
- Audit log details Sheet
- EOI tab: Finalising badge, absolute timestamps, sequential indicator
- Notes pipeline_stage_at_creation (migration 0069)
- Documenso numeric ID dual-key webhook (migration 0068)
- Dimensions criterion copy (migration 0067)
Tests: 1374/1374 vitest pass. tsc clean. lint clean.
See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
86 lines
3.2 KiB
TypeScript
86 lines
3.2 KiB
TypeScript
import { and, eq, inArray, isNotNull } from 'drizzle-orm';
|
|
|
|
import { db } from '@/lib/db';
|
|
import { documents, documentSigners } from '@/lib/db/schema/documents';
|
|
import { getDocument as getDocumensoDoc } from '@/lib/services/documenso-client';
|
|
import {
|
|
handleRecipientSigned,
|
|
handleDocumentCompleted,
|
|
handleDocumentExpired,
|
|
} from '@/lib/services/documents.service';
|
|
import { logger } from '@/lib/logger';
|
|
|
|
export async function processDocumensoPoll(): Promise<void> {
|
|
// Find all documents that are in-progress signing and have a documensoId
|
|
const pendingDocs = await db.query.documents.findMany({
|
|
where: and(
|
|
inArray(documents.status, ['sent', 'partially_signed']),
|
|
isNotNull(documents.documensoId),
|
|
),
|
|
});
|
|
|
|
if (pendingDocs.length === 0) return;
|
|
|
|
logger.info({ count: pendingDocs.length }, 'Polling Documenso for document statuses');
|
|
|
|
for (const doc of pendingDocs) {
|
|
if (!doc.documensoId) continue;
|
|
|
|
try {
|
|
// Pass the doc's portId so the client uses per-port credentials
|
|
// (admin-set Documenso URL/key/version), not the global env fallback.
|
|
// Without portId a multi-port deployment hits the wrong instance and
|
|
// 401s every poll.
|
|
const remoteDoc = await getDocumensoDoc(doc.documensoId, doc.portId);
|
|
|
|
// Reconcile signer statuses
|
|
for (const remoteRecipient of remoteDoc.recipients) {
|
|
if (remoteRecipient.status === 'SIGNED') {
|
|
// Check if we already have this signer as signed locally
|
|
const localSigner = await db.query.documentSigners.findFirst({
|
|
where: and(
|
|
eq(documentSigners.documentId, doc.id),
|
|
eq(documentSigners.signerEmail, remoteRecipient.email),
|
|
),
|
|
});
|
|
|
|
if (localSigner && localSigner.status !== 'signed') {
|
|
logger.info(
|
|
{ documentId: doc.id, email: remoteRecipient.email, portId: doc.portId },
|
|
'Reconciling signed signer from poll',
|
|
);
|
|
// Thread portId from the workflow's port context so the webhook
|
|
// handlers run port-scoped lookups (resolveWebhookDocument) rather
|
|
// than the port-ambiguous fallback.
|
|
await handleRecipientSigned({
|
|
documentId: doc.documensoId,
|
|
recipientEmail: remoteRecipient.email,
|
|
portId: doc.portId,
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
// Reconcile document status
|
|
if (remoteDoc.status === 'COMPLETED' && doc.status !== 'completed') {
|
|
logger.info(
|
|
{ documentId: doc.id, portId: doc.portId },
|
|
'Reconciling completed document from poll',
|
|
);
|
|
await handleDocumentCompleted({ documentId: doc.documensoId, portId: doc.portId });
|
|
} else if (remoteDoc.status === 'EXPIRED' && doc.status !== 'expired') {
|
|
logger.info(
|
|
{ documentId: doc.id, portId: doc.portId },
|
|
'Reconciling expired document from poll',
|
|
);
|
|
await handleDocumentExpired({ documentId: doc.documensoId, portId: doc.portId });
|
|
}
|
|
} catch (err) {
|
|
logger.error(
|
|
{ err, documentId: doc.id, documensoId: doc.documensoId },
|
|
'Documenso poll failed for document',
|
|
);
|
|
}
|
|
}
|
|
}
|