Files

Matt 4b5f85cb7d fix(audit): comprehensive 2026-05-15 audit fix wave + Documenso v2 polish

Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).

CRITICAL (3):
 - C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
   no longer silently drop interest links
 - C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
 - C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
   callers must go through /stage with the override-guard chain

HIGH (14/15):
 - H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
   interests/documents/reservations/reminders/invoices (migration 0070)
 - H-02 login page reads ?redirect= param with same-origin guard
 - H-03 CRM invite token moves to URL fragment so it never lands in
   nginx access logs / Referer headers
 - H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
 - H-05 toggleAccount writes an audit row
 - H-06 upsertSetting masks any value whose key ends with _encrypted
 - H-07 archiveClient cascade fires per-interest audit rows
 - H-08 createSalesTransporter applies SMTP_TIMEOUTS
 - H-09 AppShell stable children — viewport flip across breakpoint no
   longer destroys in-progress form drafts
 - H-10 portal documents page swaps Unicode glyph status icons for
   Lucide CheckCircle2/XCircle/Circle + aria-labels
 - H-12 list components swap alert(...) for toast.warning(...)
 - H-13 5 icon-only buttons gain aria-label
 - H-14 parseBody treats empty bodies as {}
 - H-15 admin layout renders a 403 panel instead of silent bounce
 - H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet

MEDIUM (28+):
 - M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
   WHEREs across custom-fields, notes (all 6 entity types x update +
   delete), client-contacts, yacht ownerClient lookup, webhook reads
 - M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
 - M-EM01 portal-auth emails thread through portId
 - M-EM02 sendEmail accepts cc/bcc params
 - M-EM04 notification_digest catalog key
 - M-IN01 portal presigned download URLs use 4h TTL
 - M-IN02 OpenAI client lazy-instantiated
 - M-IN04 stale pdfme refs updated to pdf-lib AcroForm
 - M-IN05 umami.testConnection returns tagged union
 - M-L01 reservations tenure_type unified with berths
 - M-L02 report-generators canonicalize stage values
 - M-AU01 audit log placeholder copy fixed
 - M-AU04 outcome_set / outcome_cleared distinct audit verbs
 - M-NEW-2 activity feed entity name+type separator
 - M-R01 portal allowlist narrowed + portal_session backstop in proxy
 - M-SC02 companies archived partial index
 - M-SC04 audit_logs.searchText documented as DB-managed
 - M-S01 storage_s3_access_key_encrypted admin field
 - M-U01 audit log empty state uses <EmptyState>
 - M-U09 invoice delete dialog -> <AlertDialog>
 - M-U10 toast.success on ClientForm + InterestForm create/edit
 - M-U11 settings-form-card logo preview alt text
 - M-U14 mobile topbar title on clients/yachts/interests/berths
 - M-U15 Invoices in mobile More-sheet

LOW (6/8):
 - L-AU01 severity defaults for security-relevant verbs
 - L-AU02 +13 missing actions in admin audit filter
 - L-AU03 +7 missing entity types in admin audit filter
 - L-AU04 dead listAuditLogs stubbed
 - L-D02 CLAUDE.md Owner-wins chain tightened

Bonus — Document detail polish (#67 partial, 3/6 deliverables):
 - state-aware action button per signer
 - watcher Add UI with display-name resolution
 - cleanSignerName cleanup

Prior session work bundled in:
 - Documenso v2 webhook + envelope-ID normalization + sequential signing
 - SigningProgress UI redesign (avatars, per-signer state, timestamps)
 - env->admin settings registry + RegistryDrivenForm + encrypted creds
 - Embedded-signing card + Test connection + setup help
 - Dev-mode EMAIL_REDIRECT_TO banner
 - Pipeline rules admin page
 - Sales email config card
 - Audit log details Sheet
 - EOI tab: Finalising badge, absolute timestamps, sequential indicator
 - Notes pipeline_stage_at_creation (migration 0069)
 - Documenso numeric ID dual-key webhook (migration 0068)
 - Dimensions criterion copy (migration 0067)

Tests: 1374/1374 vitest pass. tsc clean. lint clean.

See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-18 13:28:50 +02:00

4.8 KiB

Raw Blame History

Documents/Files Audit (D-01-22) — agent #5

Headline: Structurally solid across all 22 checks. One medium real-time event mismatch + 2 low documentation divergences.

Counts: 0 critical · 0 high · 1 medium · 2 low · 19 passing

🟡 MEDIUM D-01/02/03: Real-time invalidation event name mismatch after upload

File: src/components/documents/documents-hub.tsx:141
What: Hub subscribes to 'file:created': [['files']], but emitter (files.ts:128) and socket-events type def (events.ts:264) use 'file:uploaded'.
Why it matters: After remote upload (other session, webhook auto-deposit), hub Files sections don't auto-refresh. Local FolderDropZone upload bypasses this via direct queryClient.invalidateQueries, but remote uploads invisible until reload.
Suggested fix: Change line 141 to 'file:uploaded': [['files']] to match client-files-tab.tsx:32, company-files-tab.tsx:32, interest-documents-tab.tsx:62.

🟢 LOW D-13: HubRootView has 2 sections, not 3

File: src/components/documents/hub-root-view.tsx:50-100
What: Spec says 3 cards; component renders 2 ("Signing in progress" + "Recent files"). Doc-only.
Suggested fix: Update CLAUDE.md to "2 sections."

🟢 LOW D-16: `interest.yachtId` branch in chain doc spec doesn't exist in code

File: src/lib/services/documents.service.ts:1225-1251
What: Spec is doc.clientId ?? .companyId ?? .yachtId ?? interest.clientId ?? interest.yachtId. Code stops at interest.clientId because interests.clientId is NOT NULL — so the yachtId fallback is unreachable. Comment line 1239 explains.
Suggested fix: Update CLAUDE.md to drop the unreachable trailing branch, or annotate with // unreachable: interests.clientId is NOT NULL.

✅ Passing checks

D-01 A16 fix verified — formStr() returns undefined (not null) for absent FormData fields; root upload omits folderId correctly
D-02 entity-folder drag-drop carries folderId+entityType+entityId+typed FK
D-03 file picker dialog passes folderId (null for root) correctly
D-04 PDF inline preview via PdfViewer lazy-loaded
D-05 image inline preview + lightbox via <img> for jpeg/png/gif/webp
D-06 Word/Excel: FileGrid gates "Preview" with PREVIEWABLE_MIMES.has(...) so only "Download" shows; FilePreviewDialog never opened
D-07 download endpoint wraps with withPermission('files', 'view', ...); getFileById enforces port via file.portId !== portId
D-08 deleteFolderSoftRescue (src/lib/services/document-folders.service.ts:294-337) wrapped in db.transaction(), re-parents folders + documents + files explicitly (no CASCADE)
D-09 syncEntityFolderName called in updateClient (clients.service.ts:554), updateCompany (companies.service.ts:187), updateYacht (yachts.service.ts:167)
D-10 moveFolder cycle prevention: rejects self at line 213, pg_advisory_xact_lock per port (line 233), walks ancestor chain with seen set, checks cursor === folderId at each step
D-11 assertNotSystemManaged called in renameFolder (line 172), moveFolder (line 217), deleteFolderSoftRescue (line 299)
D-12 listFilesAggregatedByEntity walks Client↔Companies (via companyMemberships INNER JOIN companies on portId)↔Yachts; cap 20 + total
D-14 EntityFolderView uses useAggregatedWorkflows (filters to INFLIGHT_STATUSES ['draft','sent','partially_signed']); files with signedFromDocumentId show "View signing details"
D-15 GET /api/v1/documents/[id]/signing-details returns { data: { workflow, signers, events } }; getDocumentById enforces portId
D-16 idempotency: outer gate doc.status === 'completed' && doc.signedFileId returns; inner SELECT ... FOR UPDATE re-check inside transaction
D-17 Defense-in-depth port at every join: companies INNER JOIN with portId (line 451), clients INNER JOIN with portId (line 497), yachts/files WHERE portId everywhere, LEFT JOIN documents with or(eq(documents.portId, portId), isNull(documents.id)) (line 588-590). companyMemberships has no portId column but is port-scoped via INNER JOIN to companies/clients
D-18 ?folder=<uuid> URL state — three-state (absent → undefined hub root, =root → null, =<uuid> → uuid); decodeFolderParam/encodeFolderParam symmetric; deep folder works
D-19 ensureEntityFolder race-safety: fast-path re-SELECT before insert; two distinct catch branches for uniq_document_folders_entity (re-SELECT winner) and uniq_document_folders_sibling_name (increment suffix)
D-20 magic-byte: bufferMatchesMime in files.ts:58 covers 8 MIME types in-server; presign-PUT only used by berth-pdf/brochure (both stream first 5 bytes + isPdfMagic())
D-21 filename HTML-escape (document-sends.service.ts:415-422)
D-22 streamAttachmentOrLink size-threshold + 24h presigned URL fallback; fallbackToLinkReason: 'size_above_threshold' audited

4.8 KiB Raw Blame History