Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line Lucide icon JSX elements across 267 .tsx files in: - shared/, layout/, dashboard/ - admin/ (all sections) - clients/, berths/, yachts/, companies/, interests/, documents/ - reminders/, reservations/, residential/, expenses/, email/ The regex targeted only the safe pattern \`<IconName className="..." />\` (no other props, self-closing, capitalized component name). Every match inspected is a decorative companion to visible text or sits inside a button whose accessible name comes from \`aria-label\` / sr-only text — the icon itself should not be announced. Screen readers no longer double-read the icon + the adjacent label text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing @axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues to pass. Test suite stays at 1315/1315 vitest. typescript clean. Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups backlog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
51 lines
1.5 KiB
TypeScript
51 lines
1.5 KiB
TypeScript
'use client';
|
|
|
|
import { useSearchParams, useRouter, usePathname } from 'next/navigation';
|
|
import { Loader2 } from 'lucide-react';
|
|
|
|
import { ResponsiveTabs, type ResponsiveTab } from '@/components/shared/responsive-tabs';
|
|
|
|
export type DetailTab = ResponsiveTab;
|
|
|
|
interface DetailLayoutProps {
|
|
header: React.ReactNode;
|
|
tabs: DetailTab[];
|
|
defaultTab?: string;
|
|
isLoading?: boolean;
|
|
actions?: React.ReactNode;
|
|
}
|
|
|
|
export function DetailLayout({ header, tabs, defaultTab, isLoading, actions }: DetailLayoutProps) {
|
|
const searchParams = useSearchParams();
|
|
const router = useRouter();
|
|
const pathname = usePathname();
|
|
|
|
const activeTab = searchParams.get('tab') ?? defaultTab ?? tabs[0]?.id ?? '';
|
|
|
|
function handleTabChange(tabId: string) {
|
|
const params = new URLSearchParams(searchParams.toString());
|
|
params.set('tab', tabId);
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
router.replace(`${pathname}?${params.toString()}` as any, { scroll: false });
|
|
}
|
|
|
|
if (isLoading) {
|
|
return (
|
|
<div className="flex items-center justify-center py-20">
|
|
<Loader2 className="h-8 w-8 animate-spin text-muted-foreground" aria-hidden />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div className="space-y-6">
|
|
<div className="flex items-start justify-between gap-4 flex-wrap">
|
|
<div className="min-w-0 flex-1">{header}</div>
|
|
{actions && <div className="flex items-center gap-2 shrink-0">{actions}</div>}
|
|
</div>
|
|
|
|
<ResponsiveTabs tabs={tabs} value={activeTab} onValueChange={handleTabChange} />
|
|
</div>
|
|
);
|
|
}
|