Refactored the interest-detail 404 pattern into a reusable `<DetailNotFound>` component and applied it to the four other entity detail pages. Pre-fix, navigating to a wrong-port or stale entity URL silently rendered the layout shell with empty tabs on: - /[portSlug]/clients/[id] - /[portSlug]/yachts/[id] - /[portSlug]/companies/[id] - /[portSlug]/berths/[id] All four now route a 404/403 response into an explicit "<Entity> not found" / "No access" EmptyState with a back-to-list CTA, and the TanStack Query retry policy short-circuits 404/403s so the empty state appears immediately. 1373/1373 vitest pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
144 lines
4.2 KiB
TypeScript
144 lines
4.2 KiB
TypeScript
'use client';
|
||
|
||
import { useEffect } from 'react';
|
||
import { useQuery } from '@tanstack/react-query';
|
||
import { useParams } from 'next/navigation';
|
||
|
||
import { DetailLayout } from '@/components/shared/detail-layout';
|
||
import { DetailNotFound } from '@/components/shared/detail-not-found';
|
||
import { useMobileChrome } from '@/components/layout/mobile/mobile-layout-provider';
|
||
import { ClientDetailHeader } from '@/components/clients/client-detail-header';
|
||
import { getClientTabs } from '@/components/clients/client-tabs';
|
||
import { useRealtimeInvalidation } from '@/hooks/use-realtime-invalidation';
|
||
import { useBreadcrumbHint } from '@/hooks/use-breadcrumb-hint';
|
||
import { apiFetch } from '@/lib/api/client';
|
||
import type { Address } from '@/components/shared/addresses-editor';
|
||
|
||
interface ClientData {
|
||
id: string;
|
||
portId: string;
|
||
fullName: string;
|
||
nationalityIso: string | null;
|
||
preferredContactMethod: string | null;
|
||
preferredLanguage: string | null;
|
||
timezone: string | null;
|
||
source: string | null;
|
||
sourceDetails: string | null;
|
||
archivedAt: string | null;
|
||
clientPortalEnabled: boolean;
|
||
createdAt: string;
|
||
updatedAt: string;
|
||
contacts: Array<{
|
||
id: string;
|
||
channel: string;
|
||
value: string;
|
||
valueE164: string | null;
|
||
valueCountry: string | null;
|
||
label: string | null;
|
||
isPrimary: boolean;
|
||
notes: string | null;
|
||
}>;
|
||
tags: Array<{
|
||
id: string;
|
||
name: string;
|
||
color: string;
|
||
}>;
|
||
yachts: Array<{
|
||
id: string;
|
||
name: string;
|
||
hullNumber: string | null;
|
||
registration: string | null;
|
||
lengthFt: string | null;
|
||
widthFt: string | null;
|
||
status: string;
|
||
}>;
|
||
companies: Array<{
|
||
membershipId: string;
|
||
role: string;
|
||
isPrimary: boolean;
|
||
startDate: string | Date;
|
||
company: {
|
||
id: string;
|
||
name: string;
|
||
legalName: string | null;
|
||
status: string;
|
||
};
|
||
}>;
|
||
activeReservations: Array<{
|
||
id: string;
|
||
berthId: string;
|
||
yachtId: string;
|
||
startDate: string | Date;
|
||
tenureType: string;
|
||
status: string;
|
||
}>;
|
||
addresses: Address[];
|
||
}
|
||
|
||
interface ClientDetailProps {
|
||
clientId: string;
|
||
currentUserId?: string;
|
||
}
|
||
|
||
export function ClientDetail({ clientId, currentUserId }: ClientDetailProps) {
|
||
const params = useParams<{ portSlug: string }>();
|
||
const portSlug = params?.portSlug ?? '';
|
||
|
||
const { data, isLoading, error } = useQuery<ClientData>({
|
||
queryKey: ['clients', clientId],
|
||
queryFn: () =>
|
||
apiFetch<{ data: ClientData }>(`/api/v1/clients/${clientId}`).then((r) => r.data),
|
||
retry: (failureCount, err) => {
|
||
const status = (err as { status?: number } | null | undefined)?.status;
|
||
if (status === 404 || status === 403) return false;
|
||
return failureCount < 2;
|
||
},
|
||
});
|
||
|
||
const { setChrome } = useMobileChrome();
|
||
const titleForChrome: string | null = data?.fullName ?? null;
|
||
useEffect(() => {
|
||
setChrome({ title: titleForChrome, showBackButton: true });
|
||
return () => setChrome({ title: null, showBackButton: false });
|
||
}, [titleForChrome, setChrome]);
|
||
|
||
// Topbar breadcrumb hint: replaces "Clients › <uuid>" with
|
||
// "Clients › Mary Smith". Hint clears on unmount.
|
||
useBreadcrumbHint(data ? { parents: [], current: data.fullName } : null);
|
||
|
||
useRealtimeInvalidation({
|
||
'client:updated': [['clients', clientId]],
|
||
'client:archived': [['clients', clientId]],
|
||
'client:restored': [['clients', clientId]],
|
||
'yacht:ownership_transferred': [['clients', clientId]],
|
||
'company_membership:added': [['clients', clientId]],
|
||
'company_membership:ended': [['clients', clientId]],
|
||
'berth_reservation:activated': [['clients', clientId]],
|
||
'berth_reservation:ended': [['clients', clientId]],
|
||
'berth_reservation:cancelled': [['clients', clientId]],
|
||
});
|
||
|
||
if (error && !isLoading) {
|
||
const status = (error as { status?: number } | null | undefined)?.status;
|
||
return (
|
||
<DetailNotFound
|
||
entity="client"
|
||
backHref={`/${portSlug}/clients`}
|
||
backLabel="Back to clients"
|
||
status={status}
|
||
/>
|
||
);
|
||
}
|
||
|
||
const tabs = data ? getClientTabs({ clientId, currentUserId, client: data }) : [];
|
||
|
||
return (
|
||
<DetailLayout
|
||
header={data ? <ClientDetailHeader client={data} /> : null}
|
||
tabs={tabs}
|
||
defaultTab="overview"
|
||
isLoading={isLoading}
|
||
/>
|
||
);
|
||
}
|