Matt
c8ea9ec0a0
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line Lucide icon JSX elements across 267 .tsx files in: - shared/, layout/, dashboard/ - admin/ (all sections) - clients/, berths/, yachts/, companies/, interests/, documents/ - reminders/, reservations/, residential/, expenses/, email/ The regex targeted only the safe pattern \`<IconName className="..." />\` (no other props, self-closing, capitalized component name). Every match inspected is a decorative companion to visible text or sits inside a button whose accessible name comes from \`aria-label\` / sr-only text — the icon itself should not be announced. Screen readers no longer double-read the icon + the adjacent label text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing @axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues to pass. Test suite stays at 1315/1315 vitest. typescript clean. Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups backlog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
76 lines
2.4 KiB
TypeScript
76 lines
2.4 KiB
TypeScript
'use client';
|
|
|
|
import { Bookmark, Check, Trash2 } from 'lucide-react';
|
|
|
|
import { Button } from '@/components/ui/button';
|
|
import {
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
DropdownMenuTrigger,
|
|
} from '@/components/ui/dropdown-menu';
|
|
import { useSavedViews } from '@/hooks/use-saved-views';
|
|
|
|
interface SavedViewsDropdownProps {
|
|
entityType: string;
|
|
onApplyView: (
|
|
filters: Record<string, unknown>,
|
|
sort?: { field: string; direction: string },
|
|
) => void;
|
|
}
|
|
|
|
/**
|
|
* Read-only browser for saved views. The "Save current view" affordance
|
|
* has moved into the ColumnPicker menu (see SaveViewDialog). This
|
|
* component renders nothing when the user has no saved views — the
|
|
* Bookmark button on its own is just visual noise until something has
|
|
* been saved.
|
|
*/
|
|
export function SavedViewsDropdown({ entityType, onApplyView }: SavedViewsDropdownProps) {
|
|
const { views, activeViewId, deleteView, applyView } = useSavedViews(entityType);
|
|
|
|
if (views.length === 0) return null;
|
|
|
|
return (
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button variant="outline" size="sm" className="h-8">
|
|
<Bookmark className="mr-1.5 h-3.5 w-3.5" aria-hidden />
|
|
Views
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent align="end" className="w-56">
|
|
{views.map((view) => (
|
|
<DropdownMenuItem
|
|
key={view.id}
|
|
className="flex items-center justify-between"
|
|
onClick={() => {
|
|
applyView(view.id);
|
|
onApplyView(
|
|
view.filters as Record<string, unknown>,
|
|
view.sortConfig as { field: string; direction: string } | undefined,
|
|
);
|
|
}}
|
|
>
|
|
<span className="truncate">{view.name}</span>
|
|
<div className="flex items-center gap-1">
|
|
{activeViewId === view.id && (
|
|
<Check className="h-3.5 w-3.5 text-primary" aria-hidden />
|
|
)}
|
|
<button
|
|
className="p-0.5 rounded hover:bg-muted"
|
|
onClick={(e) => {
|
|
e.stopPropagation();
|
|
deleteView(view.id);
|
|
}}
|
|
>
|
|
<Trash2 className="h-3 w-3 text-muted-foreground" aria-hidden />
|
|
</button>
|
|
</div>
|
|
</DropdownMenuItem>
|
|
))}
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
);
|
|
}
|