letsbe/pn-new-crm
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
Files
2a4dadd5a79dd602cd7498268a8a4001ee954cae
pn-new-crm/docs/audit-findings-tmp/01b-legacy-rendering-surfaces.md
Matt 4b5f85cb7d fix(audit): comprehensive 2026-05-15 audit fix wave + Documenso v2 polish 
Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).

CRITICAL (3):
 - C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
   no longer silently drop interest links
 - C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
 - C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
   callers must go through /stage with the override-guard chain

HIGH (14/15):
 - H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
   interests/documents/reservations/reminders/invoices (migration 0070)
 - H-02 login page reads ?redirect= param with same-origin guard
 - H-03 CRM invite token moves to URL fragment so it never lands in
   nginx access logs / Referer headers
 - H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
 - H-05 toggleAccount writes an audit row
 - H-06 upsertSetting masks any value whose key ends with _encrypted
 - H-07 archiveClient cascade fires per-interest audit rows
 - H-08 createSalesTransporter applies SMTP_TIMEOUTS
 - H-09 AppShell stable children — viewport flip across breakpoint no
   longer destroys in-progress form drafts
 - H-10 portal documents page swaps Unicode glyph status icons for
   Lucide CheckCircle2/XCircle/Circle + aria-labels
 - H-12 list components swap alert(...) for toast.warning(...)
 - H-13 5 icon-only buttons gain aria-label
 - H-14 parseBody treats empty bodies as {}
 - H-15 admin layout renders a 403 panel instead of silent bounce
 - H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet

MEDIUM (28+):
 - M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
   WHEREs across custom-fields, notes (all 6 entity types x update +
   delete), client-contacts, yacht ownerClient lookup, webhook reads
 - M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
 - M-EM01 portal-auth emails thread through portId
 - M-EM02 sendEmail accepts cc/bcc params
 - M-EM04 notification_digest catalog key
 - M-IN01 portal presigned download URLs use 4h TTL
 - M-IN02 OpenAI client lazy-instantiated
 - M-IN04 stale pdfme refs updated to pdf-lib AcroForm
 - M-IN05 umami.testConnection returns tagged union
 - M-L01 reservations tenure_type unified with berths
 - M-L02 report-generators canonicalize stage values
 - M-AU01 audit log placeholder copy fixed
 - M-AU04 outcome_set / outcome_cleared distinct audit verbs
 - M-NEW-2 activity feed entity name+type separator
 - M-R01 portal allowlist narrowed + portal_session backstop in proxy
 - M-SC02 companies archived partial index
 - M-SC04 audit_logs.searchText documented as DB-managed
 - M-S01 storage_s3_access_key_encrypted admin field
 - M-U01 audit log empty state uses <EmptyState>
 - M-U09 invoice delete dialog -> <AlertDialog>
 - M-U10 toast.success on ClientForm + InterestForm create/edit
 - M-U11 settings-form-card logo preview alt text
 - M-U14 mobile topbar title on clients/yachts/interests/berths
 - M-U15 Invoices in mobile More-sheet

LOW (6/8):
 - L-AU01 severity defaults for security-relevant verbs
 - L-AU02 +13 missing actions in admin audit filter
 - L-AU03 +7 missing entity types in admin audit filter
 - L-AU04 dead listAuditLogs stubbed
 - L-D02 CLAUDE.md Owner-wins chain tightened

Bonus — Document detail polish (#67 partial, 3/6 deliverables):
 - state-aware action button per signer
 - watcher Add UI with display-name resolution
 - cleanSignerName cleanup

Prior session work bundled in:
 - Documenso v2 webhook + envelope-ID normalization + sequential signing
 - SigningProgress UI redesign (avatars, per-signer state, timestamps)
 - env->admin settings registry + RegistryDrivenForm + encrypted creds
 - Embedded-signing card + Test connection + setup help
 - Dev-mode EMAIL_REDIRECT_TO banner
 - Pipeline rules admin page
 - Sales email config card
 - Audit log details Sheet
 - EOI tab: Finalising badge, absolute timestamps, sequential indicator
 - Notes pipeline_stage_at_creation (migration 0069)
 - Documenso numeric ID dual-key webhook (migration 0068)
 - Dimensions criterion copy (migration 0067)

Tests: 1374/1374 vitest pass. tsc clean. lint clean.

See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 13:28:50 +02:00

3.6 KiB
Raw Blame History

L-002-011 Legacy Stage Rendering Surfaces — done in main thread (sub-agent context-thrashed)

Headline: Mostly clean. One LOW finding: report-generators stage rollup keys are raw enum without LEGACY_STAGE_REMAP/canonicalizeStage — defensive-coding gap if any active row drifts back to a legacy stage value (migration 0062 normalized, so this is theoretical).

Counts: 0 critical · 0 high · 0 medium · 1 low (defensive)

🟢 LOW L-008: Reports stage-revenue rollup uses raw interests.pipelineStage without canonicalizeStage

  • File: src/lib/services/report-generators.ts:71-76, 88-106, 124-138, 176-192
  • What: stageRevenueMap[row.stage] = ... and pipelineWeights[row.stage] use the raw enum value from the SQL groupBy(interests.pipelineStage). No canonicalizeStage() wrap.
  • Why it matters: Migration 0062 normalized historical data to modern values, so today active rows should all be in the 7-stage set and bucketing is correct. But if any leakage occurs (NocoDB re-import, partial migration on a future port, manual psql write), legacy values would be siloed into their own bucket and pipelineWeights[legacy_value] returns undefined → that bucket contributes 0 to the forecast. Silent.
  • Suggested fix: Wrap row.stage with canonicalizeStage(row.stage) from src/lib/utils/legacy-stage.ts before keying into stageRevenueMap / pipelineWeights.

✅ Passing checks

  • L-002 audit log diff — audit-log-list.tsx / audit-log-card.tsx don't render stage values at all (just field-name keys per agent #4's AU-08 finding). No raw-enum render path exists.
  • L-003 activity feed — src/components/dashboard/activity-feed.tsx:14,57 imports and uses LEGACY_STAGE_REMAP for the stage_change diff line.
  • L-004 email templates — src/lib/email/templates/notification-digest.tsx:24 TYPE_LABELS includes eoi_signed as a notification type label (the doc-status event), not a pipeline stage. Legitimate.
  • L-005 Documenso payload — src/lib/services/documenso-payload.ts and src/lib/templates/merge-fields.ts have zero pipelineStage / pipeline_stage references. EOI payload doesn't surface stage.
  • L-006 public berths status filter — already verified clean by agent #7 (IN-17). src/lib/services/public-berths.ts:90-97 derivePublicStatus only branches on sold / under_offer / else available. No legacy enum acceptance.
  • L-007 outbound webhook — webhook-dispatch.ts is a passthrough; payload built at interests.service.ts:919-934 (emitToRoom + dispatchWebhookEvent). New stage value is current modern (write-time enforcement). oldStage could be legacy if the row was historical, but that's the actual historical truth — informational.
  • L-009 search FTS on stages — interests has no FTS GIN index at all (per agent #2's SC-04 finding); migration 0057 covers only clients/yachts/residential_clients. Stage searchability via FTS is moot. (SC-04 fix should add interests FTS — when added, the GENERATED expression should use stageLabelFor for the stage column.)
  • L-010 notifications — next-in-line-notify.service.ts:63-65 falls back to i.pipelineStage.replace(/_/g, ' ') when STAGE_LABELS lookup misses. STAGE_LABELS is the modern-only map; legacy values would render as "eoi signed" etc. Recommended switch to stageLabelFor() for legacy resilience, but: only fires for active interests where stage is modern, so functionally clean today.
  • L-011 CSV importers — Only import services are berth-import.ts and document-import.ts; neither references pipelineStage. No CSV stage-import path exists, so no risk of legacy value re-entry through this vector.
Reference in New Issue View Git Blame Copy Permalink