Files
pn-new-crm/src/components/admin/settings/settings-manager.tsx
Matt 449b9497ab fix(uat): batch — timeline overshoot, name-sync, reset-password, dashboard cleanup, queue/seed hygiene + alpha UAT findings doc
UAT findings landed across the last few Playwright + React Grab passes;
single grouped commit so the index doesn't fragment into 30 one-liners.

User & auth:
- `user-settings`: name now updates the avatar + topbar menu after save
  (was reading stale session).
- `me/password-reset`: 3 bugs (token validation, error response shape,
  redirect chain).
- Admin user permission-overrides route honours the same envelope as
  the rest of the admin surface.

Dashboard:
- Removed obsolete `revenue-breakdown-chart` + `dashboard-widgets-card`
  (replaced by the customisable widget grid).
- Strip `revenue_breakdown` from analytics route + use-analytics +
  service + integration test so nothing renders an empty card.
- Activity log timeline overshoot fix (`interest-timeline` +
  `entity-activity-feed`).
- Tightened tiles: active-deals, berth-heat-widget, pipeline-value, kpi-tile.
- `dev-mode-banner`: derive dismissed state synchronously instead of
  via an effect (set-state-in-effect lint rule).

Forms & lists (assorted polish):
- client / company / yacht / interest / reminder forms — validation +
  empty-state copy + tab transitions.
- companies/yachts list tweaks; berth recommender panel; qualification
  checklist; supplemental info request button.

Infra & misc:
- Queue workers (ai / email / notifications) — log shape +
  per-job timeout consistency.
- Auth / brochures / users schema small adjustments; seeds reflect
  permissions matrix changes.
- Scan shell + scanner manifest + AI admin page small fixes.
- `next.config.transpilePackages` adds `echarts`/`zrender`/`echarts-for-react`
  (recommended config from echarts-for-react inside Next).

Docs:
- `docs/superpowers/audits/alpha-uat-master.md` — single rolling
  cross-cutting UAT findings doc (per CLAUDE.md convention).
- `docs/BACKLOG.md`: dashboard stats cards (§I) + activity-log
  normalization (§J).
- 2026-05-18 audit log updated with this batch.
- `CLAUDE.md` — small manual UAT scaffold notes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-20 15:56:11 +02:00

588 lines
21 KiB
TypeScript

'use client';
import { useState, useEffect, useCallback } from 'react';
import { Trash2, Plus, Save } from 'lucide-react';
import { PageHeader } from '@/components/shared/page-header';
import { ConfirmationDialog } from '@/components/shared/confirmation-dialog';
import { Button } from '@/components/ui/button';
import { Input } from '@/components/ui/input';
import { Label } from '@/components/ui/label';
import { Switch } from '@/components/ui/switch';
import { Textarea } from '@/components/ui/textarea';
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card';
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from '@/components/ui/select';
import { Separator } from '@/components/ui/separator';
import { apiFetch } from '@/lib/api/client';
import { SUPPORTED_CURRENCIES } from '@/lib/utils/currency';
interface Setting {
key: string;
value: unknown;
portId: string | null;
updatedBy: string | null;
updatedAt: string;
}
/** Well-known settings with their display metadata */
const KNOWN_SETTINGS: Array<{
key: string;
label: string;
description: string;
type: 'boolean' | 'number' | 'json' | 'string' | 'select';
defaultValue: unknown;
options?: Array<{ value: string; label: string }>;
}> = [
{
key: 'client_portal_enabled',
label: 'Client Portal',
description:
'Allow clients of this port to sign in and manage their account through the client portal.',
type: 'boolean',
defaultValue: true,
},
{
key: 'ai_interest_scoring',
label: 'AI Interest Scoring',
description: 'Enable AI-powered interest scoring based on engagement signals',
type: 'boolean',
defaultValue: false,
},
{
key: 'ai_email_drafts',
label: 'AI Email Drafts',
description: 'Enable AI-assisted email draft generation',
type: 'boolean',
defaultValue: false,
},
{
key: 'invoice_net10_discount',
label: 'Net-10 Invoice Discount (%)',
description: 'Discount percentage applied when payment terms are net-10',
type: 'number',
defaultValue: 2,
},
{
key: 'pipeline_weights',
label: 'Pipeline Stage Weights',
description: 'Probability weights for revenue forecast by pipeline stage (JSON)',
type: 'json',
defaultValue: {
enquiry: 0.05,
qualified: 0.15,
nurturing: 0.15,
eoi: 0.4,
reservation: 0.7,
deposit_paid: 0.85,
contract: 0.95,
},
},
{
key: 'berth_rules',
label: 'Berth Status Rules',
description: 'Auto/suggest/off rules for berth status transitions (JSON)',
type: 'json',
defaultValue: [],
},
{
key: 'default_new_interest_owner',
label: 'Default New-Interest Owner',
description:
'User ID to auto-assign as the deal owner when a new interest is created. Stored as { "userId": "..." }. Leave blank to have new interests unassigned by default — the rep can pick an owner from the interest detail header.',
type: 'json',
defaultValue: { userId: null },
},
{
key: 'inquiry_contact_email',
label: 'Inquiry Contact Email',
description:
'Reply-to email shown in client confirmation emails when a new interest is registered',
type: 'string',
defaultValue: '',
},
{
key: 'inquiry_notification_recipients',
label: 'External Notification Recipients',
description:
'Additional email addresses that receive sales notifications for new interests (JSON array)',
type: 'json',
defaultValue: [],
},
{
key: 'residential_notification_recipients',
label: 'Residential Notification Recipients',
description:
'Email addresses (JSON array) that receive sales alerts for new residential inquiries. Falls back to Inquiry Contact Email when empty.',
type: 'json',
defaultValue: [],
},
{
key: 'eoi_signers',
label: 'EOI Signers',
description:
'Internal staff who countersign every EOI. JSON object with `developer` (signs after the client) and `approver` (final approval). Both fields take `{ name, email }`.',
type: 'json',
defaultValue: {
developer: { name: '', email: '' },
approver: { name: '', email: '' },
},
},
// ─── Berth recommender (src/lib/services/berth-recommender.service.ts) ──────
{
key: 'recommender_max_oversize_pct',
label: 'Recommender — max oversize %',
description:
'Cap on how much larger a berth can be than the desired length/width/draft before it stops being suggested. Default 30.',
type: 'number',
defaultValue: 30,
},
{
key: 'recommender_top_n_default',
label: 'Recommender — default result count',
description: 'Default number of berth recommendations returned per request. Default 8.',
type: 'number',
defaultValue: 8,
},
{
key: 'fallthrough_policy',
label: 'Recommender — fall-through policy',
description: 'How berths re-enter the recommender after a lost deal.',
type: 'select',
defaultValue: 'immediate_with_heat',
options: [
{
value: 'immediate_with_heat',
label: 'Immediate (with heat boost) — surface again right away',
},
{
value: 'cooldown',
label: 'Cooldown — wait N days (see below)',
},
{
value: 'never_auto_recommend',
label: 'Never — only re-surface via manual rep search',
},
],
},
{
key: 'fallthrough_cooldown_days',
label: 'Recommender — fall-through cooldown (days)',
description:
'Days a berth stays out of the recommender after a lost deal when the policy is `cooldown`. Default 30.',
type: 'number',
defaultValue: 30,
},
{
key: 'heat_weight_recency',
label: 'Heat weight — recency',
description: 'Weight given to how recently the prior interest fell through. Default 30.',
type: 'number',
defaultValue: 30,
},
{
key: 'heat_weight_furthest_stage',
label: 'Heat weight — furthest stage',
description:
'Weight given to how close the prior interest got to closing before falling through. Default 40.',
type: 'number',
defaultValue: 40,
},
{
key: 'heat_weight_interest_count',
label: 'Heat weight — historical interest count',
description:
'Weight given to how often this berth has attracted interest historically. Default 15.',
type: 'number',
defaultValue: 15,
},
{
key: 'heat_weight_eoi_count',
label: 'Heat weight — historical EOI count',
description:
'Weight given to how often interest in this berth has reached EOI signing. Default 15.',
type: 'number',
defaultValue: 15,
},
{
key: 'tier_ladder_hide_late_stage',
label: 'Recommender — hide late-stage tier',
description:
'Hide berths whose only active interests are late-stage (close to closing) from recommendations.',
type: 'boolean',
defaultValue: true,
},
{
key: 'documents_show_expired_tab',
label: 'Documents — show Expired tab',
description:
'When off, the Expired tab on the documents hub is hidden. Use this when expired EOIs are noise that distracts reps from active deals.',
type: 'boolean',
defaultValue: true,
},
{
key: 'berths_default_currency',
label: 'Berths — default currency',
description:
'Currency applied to newly-created berths when none is specified on the form. Existing berths keep their per-row currency. Defaults to USD.',
type: 'select',
defaultValue: 'USD',
options: SUPPORTED_CURRENCIES.map((c) => ({ value: c.code, label: `${c.code}${c.label}` })),
},
];
export function SettingsManager() {
const [portSettings, setPortSettings] = useState<Setting[]>([]);
const [loading, setLoading] = useState(true);
const [saving, setSaving] = useState<string | null>(null);
const [values, setValues] = useState<Record<string, unknown>>({});
const [customKey, setCustomKey] = useState('');
const [customValue, setCustomValue] = useState('');
const fetchSettings = useCallback(async () => {
setLoading(true);
try {
const res = await apiFetch<{ data: { portSettings: Setting[]; globalSettings: Setting[] } }>(
'/api/v1/admin/settings',
);
setPortSettings(res.data.portSettings);
// Build values map from existing settings
const vals: Record<string, unknown> = {};
for (const s of res.data.portSettings) {
vals[s.key] = s.value;
}
setValues(vals);
} finally {
setLoading(false);
}
}, []);
useEffect(() => {
// Initial settings load on mount.
// eslint-disable-next-line react-hooks/set-state-in-effect
void fetchSettings();
}, [fetchSettings]);
async function saveSetting(key: string, value: unknown) {
setSaving(key);
try {
await apiFetch('/api/v1/admin/settings', {
method: 'PUT',
body: { key, value },
});
await fetchSettings();
} finally {
setSaving(null);
}
}
async function handleDeleteSetting(key: string) {
await apiFetch('/api/v1/admin/settings', {
method: 'DELETE',
body: { key },
});
await fetchSettings();
}
async function handleAddCustom() {
if (!customKey.trim()) return;
let parsed: unknown;
try {
parsed = JSON.parse(customValue);
} catch {
parsed = customValue;
}
await saveSetting(customKey, parsed);
setCustomKey('');
setCustomValue('');
}
function getEffectiveValue(key: string, defaultValue: unknown): unknown {
return values[key] ?? defaultValue;
}
if (loading) {
return (
<div>
<PageHeader title="System Settings" description="Configure system behavior for this port" />
<div className="flex items-center justify-center py-12 text-muted-foreground">
Loading...
</div>
</div>
);
}
// Custom settings = port settings that aren't in KNOWN_SETTINGS
const knownKeys = new Set(KNOWN_SETTINGS.map((s) => s.key));
const customSettings = portSettings.filter((s) => !knownKeys.has(s.key));
return (
<div>
<PageHeader title="System Settings" description="Configure system behavior for this port" />
<div className="space-y-6 mt-6">
{/* Feature Flags */}
<Card>
<CardHeader>
<CardTitle>Feature Flags</CardTitle>
<CardDescription>Enable or disable optional features</CardDescription>
</CardHeader>
<CardContent className="space-y-4">
{KNOWN_SETTINGS.filter((s) => s.type === 'boolean').map((setting) => (
<div key={setting.key} className="flex items-center justify-between">
<div>
<Label>{setting.label}</Label>
<p className="text-xs text-muted-foreground">{setting.description}</p>
</div>
<Switch
checked={getEffectiveValue(setting.key, setting.defaultValue) === true}
disabled={saving === setting.key}
onCheckedChange={(checked) => saveSetting(setting.key, checked)}
/>
</div>
))}
</CardContent>
</Card>
{/* String + Select Settings — both render in the same card.
'select' settings get a Select dropdown bound to setting.options;
'string' settings get a free-text Input. */}
{KNOWN_SETTINGS.some((s) => s.type === 'string' || s.type === 'select') && (
<Card>
<CardHeader>
<CardTitle>Inquiry Settings</CardTitle>
<CardDescription>Configure inquiry notification behavior</CardDescription>
</CardHeader>
<CardContent className="space-y-4">
{KNOWN_SETTINGS.filter((s) => s.type === 'string' || s.type === 'select').map(
(setting) => (
<div
key={setting.key}
// Stack label/description above the input on phone widths.
// The previous flex row crushed the label column into a
// narrow vertical stripe ("Inquiry / Contact / Email" wrapping
// one word per line) while the input took the rest.
className="flex flex-col gap-2 sm:flex-row sm:items-center sm:justify-between sm:gap-4"
>
<div className="flex-1">
<Label>{setting.label}</Label>
<p className="text-xs text-muted-foreground">{setting.description}</p>
</div>
<div className="flex items-center gap-2">
{setting.type === 'select' && setting.options ? (
<Select
value={String(getEffectiveValue(setting.key, setting.defaultValue) ?? '')}
onValueChange={(v) =>
setValues((prev) => ({ ...prev, [setting.key]: v }))
}
>
<SelectTrigger className="w-full sm:w-72">
<SelectValue />
</SelectTrigger>
<SelectContent>
{setting.options.map((opt) => (
<SelectItem key={opt.value} value={opt.value}>
{opt.label}
</SelectItem>
))}
</SelectContent>
</Select>
) : (
<Input
type="text"
className="w-full sm:w-64"
value={String(getEffectiveValue(setting.key, setting.defaultValue) ?? '')}
onChange={(e) =>
setValues((prev) => ({
...prev,
[setting.key]: e.target.value,
}))
}
/>
)}
<Button
size="sm"
variant="outline"
disabled={saving === setting.key}
onClick={() =>
saveSetting(setting.key, values[setting.key] ?? setting.defaultValue)
}
>
<Save className="h-3.5 w-3.5" aria-hidden />
</Button>
</div>
</div>
),
)}
</CardContent>
</Card>
)}
{/* Numeric Settings */}
<Card>
<CardHeader>
<CardTitle>Business Rules</CardTitle>
<CardDescription>Configure financial and operational parameters</CardDescription>
</CardHeader>
<CardContent className="space-y-4">
{KNOWN_SETTINGS.filter((s) => s.type === 'number').map((setting) => (
<div
key={setting.key}
className="flex flex-col gap-2 sm:flex-row sm:items-center sm:justify-between sm:gap-4"
>
<div className="flex-1">
<Label>{setting.label}</Label>
<p className="text-xs text-muted-foreground">{setting.description}</p>
</div>
<div className="flex items-center gap-2">
<Input
type="number"
className="w-full sm:w-24"
value={String(getEffectiveValue(setting.key, setting.defaultValue) ?? '')}
onChange={(e) =>
setValues((prev) => ({
...prev,
[setting.key]: parseFloat(e.target.value) || 0,
}))
}
/>
<Button
size="sm"
variant="outline"
disabled={saving === setting.key}
onClick={() =>
saveSetting(setting.key, values[setting.key] ?? setting.defaultValue)
}
>
<Save className="h-3.5 w-3.5" aria-hidden />
</Button>
</div>
</div>
))}
</CardContent>
</Card>
{/* JSON Settings */}
<Card>
<CardHeader>
<CardTitle>Advanced Configuration</CardTitle>
<CardDescription>
JSON-based settings for pipeline weights and berth rules
</CardDescription>
</CardHeader>
<CardContent className="space-y-6">
{KNOWN_SETTINGS.filter((s) => s.type === 'json').map((setting) => {
const currentValue = getEffectiveValue(setting.key, setting.defaultValue);
const jsonStr =
values[`${setting.key}_edit`] !== undefined
? String(values[`${setting.key}_edit`])
: JSON.stringify(currentValue, null, 2);
return (
<div key={setting.key} className="space-y-2">
<Label>{setting.label}</Label>
<p className="text-xs text-muted-foreground">{setting.description}</p>
<Textarea
className="font-mono text-xs"
rows={6}
value={jsonStr}
onChange={(e) =>
setValues((prev) => ({ ...prev, [`${setting.key}_edit`]: e.target.value }))
}
/>
<Button
size="sm"
disabled={saving === setting.key}
onClick={() => {
try {
const parsed = JSON.parse(
String(values[`${setting.key}_edit`] ?? JSON.stringify(currentValue)),
);
void saveSetting(setting.key, parsed);
} catch {
// invalid JSON - do nothing
}
}}
>
{saving === setting.key ? 'Saving…' : 'Save'}
</Button>
</div>
);
})}
</CardContent>
</Card>
{/* Custom Settings */}
<Card>
<CardHeader>
<CardTitle>Custom Settings</CardTitle>
<CardDescription>
Free-form key-value entries that aren&apos;t covered by the typed forms above. Use
this for one-off feature flags, integration secrets, or experimental tunables that the
platform reads at runtime via{' '}
<code className="text-xs">getSystemSetting(portId, key)</code>. Values can be JSON
objects, plain strings, numbers, or booleans. Most reps will never need this section
touch only if you know which key affects what.
</CardDescription>
</CardHeader>
<CardContent className="space-y-4">
{customSettings.map((setting) => (
<div key={setting.key} className="flex items-center justify-between gap-2">
<div>
<code className="text-sm font-mono">{setting.key}</code>
<p className="text-xs text-muted-foreground">
{typeof setting.value === 'object'
? JSON.stringify(setting.value)
: String(setting.value)}
</p>
</div>
<ConfirmationDialog
trigger={
<Button
variant="ghost"
size="sm"
className="text-destructive hover:text-destructive"
>
<Trash2 className="h-4 w-4" aria-hidden />
</Button>
}
title="Delete Setting"
description={`Delete "${setting.key}"? This may affect system behavior.`}
confirmLabel="Delete"
onConfirm={() => handleDeleteSetting(setting.key)}
/>
</div>
))}
<Separator />
<div className="flex gap-2">
<Input
placeholder="Key"
value={customKey}
onChange={(e) => setCustomKey(e.target.value)}
className="w-40"
/>
<Input
placeholder="Value (JSON or string)"
value={customValue}
onChange={(e) => setCustomValue(e.target.value)}
className="flex-1"
/>
<Button variant="outline" onClick={handleAddCustom} disabled={!customKey.trim()}>
<Plus className="mr-1 h-4 w-4" aria-hidden />
Add
</Button>
</div>
</CardContent>
</Card>
</div>
</div>
);
}