Matt
221ae5784e
Bundles the prior autonomous-session output that was sitting unstaged: - Em-dash sweep across src/ + tests/ (en-dash/em-dash to hyphen, ~2280 instances) - country-flag-icons rollout (CountryFlag component, replaces emoji glyphs that never rendered on Windows; lazy-loads the 3x2 SVG index as a single chunk after the per-subpath dynamic-import approach silently failed in webpack) - Admin IA Phase 1+2: 7-domain regroup, 41 to 38 pages, /admin/berths index, redirects (ocr to ai, reports to dashboard, invitations to users), docs/admin-ia-proposal.md - Per-template email tester (registry + endpoint + UI on Email admin page) - Cancel-document mode picker (delete-from-Documenso vs keep-for-audit) - Dashboard PDF report: 25 widgets, SVG charts, date-range picker, 11 resolvers - Customize-widgets per-region sortables at xl+ (charts/rails/feed); single flat sortable below xl when the layout stacks; per-viewport saved orders - Audit doc updates capturing each shipped item - Lint fixes: react-compiler immutability in DonutChart (reduce instead of let-reassign), set-state-in-effect disables in CountryFlag and UploadForSigning preview-bytes effect, unused 'confirm' destructures in interest contract + reservation tabs, unescaped apostrophe in test-template card copy
75 lines
2.7 KiB
TypeScript
75 lines
2.7 KiB
TypeScript
/**
|
|
* clients.service.createRelationship - tenant-FK validation tests.
|
|
*
|
|
* Covers the fix that requires both clientAId (the URL id) and clientBId
|
|
* (the body id) to belong to the caller's port. The list endpoint joins
|
|
* clientRelationships → clients without a port filter, so a foreign-port
|
|
* clientBId would surface that client's name in the relationship payload.
|
|
*/
|
|
import { describe, it, expect, beforeAll } from 'vitest';
|
|
|
|
describe('clients.service - createRelationship port isolation', () => {
|
|
let createRelationship: typeof import('@/lib/services/clients.service').createRelationship;
|
|
|
|
let makePort: typeof import('../helpers/factories').makePort;
|
|
let makeClient: typeof import('../helpers/factories').makeClient;
|
|
let makeAuditMeta: typeof import('../helpers/factories').makeAuditMeta;
|
|
|
|
beforeAll(async () => {
|
|
const svc = await import('@/lib/services/clients.service');
|
|
createRelationship = svc.createRelationship;
|
|
|
|
const factories = await import('../helpers/factories');
|
|
makePort = factories.makePort;
|
|
makeClient = factories.makeClient;
|
|
makeAuditMeta = factories.makeAuditMeta;
|
|
});
|
|
|
|
it('rejects createRelationship when clientBId belongs to a foreign port', async () => {
|
|
const portA = await makePort();
|
|
const portB = await makePort();
|
|
const localClient = await makeClient({ portId: portA.id });
|
|
const foreignClient = await makeClient({ portId: portB.id });
|
|
|
|
await expect(
|
|
createRelationship(
|
|
localClient.id,
|
|
portA.id,
|
|
{ clientBId: foreignClient.id, relationshipType: 'family' },
|
|
makeAuditMeta({ portId: portA.id }),
|
|
),
|
|
).rejects.toThrow(/clientBId not found in this port/);
|
|
});
|
|
|
|
it('rejects creating a self-relationship', async () => {
|
|
const portA = await makePort();
|
|
const localClient = await makeClient({ portId: portA.id });
|
|
|
|
await expect(
|
|
createRelationship(
|
|
localClient.id,
|
|
portA.id,
|
|
{ clientBId: localClient.id, relationshipType: 'family' },
|
|
makeAuditMeta({ portId: portA.id }),
|
|
),
|
|
).rejects.toThrow(/cannot have a relationship to themselves/);
|
|
});
|
|
|
|
it('accepts createRelationship when both clients are in the same port', async () => {
|
|
const portA = await makePort();
|
|
const clientA = await makeClient({ portId: portA.id });
|
|
const clientB = await makeClient({ portId: portA.id });
|
|
|
|
const rel = await createRelationship(
|
|
clientA.id,
|
|
portA.id,
|
|
{ clientBId: clientB.id, relationshipType: 'family' },
|
|
makeAuditMeta({ portId: portA.id }),
|
|
);
|
|
|
|
expect(rel.clientAId).toBe(clientA.id);
|
|
expect(rel.clientBId).toBe(clientB.id);
|
|
expect(rel.portId).toBe(portA.id);
|
|
});
|
|
});
|