Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).
CRITICAL (3):
- C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
no longer silently drop interest links
- C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
- C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
callers must go through /stage with the override-guard chain
HIGH (14/15):
- H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
interests/documents/reservations/reminders/invoices (migration 0070)
- H-02 login page reads ?redirect= param with same-origin guard
- H-03 CRM invite token moves to URL fragment so it never lands in
nginx access logs / Referer headers
- H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
- H-05 toggleAccount writes an audit row
- H-06 upsertSetting masks any value whose key ends with _encrypted
- H-07 archiveClient cascade fires per-interest audit rows
- H-08 createSalesTransporter applies SMTP_TIMEOUTS
- H-09 AppShell stable children — viewport flip across breakpoint no
longer destroys in-progress form drafts
- H-10 portal documents page swaps Unicode glyph status icons for
Lucide CheckCircle2/XCircle/Circle + aria-labels
- H-12 list components swap alert(...) for toast.warning(...)
- H-13 5 icon-only buttons gain aria-label
- H-14 parseBody treats empty bodies as {}
- H-15 admin layout renders a 403 panel instead of silent bounce
- H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet
MEDIUM (28+):
- M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
WHEREs across custom-fields, notes (all 6 entity types x update +
delete), client-contacts, yacht ownerClient lookup, webhook reads
- M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
- M-EM01 portal-auth emails thread through portId
- M-EM02 sendEmail accepts cc/bcc params
- M-EM04 notification_digest catalog key
- M-IN01 portal presigned download URLs use 4h TTL
- M-IN02 OpenAI client lazy-instantiated
- M-IN04 stale pdfme refs updated to pdf-lib AcroForm
- M-IN05 umami.testConnection returns tagged union
- M-L01 reservations tenure_type unified with berths
- M-L02 report-generators canonicalize stage values
- M-AU01 audit log placeholder copy fixed
- M-AU04 outcome_set / outcome_cleared distinct audit verbs
- M-NEW-2 activity feed entity name+type separator
- M-R01 portal allowlist narrowed + portal_session backstop in proxy
- M-SC02 companies archived partial index
- M-SC04 audit_logs.searchText documented as DB-managed
- M-S01 storage_s3_access_key_encrypted admin field
- M-U01 audit log empty state uses <EmptyState>
- M-U09 invoice delete dialog -> <AlertDialog>
- M-U10 toast.success on ClientForm + InterestForm create/edit
- M-U11 settings-form-card logo preview alt text
- M-U14 mobile topbar title on clients/yachts/interests/berths
- M-U15 Invoices in mobile More-sheet
LOW (6/8):
- L-AU01 severity defaults for security-relevant verbs
- L-AU02 +13 missing actions in admin audit filter
- L-AU03 +7 missing entity types in admin audit filter
- L-AU04 dead listAuditLogs stubbed
- L-D02 CLAUDE.md Owner-wins chain tightened
Bonus — Document detail polish (#67 partial, 3/6 deliverables):
- state-aware action button per signer
- watcher Add UI with display-name resolution
- cleanSignerName cleanup
Prior session work bundled in:
- Documenso v2 webhook + envelope-ID normalization + sequential signing
- SigningProgress UI redesign (avatars, per-signer state, timestamps)
- env->admin settings registry + RegistryDrivenForm + encrypted creds
- Embedded-signing card + Test connection + setup help
- Dev-mode EMAIL_REDIRECT_TO banner
- Pipeline rules admin page
- Sales email config card
- Audit log details Sheet
- EOI tab: Finalising badge, absolute timestamps, sequential indicator
- Notes pipeline_stage_at_creation (migration 0069)
- Documenso numeric ID dual-key webhook (migration 0068)
- Dimensions criterion copy (migration 0067)
Tests: 1374/1374 vitest pass. tsc clean. lint clean.
See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
189 lines
8.0 KiB
TypeScript
189 lines
8.0 KiB
TypeScript
import {
|
||
pgTable,
|
||
text,
|
||
boolean,
|
||
numeric,
|
||
integer,
|
||
timestamp,
|
||
date,
|
||
index,
|
||
uniqueIndex,
|
||
primaryKey,
|
||
jsonb,
|
||
AnyPgColumn,
|
||
} from 'drizzle-orm/pg-core';
|
||
import { sql } from 'drizzle-orm';
|
||
import { ports } from './ports';
|
||
import { files } from './documents';
|
||
import { interests } from './interests';
|
||
|
||
export const expenses = pgTable(
|
||
'expenses',
|
||
{
|
||
id: text('id')
|
||
.primaryKey()
|
||
.$defaultFn(() => crypto.randomUUID()),
|
||
portId: text('port_id')
|
||
.notNull()
|
||
.references(() => ports.id),
|
||
establishmentName: text('establishment_name'),
|
||
amount: numeric('amount').notNull(),
|
||
currency: text('currency').notNull().default('USD'),
|
||
amountUsd: numeric('amount_usd'),
|
||
exchangeRate: numeric('exchange_rate'),
|
||
paymentMethod: text('payment_method'),
|
||
category: text('category'),
|
||
payer: text('payer'),
|
||
expenseDate: timestamp('expense_date', { withTimezone: true }).notNull(),
|
||
description: text('description'),
|
||
receiptFileIds: text('receipt_file_ids').array(), // references to files table
|
||
/**
|
||
* True when the rep deliberately created the expense WITHOUT a receipt
|
||
* (e.g. the receipt was lost or never issued). Surfaces a warning at
|
||
* creation time AND in the PDF export — the legacy parent-company flow
|
||
* may refuse to reimburse expenses without proof, so the warning is
|
||
* load-bearing for ops.
|
||
*/
|
||
noReceiptAcknowledged: boolean('no_receipt_acknowledged').notNull().default(false),
|
||
paymentStatus: text('payment_status').default('unpaid'), // unpaid, paid, partial
|
||
paymentDate: date('payment_date'),
|
||
paymentReference: text('payment_reference'),
|
||
paymentNotes: text('payment_notes'),
|
||
/**
|
||
* Free-text trip / event label so reps can group expenses for one
|
||
* yacht show or business trip (e.g. "Palm Beach 2026"). Deliberately
|
||
* un-normalized — events are 6–12/year and full event-management
|
||
* functionality lives outside this CRM. The autocomplete on the
|
||
* expense form keeps spellings consistent so group-by works.
|
||
*/
|
||
tripLabel: text('trip_label'),
|
||
/** When set, this expense is flagged as a duplicate of another in the
|
||
* same port. Self-referencing FK; the dedup service writes this. */
|
||
duplicateOf: text('duplicate_of').references((): AnyPgColumn => expenses.id, {
|
||
onDelete: 'set null',
|
||
}),
|
||
/** Last time the dedup heuristic ran against this row. */
|
||
dedupScannedAt: timestamp('dedup_scanned_at', { withTimezone: true }),
|
||
/** OCR pipeline state: 'pending'|'ok'|'failed'|'low_confidence'. */
|
||
ocrStatus: text('ocr_status').default('pending'),
|
||
/** Full Claude Vision response payload for audit/debug. */
|
||
ocrRaw: jsonb('ocr_raw'),
|
||
/** 0..1; values < 0.6 force the verify-mode UI. */
|
||
ocrConfidence: numeric('ocr_confidence'),
|
||
createdBy: text('created_by').notNull(),
|
||
archivedAt: timestamp('archived_at', { withTimezone: true }),
|
||
createdAt: timestamp('created_at', { withTimezone: true }).notNull().defaultNow(),
|
||
updatedAt: timestamp('updated_at', { withTimezone: true }).notNull().defaultNow(),
|
||
},
|
||
(table) => [
|
||
index('idx_expenses_port').on(table.portId),
|
||
index('idx_expenses_date').on(table.portId, table.expenseDate),
|
||
index('idx_expenses_category').on(table.portId, table.category),
|
||
// Powers the dedup heuristic lookup (port + vendor + amount + date window).
|
||
index('idx_expenses_dedup')
|
||
.on(table.portId, table.establishmentName, table.amount, table.expenseDate)
|
||
.where(sql`duplicate_of IS NULL`),
|
||
// Powers the autocomplete + group-by-trip filter / PDF section.
|
||
index('idx_expenses_trip_label').on(table.portId, table.tripLabel),
|
||
],
|
||
);
|
||
|
||
export const invoices = pgTable(
|
||
'invoices',
|
||
{
|
||
id: text('id')
|
||
.primaryKey()
|
||
.$defaultFn(() => crypto.randomUUID()),
|
||
portId: text('port_id')
|
||
.notNull()
|
||
.references(() => ports.id),
|
||
invoiceNumber: text('invoice_number').notNull(), // INV-YYYYMM-### auto-generated
|
||
clientName: text('client_name').notNull(),
|
||
billingEntityType: text('billing_entity_type').notNull().default('client'), // 'client' | 'company'
|
||
billingEntityId: text('billing_entity_id').notNull().default(''),
|
||
billingEmail: text('billing_email'),
|
||
billingAddress: text('billing_address'),
|
||
dueDate: date('due_date').notNull(),
|
||
paymentTerms: text('payment_terms').notNull().default('net30'), // immediate, net10, net15, net30, net45, net60
|
||
currency: text('currency').notNull().default('USD'),
|
||
subtotal: numeric('subtotal').notNull(),
|
||
discountPct: numeric('discount_pct').default('0'),
|
||
discountAmount: numeric('discount_amount').default('0'),
|
||
feePct: numeric('fee_pct').default('0'),
|
||
feeAmount: numeric('fee_amount').default('0'),
|
||
total: numeric('total').notNull(),
|
||
status: text('status').notNull().default('draft'), // draft, sent, paid, overdue, cancelled
|
||
paymentStatus: text('payment_status').default('unpaid'),
|
||
paymentDate: date('payment_date'),
|
||
paymentMethod: text('payment_method'),
|
||
paymentReference: text('payment_reference'),
|
||
// H-01: nullable — losing the rendered invoice PDF shouldn't bring
|
||
// down the invoice row (totals + payments are the source of truth).
|
||
pdfFileId: text('pdf_file_id').references(() => files.id, { onDelete: 'set null' }),
|
||
/** Optional link to a sales interest. When the invoice is paid and `kind`
|
||
* is 'deposit', recordPayment auto-advances the interest's pipelineStage
|
||
* to deposit_paid (no-op if already further along). */
|
||
interestId: text('interest_id').references(() => interests.id, { onDelete: 'set null' }),
|
||
/** Invoice kind. 'general' (default) is everyday billing; 'deposit' marks
|
||
* the 10% berth-purchase deposit and is what triggers the stage advance. */
|
||
kind: text('kind').notNull().default('general'), // 'general' | 'deposit'
|
||
notes: text('notes'),
|
||
createdBy: text('created_by').notNull(),
|
||
archivedAt: timestamp('archived_at', { withTimezone: true }),
|
||
createdAt: timestamp('created_at', { withTimezone: true }).notNull().defaultNow(),
|
||
updatedAt: timestamp('updated_at', { withTimezone: true }).notNull().defaultNow(),
|
||
},
|
||
(table) => [
|
||
uniqueIndex('idx_invoices_number').on(table.portId, table.invoiceNumber),
|
||
index('idx_invoices_port').on(table.portId),
|
||
index('idx_invoices_status').on(table.portId, table.status),
|
||
index('idx_invoices_billing_entity').on(
|
||
table.portId,
|
||
table.billingEntityType,
|
||
table.billingEntityId,
|
||
),
|
||
index('idx_invoices_interest').on(table.portId, table.interestId),
|
||
],
|
||
);
|
||
|
||
export const invoiceLineItems = pgTable(
|
||
'invoice_line_items',
|
||
{
|
||
id: text('id')
|
||
.primaryKey()
|
||
.$defaultFn(() => crypto.randomUUID()),
|
||
invoiceId: text('invoice_id')
|
||
.notNull()
|
||
.references(() => invoices.id, { onDelete: 'cascade' }),
|
||
description: text('description').notNull(),
|
||
quantity: numeric('quantity').notNull().default('1'),
|
||
unitPrice: numeric('unit_price').notNull(),
|
||
total: numeric('total').notNull(),
|
||
sortOrder: integer('sort_order').notNull().default(0),
|
||
createdAt: timestamp('created_at', { withTimezone: true }).notNull().defaultNow(),
|
||
},
|
||
(table) => [index('idx_ili_invoice').on(table.invoiceId)],
|
||
);
|
||
|
||
export const invoiceExpenses = pgTable(
|
||
'invoice_expenses',
|
||
{
|
||
invoiceId: text('invoice_id')
|
||
.notNull()
|
||
.references(() => invoices.id, { onDelete: 'cascade' }),
|
||
expenseId: text('expense_id')
|
||
.notNull()
|
||
.references(() => expenses.id, { onDelete: 'cascade' }),
|
||
},
|
||
(table) => [primaryKey({ columns: [table.invoiceId, table.expenseId] })],
|
||
);
|
||
|
||
export type Expense = typeof expenses.$inferSelect;
|
||
export type NewExpense = typeof expenses.$inferInsert;
|
||
export type Invoice = typeof invoices.$inferSelect;
|
||
export type NewInvoice = typeof invoices.$inferInsert;
|
||
export type InvoiceLineItem = typeof invoiceLineItems.$inferSelect;
|
||
export type NewInvoiceLineItem = typeof invoiceLineItems.$inferInsert;
|
||
export type InvoiceExpense = typeof invoiceExpenses.$inferSelect;
|
||
export type NewInvoiceExpense = typeof invoiceExpenses.$inferInsert;
|