Matt
221ae5784e
Bundles the prior autonomous-session output that was sitting unstaged: - Em-dash sweep across src/ + tests/ (en-dash/em-dash to hyphen, ~2280 instances) - country-flag-icons rollout (CountryFlag component, replaces emoji glyphs that never rendered on Windows; lazy-loads the 3x2 SVG index as a single chunk after the per-subpath dynamic-import approach silently failed in webpack) - Admin IA Phase 1+2: 7-domain regroup, 41 to 38 pages, /admin/berths index, redirects (ocr to ai, reports to dashboard, invitations to users), docs/admin-ia-proposal.md - Per-template email tester (registry + endpoint + UI on Email admin page) - Cancel-document mode picker (delete-from-Documenso vs keep-for-audit) - Dashboard PDF report: 25 widgets, SVG charts, date-range picker, 11 resolvers - Customize-widgets per-region sortables at xl+ (charts/rails/feed); single flat sortable below xl when the layout stacks; per-viewport saved orders - Audit doc updates capturing each shipped item - Lint fixes: react-compiler immutability in DonutChart (reduce instead of let-reassign), set-state-in-effect disables in CountryFlag and UploadForSigning preview-bytes effect, unused 'confirm' destructures in interest contract + reservation tabs, unescaped apostrophe in test-template card copy
90 lines
3.0 KiB
TypeScript
90 lines
3.0 KiB
TypeScript
/**
|
|
* Security regression: dismissAlert / acknowledgeAlert must filter by
|
|
* portId so an alert UUID from port A can't be mutated by a session
|
|
* scoped to port B.
|
|
*/
|
|
|
|
import { describe, it, expect, beforeAll } from 'vitest';
|
|
import { eq } from 'drizzle-orm';
|
|
|
|
import { db } from '@/lib/db';
|
|
import { alerts } from '@/lib/db/schema/insights';
|
|
import { user } from '@/lib/db/schema/users';
|
|
import { dismissAlert, acknowledgeAlert } from '@/lib/services/alerts.service';
|
|
import { makePort } from '../helpers/factories';
|
|
|
|
let TEST_USER_ID = '';
|
|
|
|
beforeAll(async () => {
|
|
// dismissedBy / acknowledgedBy reference user.id; pull any seeded user.
|
|
const [u] = await db.select({ id: user.id }).from(user).limit(1);
|
|
if (!u) throw new Error('No user available; run pnpm db:seed first');
|
|
TEST_USER_ID = u.id;
|
|
});
|
|
|
|
async function makeAlert(portId: string) {
|
|
const [row] = await db
|
|
.insert(alerts)
|
|
.values({
|
|
portId,
|
|
ruleId: 'document_overdue',
|
|
severity: 'medium',
|
|
title: 'Test alert',
|
|
link: '/test',
|
|
fingerprint: `fp-${Math.random().toString(36).slice(2)}`,
|
|
metadata: {},
|
|
})
|
|
.returning({ id: alerts.id });
|
|
if (!row) throw new Error('failed to insert alert');
|
|
return row.id;
|
|
}
|
|
|
|
describe('alerts service - tenant isolation', () => {
|
|
it('dismissAlert is a no-op when called with the wrong portId', async () => {
|
|
const portA = await makePort();
|
|
const portB = await makePort();
|
|
const alertId = await makeAlert(portA.id);
|
|
|
|
// Attacker session scoped to port B tries to dismiss port A's alert.
|
|
await dismissAlert(alertId, portB.id, TEST_USER_ID);
|
|
|
|
const after = await db.query.alerts.findFirst({ where: eq(alerts.id, alertId) });
|
|
expect(after?.dismissedAt).toBeNull();
|
|
expect(after?.dismissedBy).toBeNull();
|
|
});
|
|
|
|
it('dismissAlert succeeds when portId matches', async () => {
|
|
const port = await makePort();
|
|
const alertId = await makeAlert(port.id);
|
|
|
|
await dismissAlert(alertId, port.id, TEST_USER_ID);
|
|
|
|
const after = await db.query.alerts.findFirst({ where: eq(alerts.id, alertId) });
|
|
expect(after?.dismissedAt).not.toBeNull();
|
|
expect(after?.dismissedBy).toBe(TEST_USER_ID);
|
|
});
|
|
|
|
it('acknowledgeAlert is a no-op when called with the wrong portId', async () => {
|
|
const portA = await makePort();
|
|
const portB = await makePort();
|
|
const alertId = await makeAlert(portA.id);
|
|
|
|
await acknowledgeAlert(alertId, portB.id, TEST_USER_ID);
|
|
|
|
const after = await db.query.alerts.findFirst({ where: eq(alerts.id, alertId) });
|
|
expect(after?.acknowledgedAt).toBeNull();
|
|
expect(after?.acknowledgedBy).toBeNull();
|
|
});
|
|
|
|
it('acknowledgeAlert succeeds when portId matches', async () => {
|
|
const port = await makePort();
|
|
const alertId = await makeAlert(port.id);
|
|
|
|
await acknowledgeAlert(alertId, port.id, TEST_USER_ID);
|
|
|
|
const after = await db.query.alerts.findFirst({ where: eq(alerts.id, alertId) });
|
|
expect(after?.acknowledgedAt).not.toBeNull();
|
|
expect(after?.acknowledgedBy).toBe(TEST_USER_ID);
|
|
});
|
|
});
|