Replaces per-row fan-out with grouped queries / inArray pre-fetches
across the five dashboard + cron hotspots flagged in the audit
(MED §13 / HIGH §11–14):
* reminders.processFollowUpReminders — was 3 round trips per
enabled-and-due interest. Now: filter in JS, single clients
bulk-fetch, single reminders bulk-insert, single interests
bulk-update, one summary socket emit. 1k due interests: 6 round
trips total instead of 3000+.
* portal.getClientInvoices — was a full-table scan filtered in JS.
Now an inArray push-down on lower(billingEmail) + defensive
limit(100). After 12mo this would have been the worst portal
endpoint.
* interest-scoring.calculateBulkScores — was 6N round trips
(1 redis + 1 findFirst + 4 counts per interest). Now 4 grouped
count queries on the port's interest set + a single redis pipeline
to refresh the cache. 1k interests: ~7 round trips.
* document-reminders.processReminderQueue — was 5N round trips per
cron tick (port + template + lastReminder + pendingSigners + send
per doc). Now hoists port + per-type template map + grouped
lastReminder + bulk pendingSigners; per-row work collapses to a
Map.get and the documenso send. 500 docs: ~7 round trips.
* inquiry-notifications.sendInquiryNotifications — was sequential
createNotification + emailQueue.add per recipient inside a public
POST. Now Promise.all'd; a 20-user port stops blocking the public
inquiry POST on ~80 round trips.
Test status: 1168/1168 vitest, tsc clean.
Refs: docs/audit-comprehensive-2026-05-05.md HIGH §§11–14 (auditor-I
Issues 1–4) + MED §13 (auditor-I Issue 5).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replaces every em-dash and en-dash with regular ASCII hyphens
across comments, JSX strings, and dev-facing logs. Mostly cosmetic
but stops the inconsistent mix that crept in over the last few
months (some files used em-dashes in comments, others didn't,
some used both).
Bundles two small dashboard-layout tweaks that touch a couple of
already-modified files:
- (dashboard)/layout.tsx main padding goes from p-6 to pt-3 px-6
pb-6 so page content sits closer to the topbar.
- Sidebar now receives the ports list it needs for the footer
port switcher.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
isReminderDue now keys off doc.remindersDisabled and the effective
cadence (per-doc override → template default), dropping the implicit
interests.reminderEnabled gate so non-EOI docs auto-remind correctly.
sendReminderIfAllowed gains an options bag — auto:true keeps the 9-16
window + cadence cooldown for the cron, auto:false bypasses both for
manual UI sends. signerId targets a specific pending signer (must be
next in sequential mode). 7 unit tests cover the cadence math.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
