letsbe/pn-new-crm
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(yachts): run owner existence check inside transaction

Browse Source
This commit is contained in:
Matt Ciaccio
2026-04-23 23:46:03 +02:00
parent 2f2ad4452f
commit feacb8c7ac
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/lib/services/yachts.service.ts
View File

@@ -20,14 +20,15 @@ interface AuditMeta {
async function assertOwnerExists( async function assertOwnerExists(
portId: string, portId: string,
owner: { type: 'client' | 'company'; id: string }, owner: { type: 'client' | 'company'; id: string },
tx: typeof db,
): Promise<void> { ): Promise<void> {
if (owner.type === 'client') { if (owner.type === 'client') {
const client = await db.query.clients.findFirst({ const client = await tx.query.clients.findFirst({
where: and(eq(clients.id, owner.id), eq(clients.portId, portId)), where: and(eq(clients.id, owner.id), eq(clients.portId, portId)),
}); });
if (!client) throw new ValidationError('owner not found'); if (!client) throw new ValidationError('owner not found');
} else { } else {
const company = await db.query.companies.findFirst({ const company = await tx.query.companies.findFirst({
where: and(eq(companies.id, owner.id), eq(companies.portId, portId)), where: and(eq(companies.id, owner.id), eq(companies.portId, portId)),
}); });
if (!company) throw new ValidationError('owner not found'); if (!company) throw new ValidationError('owner not found');
@@ -36,7 +37,7 @@ async function assertOwnerExists(
export async function createYacht(portId: string, data: CreateYachtInput, meta: AuditMeta) { export async function createYacht(portId: string, data: CreateYachtInput, meta: AuditMeta) {
return await db.transaction(async (tx) => { return await db.transaction(async (tx) => {
await assertOwnerExists(portId, data.owner); await assertOwnerExists(portId, data.owner, tx as unknown as typeof db);
const [yacht] = await tx const [yacht] = await tx
.insert(yachts) .insert(yachts)