fix(audit-tier-2): error-surface hygiene — toastError + CodedError sweep

Two mechanical sweeps closing the audit's HIGH §16 + MED §11 findings:

* 38 client components / 56 toast.error sites converted to
  toastError(err) so the new admin error inspector becomes usable from
  user-reported issues — every failed inline-edit, save, send, archive,
  upload, etc. now carries the request-id + error-code (Copy ID action).
* 26 service files / 62 bare-Error throws converted to CodedError or
  the existing AppError subclasses.  Adds new error codes:
  DOCUMENSO_UPSTREAM_ERROR (502), DOCUMENSO_AUTH_FAILURE (502),
  DOCUMENSO_TIMEOUT (504), OCR_UPSTREAM_ERROR (502),
  IMAP_UPSTREAM_ERROR (502), UMAMI_UPSTREAM_ERROR (502),
  UMAMI_NOT_CONFIGURED (409), and INSERT_RETURNING_EMPTY (500) for
  post-insert returning-empty guards.
* Five vitest assertions updated to match the new user-facing wording
  (client-merge "already been merged", expense/interest "couldn't find
  that …", documenso "signing service didn't respond").

Test status: 1168/1168 vitest, tsc clean.

Refs: docs/audit-comprehensive-2026-05-05.md HIGH §16 (auditor-H Issue 1)
+ MED §11 (auditor-G Issue 1).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Ciaccio
2026-05-05 20:18:05 +02:00
parent 6a609ecf94
commit fc7595faf8
69 changed files with 426 additions and 166 deletions

View File

@@ -12,6 +12,7 @@ import { Switch } from '@/components/ui/switch';
import { Sheet, SheetContent, SheetFooter, SheetHeader, SheetTitle } from '@/components/ui/sheet';
import { ConfirmationDialog } from '@/components/shared/confirmation-dialog';
import { apiFetch } from '@/lib/api/client';
import { toastError } from '@/lib/api/toast-error';
interface Invite {
id: string;
@@ -56,7 +57,7 @@ export function InvitationsManager() {
setIsSuperAdmin(false);
qc.invalidateQueries({ queryKey: ['admin', 'invitations'] });
},
onError: (err) => toast.error(err instanceof Error ? err.message : 'Failed to send invite'),
onError: (err) => toastError(err),
});
const resendMutation = useMutation({
@@ -66,7 +67,7 @@ export function InvitationsManager() {
toast.success('Invite resent');
qc.invalidateQueries({ queryKey: ['admin', 'invitations'] });
},
onError: (err) => toast.error(err instanceof Error ? err.message : 'Failed to resend'),
onError: (err) => toastError(err),
});
const revokeMutation = useMutation({
@@ -75,7 +76,7 @@ export function InvitationsManager() {
toast.success('Invite revoked');
qc.invalidateQueries({ queryKey: ['admin', 'invitations'] });
},
onError: (err) => toast.error(err instanceof Error ? err.message : 'Failed to revoke'),
onError: (err) => toastError(err),
});
return (