feat(invoices): remove client-facing PDF generation
Phase 1 / commit 11 of 14 — invoices are client-facing documents, and
per the new "no CRM-generated client-facing PDFs" rule (see the design
spec), the in-app pdfme rendering is removed entirely.
Future invoice rendering will use the deferred AcroForm-fill admin-
template feature: admin uploads a PDF template with named form fields,
CRM fills them with invoice data via pdf-lib. Same pattern as the
in-app EOI pathway. Tracked in BACKLOG.md.
Deleted:
- src/lib/services/invoices.ts:generateInvoicePdf (60 LOC)
- src/lib/pdf/templates/invoice-template.ts (entire pdfme template)
- src/app/api/v1/invoices/[id]/generate-pdf/route.ts
- src/components/invoices/invoice-pdf-preview.tsx (regenerate UI)
- "PDF Preview" tab on invoice detail page
- 5 now-unused imports in invoices.ts (files, ports, buildStoragePath,
getStorageBackend, env)
sendInvoice() retained: still queues the send-invoice email job, still
flips status to "sent", still emits the socket event. The PDF-attach
step is gone — downstream consumers either render externally or wait
for the AcroForm-fill feature. The `pdfFileId` column on invoices stays
so existing rows don't break, just never gets written by this code path.
1319/1319 vitest green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -3,8 +3,6 @@ import type { PgColumn } from 'drizzle-orm/pg-core';
|
||||
|
||||
import { db } from '@/lib/db';
|
||||
import { invoices, invoiceLineItems, invoiceExpenses, expenses } from '@/lib/db/schema/financial';
|
||||
import { files } from '@/lib/db/schema/documents';
|
||||
import { ports } from '@/lib/db/schema/ports';
|
||||
import { systemSettings } from '@/lib/db/schema/system';
|
||||
import { clients, clientAddresses } from '@/lib/db/schema/clients';
|
||||
import { companies, companyAddresses } from '@/lib/db/schema/companies';
|
||||
@@ -17,12 +15,7 @@ import { getCountryName } from '@/lib/i18n/countries';
|
||||
import { getSubdivisionName } from '@/lib/i18n/subdivisions';
|
||||
import { emitToRoom } from '@/lib/socket/server';
|
||||
import { logger } from '@/lib/logger';
|
||||
import { generatePdf } from '@/lib/pdf/generate';
|
||||
import { invoiceTemplate, buildInvoiceInputs } from '@/lib/pdf/templates/invoice-template';
|
||||
import { buildStoragePath } from '@/lib/minio';
|
||||
import { getStorageBackend } from '@/lib/storage';
|
||||
import { getQueue } from '@/lib/queue';
|
||||
import { env } from '@/lib/env';
|
||||
import type {
|
||||
CreateInvoiceInput,
|
||||
UpdateInvoiceInput,
|
||||
@@ -588,83 +581,17 @@ export async function deleteInvoice(id: string, portId: string, meta: AuditMeta)
|
||||
});
|
||||
}
|
||||
|
||||
// ─── Generate PDF ─────────────────────────────────────────────────────────
|
||||
|
||||
export async function generateInvoicePdf(id: string, portId: string, meta: AuditMeta) {
|
||||
const invoice = await getInvoiceById(id, portId);
|
||||
|
||||
const [port] = await db
|
||||
.select({ id: ports.id, name: ports.name, slug: ports.slug })
|
||||
.from(ports)
|
||||
.where(eq(ports.id, portId))
|
||||
.limit(1);
|
||||
|
||||
const inputs = buildInvoiceInputs(invoice, invoice.lineItems, port ?? {});
|
||||
|
||||
const pdfBytes = await generatePdf(invoiceTemplate, [inputs]);
|
||||
|
||||
const fileId = crypto.randomUUID();
|
||||
const storagePath = buildStoragePath(port?.slug ?? portId, 'invoices', id, fileId, 'pdf');
|
||||
|
||||
const buffer = Buffer.from(pdfBytes);
|
||||
const backend = await getStorageBackend();
|
||||
await backend.put(storagePath, buffer, {
|
||||
contentType: 'application/pdf',
|
||||
sizeBytes: buffer.length,
|
||||
});
|
||||
|
||||
const [fileRecord] = await db
|
||||
.insert(files)
|
||||
.values({
|
||||
portId,
|
||||
filename: `invoice-${invoice.invoiceNumber}.pdf`,
|
||||
originalName: `invoice-${invoice.invoiceNumber}.pdf`,
|
||||
mimeType: 'application/pdf',
|
||||
sizeBytes: String(pdfBytes.length),
|
||||
storagePath,
|
||||
storageBucket: env.MINIO_BUCKET,
|
||||
category: 'invoice',
|
||||
uploadedBy: meta.userId,
|
||||
})
|
||||
.returning();
|
||||
|
||||
if (!fileRecord)
|
||||
throw new CodedError('INSERT_RETURNING_EMPTY', {
|
||||
internalMessage: 'Invoice PDF file record insert returned no row',
|
||||
});
|
||||
|
||||
await db
|
||||
.update(invoices)
|
||||
.set({ pdfFileId: fileRecord.id, updatedAt: new Date() })
|
||||
.where(and(eq(invoices.id, id), eq(invoices.portId, portId)));
|
||||
|
||||
void createAuditLog({
|
||||
userId: meta.userId,
|
||||
portId,
|
||||
action: 'update',
|
||||
entityType: 'invoice',
|
||||
entityId: id,
|
||||
metadata: { action: 'pdf_generated', fileId: fileRecord.id },
|
||||
ipAddress: meta.ipAddress,
|
||||
userAgent: meta.userAgent,
|
||||
});
|
||||
|
||||
return fileRecord;
|
||||
}
|
||||
|
||||
// ─── Send invoice ─────────────────────────────────────────────────────────
|
||||
|
||||
export async function sendInvoice(id: string, portId: string, meta: AuditMeta) {
|
||||
const invoice = await getInvoiceById(id, portId);
|
||||
|
||||
// Generate PDF if not exists
|
||||
let pdfFileId = invoice.pdfFileId;
|
||||
if (!pdfFileId) {
|
||||
const fileRecord = await generateInvoicePdf(id, portId, meta);
|
||||
pdfFileId = fileRecord.id;
|
||||
}
|
||||
|
||||
// Queue email job
|
||||
// Invoice PDF generation has been removed (the CRM no longer renders
|
||||
// client-facing PDFs from scratch — see the PDF stack overhaul spec).
|
||||
// The "send" event still fires so the queue + audit + socket flow
|
||||
// remains intact; downstream consumers can decide whether to render
|
||||
// an external document, link to the in-app view, or wait for the
|
||||
// admin-uploaded AcroForm-fill feature to ship.
|
||||
await getQueue('email').add('send-invoice', { invoiceId: id, portId });
|
||||
|
||||
// Update status to 'sent'
|
||||
|
||||
Reference in New Issue
Block a user