letsbe/pn-new-crm
1
0
Fork 0
Code Issues Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

fix(tests): smoke specs use page.request for auth-cookie carryover

Browse Source 
The bare `request` fixture is an isolated API context that does not
share the browser session cookie established by login(). Result: every
API call hit withAuth and 401'd, and the tests silently skipped
themselves through the existing graceful-skip guards — the assertions
never ran. Switching to page.request shares the browser context cookie
jar, so the API calls now reach the handler and the assertions execute.

Also adds a conditional "view signing details" trigger assertion
behind a feature-flag-style check so future signed-file seed fixtures
exercise the SigningDetailsDialog path automatically.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt
2026-05-11 12:59:01 +02:00
parent b598740b2a
commit eceb77a6c4
2 changed files with 33 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
tests/e2e/smoke/04-documents-hub-upload-into-entity.spec.ts
View File

@@ -24,12 +24,14 @@ test.describe('Documents hub — upload into entity folder', () => {
test('file uploaded with clientId appears in the client entity folder view', async ({
page,
request,
}) => {
const headers = await apiHeaders(page);
// 1. Create a client.
const clientRes = await request.post('/api/v1/clients', {
// page.request shares the browser context cookie jar (session cookie from
// login()) — the bare `request` fixture is an isolated API context that
// does not carry the session cookie and would 401.
const clientRes = await page.request.post('/api/v1/clients', {
headers,
data: {
firstName: 'UploadSmoke',
@@ -38,10 +40,7 @@ test.describe('Documents hub — upload into entity folder', () => {
},
});
if (!clientRes.ok()) {
test.skip(
true,
`Client create returned ${clientRes.status()} — upload test skipped`,
);
test.skip(true, `Client create returned ${clientRes.status()} — upload test skipped`);
return;
}
const { data: client } = (await clientRes.json()) as {
@@ -66,7 +65,6 @@ test.describe('Documents hub — upload into entity folder', () => {
const uploadRes = await page.request.fetch('/api/v1/files/upload', {
method: 'POST',
headers: {
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
'X-Port-Id': headers['X-Port-Id']!,
},
multipart: {
@@ -92,10 +90,7 @@ test.describe('Documents hub — upload into entity folder', () => {
await page.waitForLoadState('networkidle');
// 4. Expand the Clients system root.
const expandBtn = page
.locator('aside')
.getByRole('button', { name: 'Expand' })
.first();
const expandBtn = page.locator('aside').getByRole('button', { name: 'Expand' }).first();
await expect(expandBtn).toBeVisible({ timeout: 10_000 });
await expandBtn.click();
@@ -116,15 +111,15 @@ test.describe('Documents hub — upload into entity folder', () => {
await expect(page.getByText('test-document.txt')).toBeVisible({ timeout: 10_000 });
});
test('file uploaded with folderId (entity folder) auto-sets client_id', async ({
page,
request,
}) => {
test('file uploaded with folderId (entity folder) auto-sets client_id', async ({ page }) => {
const headers = await apiHeaders(page);
// 1. Create a client — ensureEntityFolder is triggered server-side when
// the first file is uploaded with clientId or directly by the create hook.
const clientRes = await request.post('/api/v1/clients', {
// page.request shares the browser context cookie jar (session cookie from
// login()) — the bare `request` fixture is an isolated API context that
// does not carry the session cookie and would 401.
const clientRes = await page.request.post('/api/v1/clients', {
headers,
data: {
firstName: 'FolderIdSmoke',
@@ -162,10 +157,9 @@ test.describe('Documents hub — upload into entity folder', () => {
}
// 3. List files for this client to discover the folder id.
const listRes = await request.get(
`/api/v1/files?entityType=client&entityId=${client.id}`,
{ headers },
);
const listRes = await page.request.get(`/api/v1/files?entityType=client&entityId=${client.id}`, {
headers,
});
if (!listRes.ok()) {
test.skip(true, `File list returned ${listRes.status()} — folderId test skipped`);
return;
@@ -176,10 +170,7 @@ test.describe('Documents hub — upload into entity folder', () => {
await page.waitForLoadState('networkidle');
// Expand Clients and click entity folder.
const expandBtn = page
.locator('aside')
.getByRole('button', { name: 'Expand' })
.first();
const expandBtn = page.locator('aside').getByRole('button', { name: 'Expand' }).first();
await expect(expandBtn).toBeVisible({ timeout: 10_000 });
await expandBtn.click();