feat(post-audit): Phase 3 EOI overrides + 3c spawn + 3d promote + Phase 4 worker
Phase 3b — EOI dialog field overrides:
- New EoiOverridesInput shape (clientEmail / clientPhone / yachtName)
threaded through generate-and-sign validator + both pathways
(in-app pdf-lib fill, Documenso template generate).
- src/lib/services/eoi-overrides.service.ts applies side-effects in one
transaction: useOnlyForThisEoi writes documents.override_* and stops;
setAsDefault demotes the prior primary + promotes (existing contactId)
or inserts + promotes (fresh value); neither flag inserts a non-primary
client_contacts row for future dropdown reuse.
- Document override columns persisted post-insert, with a 1-minute
source_document_id backfill on freshly inserted contact rows.
- eoi-context route returns available.{emails, phones} so the dialog
can render combobox options.
- <OverridableContactField> in eoi-generate-dialog.tsx renders the
combobox + manual input + 2 checkboxes per field with mutually
exclusive intent semantics.
Phase 3c — yacht spawn from EOI dialog:
- YachtForm gains createExtras + onCreated callbacks; the EOI dialog
opens it as a nested Sheet pre-filled with the linked client as owner.
On save the new yacht is stamped source='eoi-generated' and the
interest is PATCHed with the new yachtId so the EOI context reflows.
Phase 3d — promote-to-primary + audit + [EOI] badge:
- POST /api/v1/clients/:id/contacts/:contactId/promote-to-primary
(transactional demote+promote via promoteContactToPrimary).
- src/lib/audit.ts AuditAction type adds eoi_field_override,
promote_to_primary, eoi_spawn_yacht (DB column is free-text).
- ContactsEditor surfaces an [EOI] badge on non-primary rows where
source='eoi-custom-input'.
Phase 4 — worker + TOD picker:
- processOverdueReminders refactored to UPDATE...RETURNING with a
fired_at IS NULL gate so parallel workers can't double-fire. Uses
the idx_reminders_due_unfired partial index from migration 0072.
- /settings gets a "Default reminder time" time-of-day picker; the
value lands in user_profiles.preferences.digestTimeOfDay (validated
HH:MM at the route). <ReminderForm> seeds its dueAt from this
preference via a React-Query me-prefs fetch.
Phase 6 hardening:
- IMAP bounce poller strips whitespace from IMAP_PASS so a copy-paste
of Google Workspace's 16-char App Password formatted as
"abcd efgh ijkl mnop" still authenticates. Workspace activation
procedure documented in MASTER-PLAN §Phase 6 (was previously written
to CLAUDE.md, which was bloat — moved to the plan).
Quality gates: 1374/1374 vitest, tsc clean, lint 0 errors.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -58,11 +58,35 @@ interface YachtFormProps {
|
||||
* owner-history workflow is the right surface for ownership changes).
|
||||
*/
|
||||
initialOwner?: { type: 'client' | 'company'; id: string };
|
||||
/**
|
||||
* Phase 3c — extra fields baked into the create POST. Lets the EOI
|
||||
* spawn flow stamp the new yacht with `source='eoi-generated'` (and
|
||||
* optionally `sourceDocumentId` when the calling document is already
|
||||
* persisted) without exposing those fields in the form UI.
|
||||
*/
|
||||
createExtras?: Partial<{
|
||||
source: 'manual' | 'imported' | 'eoi-generated';
|
||||
sourceDocumentId: string;
|
||||
}>;
|
||||
/**
|
||||
* Phase 3c — called with the new yacht's id/name after a successful
|
||||
* create POST, BEFORE the dialog closes. The EOI spawn flow uses this
|
||||
* to PATCH the interest's yachtId so the EOI re-fetches with the
|
||||
* just-spawned yacht in scope.
|
||||
*/
|
||||
onCreated?: (yacht: { id: string; name: string }) => void | Promise<void>;
|
||||
}
|
||||
|
||||
type YachtStatus = 'active' | 'retired' | 'sold_away';
|
||||
|
||||
export function YachtForm({ open, onOpenChange, yacht, initialOwner }: YachtFormProps) {
|
||||
export function YachtForm({
|
||||
open,
|
||||
onOpenChange,
|
||||
yacht,
|
||||
initialOwner,
|
||||
createExtras,
|
||||
onCreated,
|
||||
}: YachtFormProps) {
|
||||
const queryClient = useQueryClient();
|
||||
const isEdit = !!yacht;
|
||||
const [formError, setFormError] = useState<string | null>(null);
|
||||
@@ -135,12 +159,19 @@ export function YachtForm({ open, onOpenChange, yacht, initialOwner }: YachtForm
|
||||
method: 'PATCH',
|
||||
body: rest,
|
||||
});
|
||||
} else {
|
||||
await apiFetch('/api/v1/yachts', { method: 'POST', body: data });
|
||||
return null;
|
||||
}
|
||||
const created = await apiFetch<{ data: { id: string; name: string } }>('/api/v1/yachts', {
|
||||
method: 'POST',
|
||||
body: { ...data, ...(createExtras ?? {}) },
|
||||
});
|
||||
return created.data;
|
||||
},
|
||||
onSuccess: () => {
|
||||
onSuccess: async (created) => {
|
||||
queryClient.invalidateQueries({ queryKey: ['yachts'] });
|
||||
if (created && onCreated) {
|
||||
await onCreated(created);
|
||||
}
|
||||
onOpenChange(false);
|
||||
},
|
||||
onError: (err: Error) => {
|
||||
|
||||
Reference in New Issue
Block a user