feat(post-audit): Phase 3 EOI overrides + 3c spawn + 3d promote + Phase 4 worker
Phase 3b — EOI dialog field overrides:
- New EoiOverridesInput shape (clientEmail / clientPhone / yachtName)
threaded through generate-and-sign validator + both pathways
(in-app pdf-lib fill, Documenso template generate).
- src/lib/services/eoi-overrides.service.ts applies side-effects in one
transaction: useOnlyForThisEoi writes documents.override_* and stops;
setAsDefault demotes the prior primary + promotes (existing contactId)
or inserts + promotes (fresh value); neither flag inserts a non-primary
client_contacts row for future dropdown reuse.
- Document override columns persisted post-insert, with a 1-minute
source_document_id backfill on freshly inserted contact rows.
- eoi-context route returns available.{emails, phones} so the dialog
can render combobox options.
- <OverridableContactField> in eoi-generate-dialog.tsx renders the
combobox + manual input + 2 checkboxes per field with mutually
exclusive intent semantics.
Phase 3c — yacht spawn from EOI dialog:
- YachtForm gains createExtras + onCreated callbacks; the EOI dialog
opens it as a nested Sheet pre-filled with the linked client as owner.
On save the new yacht is stamped source='eoi-generated' and the
interest is PATCHed with the new yachtId so the EOI context reflows.
Phase 3d — promote-to-primary + audit + [EOI] badge:
- POST /api/v1/clients/:id/contacts/:contactId/promote-to-primary
(transactional demote+promote via promoteContactToPrimary).
- src/lib/audit.ts AuditAction type adds eoi_field_override,
promote_to_primary, eoi_spawn_yacht (DB column is free-text).
- ContactsEditor surfaces an [EOI] badge on non-primary rows where
source='eoi-custom-input'.
Phase 4 — worker + TOD picker:
- processOverdueReminders refactored to UPDATE...RETURNING with a
fired_at IS NULL gate so parallel workers can't double-fire. Uses
the idx_reminders_due_unfired partial index from migration 0072.
- /settings gets a "Default reminder time" time-of-day picker; the
value lands in user_profiles.preferences.digestTimeOfDay (validated
HH:MM at the route). <ReminderForm> seeds its dueAt from this
preference via a React-Query me-prefs fetch.
Phase 6 hardening:
- IMAP bounce poller strips whitespace from IMAP_PASS so a copy-paste
of Google Workspace's 16-char App Password formatted as
"abcd efgh ijkl mnop" still authenticates. Workspace activation
procedure documented in MASTER-PLAN §Phase 6 (was previously written
to CLAUDE.md, which was bloat — moved to the plan).
Quality gates: 1374/1374 vitest, tsc clean, lint 0 errors.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -85,6 +85,20 @@ function ReminderFormBody({
|
||||
onSuccess,
|
||||
}: ReminderFormProps) {
|
||||
const isEdit = !!reminder;
|
||||
// Phase 4 — load the rep's preferred default-reminder time (HH:MM)
|
||||
// BEFORE seeding the dueAt state. React Query's cache keeps this
|
||||
// available synchronously on subsequent dialog opens (staleTime 60s)
|
||||
// so the initial value is the rep's preference, not the historical
|
||||
// 09:00 fallback. Enabled only on create-mode opens — edit mode
|
||||
// already has the existing dueAt to seed from.
|
||||
const meQuery = useQuery<{ data: { preferences?: { digestTimeOfDay?: string } } }>({
|
||||
queryKey: ['me', 'preferences'],
|
||||
queryFn: () => apiFetch('/api/v1/me'),
|
||||
enabled: open && !reminder,
|
||||
staleTime: 60_000,
|
||||
});
|
||||
const userTodPref = meQuery.data?.data.preferences?.digestTimeOfDay ?? null;
|
||||
|
||||
// Tomorrow 9am default for new-reminder dueAt.
|
||||
//
|
||||
// <input type="datetime-local"> takes/produces LOCAL wall-clock time
|
||||
@@ -97,9 +111,20 @@ function ReminderFormBody({
|
||||
const defaultDueAt = useMemo(() => {
|
||||
const t = new Date();
|
||||
t.setDate(t.getDate() + 1);
|
||||
t.setHours(9, 0, 0, 0);
|
||||
// Honour the rep's user_profiles.preferences.digestTimeOfDay when
|
||||
// set ("HH:MM"). Falls back to 09:00 — historical default.
|
||||
let h = 9;
|
||||
let m = 0;
|
||||
if (userTodPref && /^\d{2}:\d{2}$/.test(userTodPref)) {
|
||||
const [hh = '09', mm = '00'] = userTodPref.split(':');
|
||||
const parsedH = Number.parseInt(hh, 10);
|
||||
const parsedM = Number.parseInt(mm, 10);
|
||||
if (Number.isFinite(parsedH) && parsedH >= 0 && parsedH <= 23) h = parsedH;
|
||||
if (Number.isFinite(parsedM) && parsedM >= 0 && parsedM <= 59) m = parsedM;
|
||||
}
|
||||
t.setHours(h, m, 0, 0);
|
||||
return toLocalDatetimeLocal(t);
|
||||
}, []);
|
||||
}, [userTodPref]);
|
||||
const [title, setTitle] = useState(reminder?.title ?? '');
|
||||
const [note, setNote] = useState(reminder?.note ?? '');
|
||||
const [dueAt, setDueAt] = useState(
|
||||
|
||||
Reference in New Issue
Block a user