fix(P1): GDPR export + Redis eviction policy
F3: BullMQ 5.x rejects custom job IDs containing `:` (collides with internal Redis-key namespacing). GDPR export crashed with "Custom Id cannot contain :". Switched to dash separator. GDPR Article 15 right-to-access now functional. F4: Redis was configured with `allkeys-lru` eviction in both docker-compose.yml and docker-compose.prod.yml. BullMQ explicitly requires `noeviction` — otherwise queue keys can be evicted under memory pressure and jobs vanish silently. Switched to noeviction with comment pointing at the audit finding. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -32,7 +32,9 @@ services:
|
|||||||
|
|
||||||
redis:
|
redis:
|
||||||
image: redis:7-alpine
|
image: redis:7-alpine
|
||||||
command: redis-server --requirepass ${REDIS_PASSWORD} --maxmemory 256mb --maxmemory-policy allkeys-lru
|
# BullMQ requires `noeviction` — under memory pressure, allkeys-lru
|
||||||
|
# silently drops queue keys and jobs disappear. See post-audit fix F4.
|
||||||
|
command: redis-server --requirepass ${REDIS_PASSWORD} --maxmemory 256mb --maxmemory-policy noeviction
|
||||||
volumes:
|
volumes:
|
||||||
- redisdata:/data
|
- redisdata:/data
|
||||||
healthcheck:
|
healthcheck:
|
||||||
|
|||||||
@@ -18,7 +18,9 @@ services:
|
|||||||
|
|
||||||
redis:
|
redis:
|
||||||
image: redis:7-alpine
|
image: redis:7-alpine
|
||||||
command: redis-server --requirepass ${REDIS_PASSWORD} --maxmemory 256mb --maxmemory-policy allkeys-lru
|
# BullMQ requires `noeviction` — under memory pressure, allkeys-lru
|
||||||
|
# silently drops queue keys and jobs disappear. See post-audit fix F4.
|
||||||
|
command: redis-server --requirepass ${REDIS_PASSWORD} --maxmemory 256mb --maxmemory-policy noeviction
|
||||||
volumes:
|
volumes:
|
||||||
- redisdata:/data
|
- redisdata:/data
|
||||||
healthcheck:
|
healthcheck:
|
||||||
|
|||||||
@@ -110,7 +110,9 @@ export async function requestGdprExport(input: RequestExportInput): Promise<Requ
|
|||||||
emailToClient: input.emailToClient,
|
emailToClient: input.emailToClient,
|
||||||
emailOverride: input.emailOverride ?? null,
|
emailOverride: input.emailOverride ?? null,
|
||||||
},
|
},
|
||||||
{ jobId: `gdpr-export:${row.id}` },
|
// BullMQ 5.x rejects custom job IDs containing ':' (Redis-key collision).
|
||||||
|
// Dash-separator keeps the namespace + the UUID round-trip unambiguous.
|
||||||
|
{ jobId: `gdpr-export-${row.id}` },
|
||||||
);
|
);
|
||||||
|
|
||||||
return { export: row };
|
return { export: row };
|
||||||
|
|||||||
Reference in New Issue
Block a user