fix(tenancies-audit): resolve findings from 7-agent system-wide rename audit

MUST-FIX:
- src/app/api/v1/admin/users/[id]/permission-overrides/route.ts:70 — the
  PUT allowlist still gated `reservations: {view,create,activate,cancel}`.
  Stale: would reject valid `tenancies.{view,manage,cancel}` writes and
  silently accept ghost `reservations.*` writes that never land. Replaced.
- src/lib/services/alert-rules.ts:68 — `reservation.no_agreement` alert
  emitted `entityType: 'reservation'`. Every other tenancy-related
  audit/socket/dashboard label is `'berth_tenancy'`. Inconsistent dedupe
  + activity-feed label miss.
- tests/e2e/exhaustive/08-portal.spec.ts:6 — hardcoded /portal/my-reservations
  navigates to a 404 every run.
- tests/e2e/exhaustive/03-reservations.spec.ts — entire spec renamed to
  03-tenancies.spec.ts; tab + button locators updated to match renamed UI.

SHOULD-FIX (consistency):
- src/components/clients/client-detail.tsx — useRealtimeInvalidation only
  caught 3 of the 4 berth_tenancy:* events; added the `:created` listener.
- src/lib/services/client-merge.service.ts — MergeResult.movedRows.reservations
  + snapshot.reservations + local loserReservations / movedReservations
  renamed to tenancies / loserTenancies / movedTenancies. No external
  consumers grep-confirmed.
- src/lib/services/gdpr-bundle-builder.ts — GdprBundle.reservations field
  renamed to .tenancies; user-facing HTML section "Reservations" → "Tenancies";
  local reservationRows → tenancyRows.
- 6 UI copy strings: gdpr-export-button, bulk-archive-wizard,
  bulk-hard-delete-dialog, hard-delete-dialog, admin-sections-browser ×2,
  admin/import/page, won-status-panel — all "reservations" prose updated
  to "tenancies" (occupancy-record sense).
- tests/integration/api/tenancies.test.ts — handler import aliases
  `createReservationHandler` etc renamed to `createTenancyHandler` etc.
- tests/unit/services/berth-tenancies.test.ts — local helper makeReservation
  → makeTenancyLocal (avoids shadow of the renamed factory).
- scripts/audit-permissions.ts — stale allowlist entry for
  /berth-reservations/[id]/route.ts removed (path no longer exists).
- docs/runbooks/permission-audit.md — stale row for same path removed.
- docs/tenancies-design.md — fixed factual error
  ("tenancies.service.ts" → "berth-tenancies.service.ts").

Verified: tsc clean, 1493/1493 vitest.

Dev-server note: the running `next dev` process started before P2 and
shows Turbopack cached compile errors against the renamed schema files.
Source is correct (./tenancies); restart `next dev` to clear the cache.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

tests/e2e/exhaustive/03-tenancies.spec.ts

@@ -3,12 +3,12 @@ import { test, expect } from '@playwright/test';
 import { clickEverythingOnPage } from '../../helpers/click-everything';
 import { login, navigateTo, PORT_SLUG } from '../smoke/helpers';
 
-test.describe('exhaustive: berth reservations', () => {
+test.describe('exhaustive: berth tenancies', () => {
   test.beforeEach(async ({ page }) => {
     await login(page, 'super_admin');
   });
 
-  test('berths list - reservation-related affordances are clickable', async ({ page }) => {
+  test('berths list - tenancy-related affordances are clickable', async ({ page }) => {
     await navigateTo(page, '/berths');
     await page.waitForLoadState('networkidle');
 
@@ -16,7 +16,7 @@ test.describe('exhaustive: berth reservations', () => {
     expect(result.errors, JSON.stringify(result.errors, null, 2)).toEqual([]);
   });
 
-  test('berth detail - reservations tab opens and is interactive', async ({ page }) => {
+  test('berth detail - tenancies tab opens and is interactive', async ({ page }) => {
     await navigateTo(page, '/berths');
     await page.waitForLoadState('networkidle');
 
@@ -29,9 +29,9 @@ test.describe('exhaustive: berth reservations', () => {
     await page.waitForURL(new RegExp(`/${PORT_SLUG}/berths/[^/]+`), { timeout: 10_000 });
     await page.waitForLoadState('networkidle');
 
-    const reservationsTab = page.getByRole('tab', { name: /reservations/i }).first();
-    if (await reservationsTab.isVisible({ timeout: 3000 }).catch(() => false)) {
-      await reservationsTab.click();
+    const tenanciesTab = page.getByRole('tab', { name: /tenancies/i }).first();
+    if (await tenanciesTab.isVisible({ timeout: 3000 }).catch(() => false)) {
+      await tenanciesTab.click();
       await page.waitForLoadState('networkidle');
     }
 
@@ -39,7 +39,7 @@ test.describe('exhaustive: berth reservations', () => {
     expect(result.errors, JSON.stringify(result.errors, null, 2)).toEqual([]);
   });
 
-  test('reserve dialog opens and closes', async ({ page }) => {
+  test('create-tenancy dialog opens and closes', async ({ page }) => {
     await navigateTo(page, '/berths');
     await page.waitForLoadState('networkidle');
     const firstRow = page.locator('tbody tr a, tbody tr button').first();
@@ -50,9 +50,9 @@ test.describe('exhaustive: berth reservations', () => {
     await firstRow.click();
     await page.waitForLoadState('networkidle');
 
-    const reserveBtn = page.getByRole('button', { name: /reserve|new reservation/i }).first();
-    if (await reserveBtn.isVisible({ timeout: 3000 }).catch(() => false)) {
-      await reserveBtn.click();
+    const createBtn = page.getByRole('button', { name: /create tenancy|reserve/i }).first();
+    if (await createBtn.isVisible({ timeout: 3000 }).catch(() => false)) {
+      await createBtn.click();
       const dialog = page.getByRole('dialog');
       await expect(dialog).toBeVisible({ timeout: 5000 });
       const cancel = dialog.getByRole('button', { name: /cancel|close/i }).first();

tests/e2e/exhaustive/08-portal.spec.ts

@@ -3,7 +3,7 @@ import { test, expect } from '@playwright/test';
 import { clickEverythingOnPage } from '../../helpers/click-everything';
 import { login } from '../smoke/helpers';
 
-const PORTAL_PAGES = ['/portal/yachts', '/portal/memberships', '/portal/my-reservations'];
+const PORTAL_PAGES = ['/portal/yachts', '/portal/memberships', '/portal/my-tenancies'];
 
 test.describe('exhaustive: client portal', () => {
   test.beforeEach(async ({ page }) => {