feat(tenancies-p2): rename berth_reservations → berth_tenancies (schema + perms + UI)

73-file atomic rename per docs/tenancies-design.md:

- Migration 0085: rename table + indexes + FK constraints; rename
  documents.reservation_id → tenancy_id; migrate jsonb permission maps
  (reservations resource → tenancies; collapse create+activate → manage);
  rewrite historical audit_logs.entity_type='berth_reservation' →
  'berth_tenancy'. FK renames wrapped in DO blocks so dev DBs that pre-date
  the FK additions don't abort.
- Schema: berthReservations → berthTenancies; BerthReservation type →
  BerthTenancy; indexes idx_br_* / idx_brr_* → idx_bt_*.
- RolePermissions: resource { view, create, activate, cancel } collapses to
  { view, manage, cancel }; all 8 default seed bundles + role-form + matrix
  updated.
- Service: berth-reservations.service.ts → berth-tenancies.service.ts;
  endReservation → endTenancy; listReservations → listTenancies.
- API: /api/v1/berth-reservations → /api/v1/tenancies (+ nested [id]);
  /api/v1/berths/[id]/reservations → /api/v1/berths/[id]/tenancies.
- Validators: reservations.ts → tenancies.ts; RESERVATION_STATUSES →
  TENANCY_STATUSES; endReservationSchema → endTenancySchema.
- Routes: /{portSlug}/berth-reservations → /{portSlug}/tenancies;
  /portal/my-reservations → /portal/my-tenancies.
- Components: src/components/reservations/* → src/components/tenancies/*;
  BerthReservationsTab → BerthTenanciesTab; ClientReservationsTab →
  ClientTenanciesTab; ReservationList → TenancyList.
- Socket events: berth_reservation:* → berth_tenancy:*; payload
  reservationId → tenancyId.
- Webhook events: berth_reservation.* → berth_tenancy.*.
- Portal: getPortalUserReservations → getPortalUserTenancies;
  PortalReservation → PortalTenancy; PortalDashboard.counts.activeReservations
  → activeTenancies; PortalNav label "Reservations" → "Tenancies".
- Dossier: DossierReservation → DossierTenancy; reservationDecisions →
  tenancyDecisions across smart-archive-dialog + bulk-archive routes.
- Documents schema: documents.reservationId → documents.tenancyId
  (TS + DB column + index + FK constraint).
- Activity feed label berth_reservation → berth_tenancy (matched against
  migrated historical audit rows).

KEPT (separate concepts):
- Reservation Agreement document type (the contract sent to clients).
- "Reservation" pipeline stage name.
- {{reservation.*}} merge tokens in template authoring.
- interest.reservationStatus / reservationDocStatus / dateReservationSent
  fields (track agreement signing on the deal).
- reservation-agreement-context.ts service (builds merge context for the
  Reservation Agreement doc; only its DB imports were renamed).

Verified: tsc clean, 1480/1480 vitest passing, migration applied.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

src/lib/services/client-archive.service.ts

@@ -17,7 +17,7 @@ import { db } from '@/lib/db';
 import { clients } from '@/lib/db/schema/clients';
 import { interests, interestBerths } from '@/lib/db/schema/interests';
 import { berths } from '@/lib/db/schema/berths';
-import { berthReservations } from '@/lib/db/schema/reservations';
+import { berthTenancies } from '@/lib/db/schema/tenancies';
 import { invoices } from '@/lib/db/schema/financial';
 import { yachts } from '@/lib/db/schema/yachts';
 import { companyMemberships } from '@/lib/db/schema/companies';
@@ -49,8 +49,8 @@ export type YachtDecision = {
   newOwnerId?: string;
 };
 
-export type ReservationDecision = {
-  reservationId: string;
+export type TenancyDecision = {
+  tenancyId: string;
   action: 'cancel' | 'transfer';
   /** Required when action='transfer' - the new client id. */
   transferToClientId?: string;
@@ -73,7 +73,7 @@ export interface ArchiveDecisions {
   acknowledgedSignedDocuments: boolean;
   berthDecisions: BerthDecision[];
   yachtDecisions: YachtDecision[];
-  reservationDecisions: ReservationDecision[];
+  tenancyDecisions: TenancyDecision[];
   invoiceDecisions: InvoiceDecision[];
   documentDecisions: DocumentDecision[];
 }
@@ -87,8 +87,8 @@ interface PersistedDecision {
     | 'yacht_transferred'
     | 'yacht_marked_sold_away'
     | 'yacht_retained'
-    | 'reservation_cancelled'
-    | 'reservation_transferred'
+    | 'tenancy_cancelled'
+    | 'tenancy_transferred'
     | 'invoice_voided'
     | 'invoice_written_off'
     | 'invoice_left'
@@ -268,27 +268,25 @@ export async function archiveClientWithDecisions(args: {
       }
     }
 
-    // ─── Reservation decisions ───────────────────────────────────────────
-    for (const d of decisions.reservationDecisions) {
+    // ─── Tenancy decisions ───────────────────────────────────────────────
+    for (const d of decisions.tenancyDecisions) {
       if (d.action === 'cancel') {
         await tx
-          .update(berthReservations)
+          .update(berthTenancies)
           .set({ status: 'cancelled', updatedAt: new Date() })
-          .where(eq(berthReservations.id, d.reservationId));
-        persistedDecisions.push({ kind: 'reservation_cancelled', refId: d.reservationId });
+          .where(eq(berthTenancies.id, d.tenancyId));
+        persistedDecisions.push({ kind: 'tenancy_cancelled', refId: d.tenancyId });
       } else if (d.action === 'transfer') {
         if (!d.transferToClientId) {
-          throw new ValidationError(
-            `Reservation ${d.reservationId}: transfer requires transferToClientId`,
-          );
+          throw new ValidationError(`Tenancy ${d.tenancyId}: transfer requires transferToClientId`);
         }
         await tx
-          .update(berthReservations)
+          .update(berthTenancies)
           .set({ clientId: d.transferToClientId, updatedAt: new Date() })
-          .where(eq(berthReservations.id, d.reservationId));
+          .where(eq(berthTenancies.id, d.tenancyId));
         persistedDecisions.push({
-          kind: 'reservation_transferred',
-          refId: d.reservationId,
+          kind: 'tenancy_transferred',
+          refId: d.tenancyId,
           detail: { previousClientId: clientId, newClientId: d.transferToClientId },
         });
       }