fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions

View File

@@ -35,7 +35,7 @@ export function SavedViewsDropdown({ entityType, onApplyView }: SavedViewsDropdo
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button variant="outline" size="sm" className="h-8">
<Bookmark className="mr-1.5 h-3.5 w-3.5" />
<Bookmark className="mr-1.5 h-3.5 w-3.5" aria-hidden />
Views
</Button>
</DropdownMenuTrigger>
@@ -54,7 +54,9 @@ export function SavedViewsDropdown({ entityType, onApplyView }: SavedViewsDropdo
>
<span className="truncate">{view.name}</span>
<div className="flex items-center gap-1">
{activeViewId === view.id && <Check className="h-3.5 w-3.5 text-primary" />}
{activeViewId === view.id && (
<Check className="h-3.5 w-3.5 text-primary" aria-hidden />
)}
<button
className="p-0.5 rounded hover:bg-muted"
onClick={(e) => {
@@ -62,7 +64,7 @@ export function SavedViewsDropdown({ entityType, onApplyView }: SavedViewsDropdo
deleteView(view.id);
}}
>
<Trash2 className="h-3 w-3 text-muted-foreground" />
<Trash2 className="h-3 w-3 text-muted-foreground" aria-hidden />
</button>
</div>
</DropdownMenuItem>