fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line Lucide icon JSX elements across 267 .tsx files in: - shared/, layout/, dashboard/ - admin/ (all sections) - clients/, berths/, yachts/, companies/, interests/, documents/ - reminders/, reservations/, residential/, expenses/, email/ The regex targeted only the safe pattern \`<IconName className="..." />\` (no other props, self-closing, capitalized component name). Every match inspected is a decorative companion to visible text or sits inside a button whose accessible name comes from \`aria-label\` / sr-only text — the icon itself should not be announced. Screen readers no longer double-read the icon + the adjacent label text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing @axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues to pass. Test suite stays at 1315/1315 vitest. typescript clean. Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups backlog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -206,11 +206,11 @@ export function DataTable<TData>({
|
||||
}
|
||||
|
||||
function getSortIcon(columnId: string) {
|
||||
if (sort?.field !== columnId) return <ArrowUpDown className="ml-1 h-3.5 w-3.5" />;
|
||||
if (sort?.field !== columnId) return <ArrowUpDown className="ml-1 h-3.5 w-3.5" aria-hidden />;
|
||||
return sort.direction === 'asc' ? (
|
||||
<ArrowUp className="ml-1 h-3.5 w-3.5" />
|
||||
<ArrowUp className="ml-1 h-3.5 w-3.5" aria-hidden />
|
||||
) : (
|
||||
<ArrowDown className="ml-1 h-3.5 w-3.5" />
|
||||
<ArrowDown className="ml-1 h-3.5 w-3.5" aria-hidden />
|
||||
);
|
||||
}
|
||||
|
||||
@@ -279,7 +279,7 @@ export function DataTable<TData>({
|
||||
<TableRow>
|
||||
<TableCell colSpan={allColumns.length} className="h-40 text-center">
|
||||
<div className="flex items-center justify-center gap-2">
|
||||
<Loader2 className="h-5 w-5 animate-spin text-muted-foreground" />
|
||||
<Loader2 className="h-5 w-5 animate-spin text-muted-foreground" aria-hidden />
|
||||
<span className="text-muted-foreground">Loading...</span>
|
||||
</div>
|
||||
</TableCell>
|
||||
@@ -350,7 +350,7 @@ export function DataTable<TData>({
|
||||
<ul className="lg:hidden flex flex-col gap-2">
|
||||
{isLoading ? (
|
||||
<li className="rounded-md border bg-card p-6 text-center">
|
||||
<Loader2 className="mx-auto h-5 w-5 animate-spin text-muted-foreground" />
|
||||
<Loader2 className="mx-auto h-5 w-5 animate-spin text-muted-foreground" aria-hidden />
|
||||
</li>
|
||||
) : rows.length === 0 ? (
|
||||
<li className="rounded-md border bg-card p-6 text-center text-sm text-muted-foreground">
|
||||
|
||||
Reference in New Issue
Block a user