fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions

View File

@@ -33,7 +33,7 @@ export function ResidentialClientDetailHeader({ client, onSaveName }: Props) {
<DetailHeaderStrip>
<div className="space-y-1">
<div className="text-xs font-semibold uppercase tracking-wide text-muted-foreground inline-flex items-center gap-1.5">
<Home className="h-3 w-3" /> Residential client
<Home className="h-3 w-3" aria-hidden /> Residential client
</div>
<h1 className="truncate text-2xl font-bold tracking-tight text-foreground">
<InlineEditableField value={client.fullName} onSave={onSaveName} />

View File

@@ -263,7 +263,7 @@ function InterestsTab({
<div className="flex items-center justify-between mb-4">
<h2 className="text-lg font-semibold">Interests</h2>
<Button size="sm" onClick={() => setOpen(true)}>
<Plus className="h-3.5 w-3.5 mr-1.5" />
<Plus className="h-3.5 w-3.5 mr-1.5" aria-hidden />
New interest
</Button>
</div>

View File

@@ -72,7 +72,7 @@ export function ResidentialClientsList() {
description="Inquiries and clients for the residential side"
actions={
<Button size="sm" onClick={() => setCreateOpen(true)}>
<Plus className="mr-1.5 h-3.5 w-3.5" />
<Plus className="mr-1.5 h-3.5 w-3.5" aria-hidden />
New
</Button>
}